Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add site relative path to view page link #391

Closed
wants to merge 1 commit into from
Closed

add site relative path to view page link #391

wants to merge 1 commit into from

Conversation

koyaan
Copy link

@koyaan koyaan commented Sep 9, 2014

The "View Page" link in the sidebar is missing the relative Path of the Site.

@OskarStark
Copy link
Member

Thank you @koyaan

Could you please provide a Test for this?

@core23
Copy link
Member

core23 commented Feb 11, 2016

ping @koyaan

@soullivaneuh
Copy link
Member

According to the new Sonata version management and next major release plan, this project has been refactored regarding branching and versioning.

If you see this message, your PR concerns a patch or a minor release and is not targeting the right branch.

So I'm closing this one, but don't see it as a refusal. If you think your work is still relevant and want to continue, feel free to reopen it on the right branch (e.g. the default one).

Regards.

@haivala
Copy link
Contributor

haivala commented Nov 9, 2016

This really should be merged.

Problem: Make 2 sites and one of them has relative path. When editing the page from the site that has relative path "view page"-link is not working right.

@core23
Copy link
Member

core23 commented Nov 9, 2016

Feel free to supply a new PR with this fix @haivala

@koyaan
Copy link
Author

koyaan commented Nov 10, 2016

@core23 @soullivaneuh just tell me what to "rebase" this to

@core23
Copy link
Member

core23 commented Nov 10, 2016

If you create a new feature / bugfix with BC => 3.x

If you can't handle this with a BC => master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants