Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

Don't remove the media item when the news item is removed #223

Closed

Conversation

rosier
Copy link
Contributor

@rosier rosier commented Nov 13, 2014

When you remove a news item the linked media item is also removed. However the same media item can be linked to multiple news items. If this is the case, you first have to unlink the media item before you can remove the news item. I think this leads to a poor user experience.

Also the media item may have been used for something else then the news item. So deleting the media item can cause broken links.

@afurculita
Copy link

+1

@sagikazarmark
Copy link
Contributor

I think this problem is not that easy. Removing a post can also cause broken links.

I would say the media should be checked upon post removal: if it is linked somewhere else, it shouldn't be removed, otherwise it is safe to be removed. However checking this is almost impossible. Media entites can be linked to anything, while it migth not be visible from the media point of view (aka. ManyToOne relation).

@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@soullivaneuh
Copy link
Member

According to the new Sonata version management and next major release plan, this project has been refactored regarding branching and versioning.

If you see this message, your PR concerns a patch or a minor release and is not targeting the right branch.

So I'm closing this one, but don't see it as a refusal. If you think your work is still relevant and want to continue, feel free to reopen it on the right branch (e.g. the default one).

Regards.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants