Allow choose fields that doesn't exist #105
Conversation
|
@spolischook What's the use case? It's a new feature in SonataAdmin I've missed? |
|
Yes, we have a new feature in Sonata - it is a MongoDb! :) So, sometimes we need choose all entries that don't have some field. |
|
OK, nice addition :). @rande Can this feature be factorized with other bundles such as PHPCR? @spolischook Can you write a doc, add tests covering this case and replace raw strings by class constants (e.g. |
| $this->active = true; | ||
| } else { | ||
| if ($data['value'] === '' || $data['value'] === null || $data['value'] === false || $data['value'] === 'all') { | ||
| return; | ||
| } | ||
|
|
||
| if ($data['type'] == ChoiceType::TYPE_NOT_CONTAINS) { | ||
| if ('notExistentField' == $data['value']) { |
There was a problem hiding this comment.
Please use === instead of == everywhere please (type are not checked everywhere in the existing code base but this will be fixed).
|
And what if someone want to search for the "notExistentField" value? It would be better to add a new key to the |
|
@spolischook any news about this PR? |
|
@dunglas thanx for reminder. I'll try finish it in a next few days |
|
Could you please rebase your PR and fix merge conflicts? |
|
According to the new Sonata version management and next major release plan, this project has been refactored regarding branching and versioning. If you see this message, your PR concerns a patch or a minor release and is not targeting the right branch. So I'm closing this one, but don't see it as a refusal. If you think your work is still relevant and want to continue, feel free to reopen it on the right branch (e.g. the default one). Regards. |
No description provided.