Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer improvements and migrate for 3.0 #637

Closed
wants to merge 2 commits into from
Closed

Composer improvements and migrate for 3.0 #637

wants to merge 2 commits into from

Conversation

alexkvak
Copy link

@alexkvak alexkvak commented May 9, 2016

No description provided.

@soullivaneuh
Copy link
Member

Could you please update your PR and commit to have something like this one ? sonata-project/SonataCoreBundle#240

@soullivaneuh soullivaneuh changed the title Fix dependencies since admin-bundle, block-bundle and core-bundle hav… Composer improvements and migrate for 3.0 May 9, 2016
@alexkvak
Copy link
Author

alexkvak commented May 9, 2016

@soullivaneuh Yes, I can, but I don't understand, what version choices I need to use

@soullivaneuh
Copy link
Member

@alexkvak Branch alias should be 3.x-dev and composer should follow the new format: https://github.com/sonata-project/SonataCoreBundle/pull/240/files

@alexkvak
Copy link
Author

alexkvak commented May 9, 2016

@soullivaneuh under new format you mean Caret ^ instead of Tilde ~ ?

@soullivaneuh
Copy link
Member

soullivaneuh commented May 9, 2016

Yes. And || instead of |.

"friendsofsymfony/rest-bundle": "~1.1",
"jms/serializer-bundle": "~0.11|~1.0",
"nelmio/api-doc-bundle": "~2.4"
"sonata-project/doctrine-orm-admin-bundle": "^2.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be ^3.0 right?

Copy link
Member

@soullivaneuh soullivaneuh May 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good catch!

@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@soullivaneuh
Copy link
Member

Done in 4569882.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants