Fix tree view BC break #639
Conversation
|
Hello, and thanks for your contribution! Please read and apply : https://github.com/sonata-project/SonataAdminBundle/blob/master/CONTRIBUTING.md#the-commit-message |
| <i class="fa fa-list"></i> {{ 'pages.list_mode'|trans({}, 'SonataPageBundle') }} | ||
| </a> | ||
| <a type="button" class="btn {% if mode == 'tree' %}btn-info active{% else %}btn-default{% endif %}" href="{{ admin.generateUrl('tree') }}"> | ||
| <a type="button" class="btn {% if mode == 'tree' %}btn-info active{% else %}btn-default{% endif %}" href="{{ admin.generateUrl('tree', { 'filter': { 'site': { 'value': currentSite.id|default('') }}}) }}"> |
There was a problem hiding this comment.
Please linebreak this line.
|
👍 Think I got most of it, tell me if I missed some. |
|
Please have a look at travis @Neodork |
| @@ -1,12 +1,15 @@ | |||
| CHANGELOG | |||
| ========= | |||
|
|
|||
This fixed the tree view showing if no filter is defined, show list view instead. The tree view has no functionality for SonataAdminBundle's sonata_type_model causing a BC break.
|
@core23 My bad OCD stuff, didn't even notice. |
|
This is still incomplete I noticed in one of my projects. PR on hold till further notice. |
|
Could you please rebase your PR and fix merge conflicts? |
|
According to the new Sonata version management and next major release plan, this project has been refactored regarding branching and versioning. If you see this message, your PR concerns a patch or a minor release and is not targeting the right branch. So I'm closing this one, but don't see it as a refusal. If you think your work is still relevant and want to continue, feel free to reopen it on the right branch (e.g. the default one). Regards. |
Pr for #638