Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC break because of tree view #638

Closed
Neodork opened this issue May 16, 2016 · 4 comments
Closed

BC break because of tree view #638

Neodork opened this issue May 16, 2016 · 4 comments

Comments

@Neodork
Copy link

Neodork commented May 16, 2016

The following code is BC break with Sonata Admin Bundle and Sonata Block Bundle introduced by
2fbd2e1. Linked entities (with sonata_type_model_list form type) in blocks or admins now go to the Tree view page as default. The tree page however has no "Select" feature and a click on the name redirects to the edit page admin menu.

Note: Did not test admin, did test blocks.

   //PageAdminController.php

    /**
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function listAction()
    {
        if (!$this->getRequest()->get('filter')) { // <--- BC break
            // Redirects us to tree view, tree view has no SELECT feature
            return new RedirectResponse($this->admin->generateUrl('tree'));
        }

        return parent::listAction();
    }

Not sure what to do with it, what does Sonata think of this? @core23

@OskarStark
Copy link
Member

OskarStark commented May 17, 2016

for now it looks as a BC break to me, too!

@Neodork
Copy link
Author

Neodork commented Jun 28, 2016

@core23 Should I separate sonata-project/SonataAdminBundle#3863 from this issue? They are not fully the same. Because even when the filtering is fixed the sonata_type_model_list will still not be able to operate with the treeview as default.

So I was thinking keep the filter in the code. Then filtering can be fixed in sonata-project/SonataAdminBundle#3863 and we will have the sonata_type_model_list functionality working.

Your thoughts?

@core23
Copy link
Member

core23 commented Jun 29, 2016

We should fix the admin issue first and test, if this will (partial) solve the other issue. After that we could have a look at this bundle.

@stale
Copy link

stale bot commented Jan 30, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 30, 2020
@SonataCI SonataCI removed the wontfix label Jan 30, 2020
@core23 core23 added the stale label Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants