Fixed tree view showing if no filter parameter is defined #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixed the tree view showing if no filter parameter is defined, show list view instead. The tree view has no functionality for SonataAdminBundle's sonata_type_model_list causing a BC break. Removes the page filter from tree view, it never worked.
If this is a BC break, the PR must not be on a stable branch. BTW, the 2.x branch is not maintained anymore. If the bug is still relevant on 3.x, don't hesitate to open another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targeting this branch, because this is a BC break in 2.x.
Closes #638
Changelog
To do
Subject
Will fix tree view showing as default in the page admin. Showing the tree view as default breaks the sonata_type_model_list. Tree view has no select functionality. Also removed the filter from the tree view. The filter never worked for the tree view.