order found snapshots by publicationDateStart

[koyaan]

It is counterintuitive that if more then one snapshot matches the date criteria, the one that was created first is selected, it should be the one with the newest startDate.

[rande]

This is a major BC break ?

[koyaan]

It is? why can we even have multiple matching snapshots?

[koyaan]

@rande if this will never be merged because it is too big of a BC i will close and just use my fork for my projects. But feedback from people using it, is highly in favor of this change since the need to manually delete or deactivate older snapshots makes the ux much more complicated and error prone.

[OskarStark]

This is BC because you set $query->setMaxResults(1);

[soullivaneuh]

This is BC because you set $query->setMaxResults(1);

I don't think so. This code part is already here.

[OskarStark]

yes, but it changed the behavior/result by sorting it another why, doesn't it?

[soullivaneuh]

According to the new Sonata version management and next major release plan, this project has been refactored regarding branching and versioning.

If you see this message, your PR concerns a patch or a minor release and is not targeting the right branch.

So I'm closing this one, but don't see it as a refusal. If you think your work is still relevant and want to continue, feel free to reopen it on the right branch (e.g. the default one).

Regards.