Avoid Attempted to call an undefined method named "getName" with tests #37
Conversation
| $this->assertSame('GetNameNull', $admin->toString($s)); | ||
|
|
||
| $s = new DummyNoGetName(); | ||
| $this->assertSame('NoGetName', $admin->toString($s)); |
There was a problem hiding this comment.
Please use a data provider. Some will probably also ask you to move dummy classes to a fixtures namespace (what do you think @sonata-project/contributors ? ).
|
Also @stphnpt , there was no need to close #36 : you can just force push new commits to the same branch, and your PR will update. |
| { | ||
| public function testToString() | ||
| { | ||
| $admin = new BlockAdmin('sonata.dashboard.admin.block', 'DashboardBundle\Entity\BaseBlock', 'SonataDashboardBundle:BlockAdmin'); |
|
LGTM 👍 |
|
@soullivaneuh @greg0ire do we have no Style CI check here? Oo |
|
@OskarStark This project is not already on dev-kit. Waiting this: #31 |
|
According to the new Sonata version management and next major release plan, this project has been refactored regarding branching and versioning. If you see this message, your PR concerns a patch or a minor release and is not targeting the right branch. So I'm closing this one, but don't see it as a refusal. If you think your work is still relevant and want to continue, feel free to reopen it on the right branch (e.g. the default one). Regards. |
with tests of toString update