This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 21
Avoid Attempted to call an undefined method named "getName" with tests #37
Closed
Closed
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Sonata Project package. | ||
* | ||
* (c) Thomas Rabaix <[email protected]> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Sonata\DashboardBundle\Tests\Admin; | ||
|
||
use Sonata\AdminBundle\Admin\Admin; | ||
use Sonata\DashboardBundle\Admin\BlockAdmin; | ||
use Sonata\DashboardBundle\Tests\Fixtures\Entity\FooGetName; | ||
use Sonata\DashboardBundle\Tests\Fixtures\Entity\FooGetNameNull; | ||
use Sonata\DashboardBundle\Tests\Fixtures\Entity\FooNoGetName; | ||
|
||
class BlockAdminTest extends \PHPUnit_Framework_TestCase | ||
{ | ||
public function testToString() | ||
{ | ||
$admin = new BlockAdmin('sonata.dashboard.admin.block', 'DashboardBundle\Entity\BaseBlock', 'SonataDashboardBundle:BlockAdmin'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please line break this |
||
|
||
$s = new FooGetName(); | ||
$this->assertSame('GetName', $admin->toString($s)); | ||
|
||
$s = new FooGetNameNull(); | ||
$this->assertSame('GetNameNull', $admin->toString($s)); | ||
|
||
$s = new FooNoGetName(); | ||
$this->assertSame('NoGetName', $admin->toString($s)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please use a data provider. Some will probably also ask you to move dummy classes to a fixtures namespace (what do you think @sonata-project/contributors ? ). |
||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<?php | ||
|
||
namespace Sonata\DashboardBundle\Tests\Fixtures\Entity; | ||
|
||
class FooGetName | ||
{ | ||
public function getName() | ||
{ | ||
return 'GetName'; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
<?php | ||
|
||
namespace Sonata\DashboardBundle\Tests\Fixtures\Entity; | ||
|
||
class FooGetNameNull | ||
{ | ||
public function getName() | ||
{ | ||
return; | ||
} | ||
|
||
public function __toString() | ||
{ | ||
return 'GetNameNull'; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<?php | ||
|
||
namespace Sonata\DashboardBundle\Tests\Fixtures\Entity; | ||
|
||
class FooNoGetName | ||
{ | ||
public function __toString() | ||
{ | ||
return 'NoGetName'; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add an
@author
tag