Releases
v11.2.0
2018-11-15, Version 11.2.0 (Current), @BridgeAR
targos
released this
15 Nov 21:24
Notable changes
deps :
A new experimental HTTP parser (llhttp
) is now supported. #24059
timers :
Fixed an issue that could cause setTimeout to stop working as expected. #24322
Windows
A crashing process will now show the names of stack frames if the node.pdb file is available. #23822
Continued effort to improve the installer's new stage that installs
native build tools. #23987 , #24348
child_process :
On Windows the windowsHide
option default was restored to false
.
This means detached
child processes and GUI apps will once again
start in a new window. #24034
Added new collaborators :
Commits
[685724b53d
] - assert : remove unused catch bindings (cjihrig) #24079
[bb766ae05a
] - async_hooks : add HandleScopes to C++ embedder/addon API (Anna Henningsen) #24285
[ad5c9b4463
] - benchmark : support more options in startup benchmark (Joyee Cheung) #24220
[d0bf8c2259
] - benchmark : add dir and withFileTypes option readdir benchmarks (Joyee Cheung) #24125
[40b3ad3eb8
] - benchmark : remove unused catch bindings (cjihrig) #24079
[1f3cb63da3
] - bootstrap : remove unused catch bindings (cjihrig) #24079
[fcc25f9ee8
] - buffer : fix writeUInt16BE range check (Brian White) #24208
[e4cd255a85
] - buffer : throw exception when creating from non-Node.js Context (Anna Henningsen) #23938
[44ebdbb860
] - build : fix benchmark tests on CI (Rich Trott) #24307
[1c8b4d7c89
] - build : disable openssl asm on arm64 for now (Ben Noordhuis) #24270
[0c9d86f58c
] - build : use BUILDTYPE in bench-addons-build targets (Daniel Bevenius) #24033
[70699ee09b
] - build : lint commit message in separate Travis job (Richard Lau) #24254
[2b282e8f20
] - build : move headers out of c++ src section (Daniel Bevenius) #24124
[a8008d1517
] - build : only try to find node when it's needed by the target (Joyee Cheung) #24115
[e4bcb97024
] - build : change repo to https protocol in Makefile (mritunjaygoutam12) #24073
[7083b96c49
] - build : use latest node on travis (cjihrig) #24198
[99c2a10f7b
] - build : fix Travis non-PR builds (Richard Lau) #24093
[3de1c5cadd
] - build : do not lint on non-PR Travis builds (Anna Henningsen) #24076
[762679efec
] - build : make benchmark/napi all prereq order-only (Daniel Bevenius) #23951
[4651cd721d
] - build : add -Werror=undefined-inline to clang builds (Refael Ackermann) #23961
[e7133f1e7c
] - build : configure default v8_optimized_debug (Refael Ackermann) #23704
[26c19889a8
] - build,meta : don't fail Travis for commit message (Refael Ackermann) #23739
[838fb550c6
] - build,tools : update make-v8.sh for s390x (Refael Ackermann) #23839
[c07cce368a
] - Revert "child_process : change windowsHide default to true" (Rich Trott) #24034
[a1c7c1902a
] - child_process : allow 'http_parser' monkey patching again (Jimb Esser) #24006
[4af63ee5d9
] - child_process : handle undefined/null for fork() args (Shobhit Chittora) #22416
[a2c13fac94
] - console : console.timeLog() using the default label (Marie Terrier) #24286
[9e891327b7
] - console : cover .assert with single argument (Morgan Roderick) #24188
[2b48c7169a
] - crypto : put legacy _handle accessors on prototypes (Michaël Zasso) #24269
[f669817a5a
] - (SEMVER-MINOR) crypto : add support for chacha20-poly1305 for AEAD (chux0519) #24081
[ef69e7bcca
] - deps : backport 073073b4f1 from upstream V8 (Yang Guo) #24274
[a39493f4aa
] - deps : cherry-pick b87d408 from upstream V8 (Peter Marshall) #24272
[9cefbba5d7
] - deps : patch V8 to 7.0.276.38 (Michaël Zasso) #24271
[115c57a240
] - deps : introduce llhttp
(Fedor Indutny) #24059
[566399ee31
] - deps : patch V8 to 7.0.276.36 (Michaël Zasso) #24109
[3e1c53fe37
] - deps : cherry-pick 0483e9a from upstream V8 (Joyee Cheung) #24125
[6b697d4816
] - deps : c-ares float, version number patch (Ben Noordhuis) #23854
[07663694b4
] - deps : upgrade to c-ares v1.15.0 (Ben Noordhuis) #23854
[eaea90b2ee
] - deps : remove old c-ares configure files (Ben Noordhuis) #23854
[f49b9e9c84
] - deps : patch V8 to 7.0.276.35 (Michaël Zasso) #24056
[6e4f238344
] - deps,v8 : cherry-pick dc704497 (Refael Ackermann) #23985
[ef8b5b4094
] - deps,v8 : fix gypfile bug (Refael Ackermann) #23704
[a01e829fb0
] - doc : document http request.finished boolean (Thomas Watson) #24319
[36e4d0c6f0
] - doc : document NODE_TLS_REJECT_UNAUTHORIZED (cjihrig) #24289
[fbd0b037ec
] - doc : clarify issues and pull requests guidance (Rich Trott) #24316
[a993a488fa
] - doc : fix comma splices in process.md (Rich Trott) #24357
[e584cc52fc
] - doc : use real protocol names in ALPN example (Sam Roberts) #24232
[7fc910763e
] - doc : update core-validate-commit url (Daijiro Wachi) #24331
[39382ed4e1
] - doc : fix echo example programs (Sam Roberts) #24235
[c68b0ae46e
] - doc : update fs.open() changes record for optional 'flags' (Rod Vagg) #24240
[6b7e69875d
] - doc : add links to Stream section (Dmitry Igrishin) #24301
[82c64d0008
] - doc : correct async_hooks sample outputs (Gerhard Stoebich) #24050
[991d066338
] - doc : add oyyd to collaborators (Ouyang Yadong) #24300
[118d8d0feb
] - doc : edit BUILDING.md (Rich Trott) #24243
[b5b5f9f8bd
] - doc : fix code examples in stream.md (Grant Carthew) #24112
[6ab46b5c47
] - doc : fix some inconsistent use of hostname (Sam Roberts) #24199
[1b81b348a3
] - doc : describe what tls servername is for (Sam Roberts) #24236
[104b076d3d
] - doc : clarify allowed encoding parameter types (Sam Roberts) #24230
[7bcc4ccd8e
] - doc : remove legacy WPT integration guide (Joyee Cheung) #24035
[7cc3b9337f
] - doc : fix linting errors (cjihrig) #24229
[3ce71f7723
] - doc : wrap GOVERNANCE.md at 80 characters (Rich Trott) #24094
[161be13602
] - doc : add text about error.code stability (Rich Trott) #24090
[2143b56b19
] - doc : update System Errors documentation (Rich Trott) #24090
[75ed7ce4a3
] - doc : add psmarshall to collaborators (Peter Marshall) #24170
[f9f185a47b
] - doc : add shisama to collaborators (Masashi Hirano) #24136
[d15270507e
] - doc : implement minor text fixes to path.md (Rich Trott) #24118
[8642eacfff
] - doc : inspector security warning for changing host (Сковорода Никита Андреевич) #23640
[5ea48a92b2
] - doc : fix minor text issues in stream.md (Rich Trott) #24116
[6f54a7ace8
] - doc : streamline CONTRIBUTING.md (Rich Trott) #24010
[3b1044072c
] - doc : add table of contents to release guide (Michaël Zasso) #24042
[667ce42447
] - doc : add missing comma in net documentation (Rich Trott) #24074
[1d6d384c02
] - doc : correct link to test coverage command (mritunjaygoutam12) #24049
[94f73942ed
] - doc : fix socket.connecting description (Anna Henningsen) #24066
[fa84164de4
] - doc : add SECURITY.md to readme.md (warnerp18) #24031
[e8078f2693
] - doc : edit man page for superfluous "node" usage (Rich Trott) #24029
[a1b75d0cbf
] - doc : fix dublication in net.createServer() docs (Ivan Filenko) #24026
[d729f3e198
] - doc : correct async_hooks resource names (Gerhard Stoebich) #24001
[7012f72a12
] - doc : address bits of proof reading work (Jagannath Bhat) #23978
[399d64b331
] - doc : revise COLLABORATOR_GUIDE.md (Rich Trott) #23990
[879402b422
] - doc : simplify CODE_OF_CONDUCT.md (Rich Trott) #23989
[7b7155e90b
] - doc : revise CHANGELOG.md text (Rich Trott) #23988
[b8a71bed02
] - doc : improve COLLABORATOR_GUIDE (Jagannath Bhat) #23977
[846e450f51
] - doc : improve BUILDING.md (Jagannath Bhat) #23976
[b182e2e8b2
] - doc : add types and their corresponding return values (Ouyang Yadong) #23998
[2d84f45d22
] - esm : remove unused catch bindings (cjihrig) #24079
[5ecfc7cab7
] - events : remove unused catch bindings (cjihrig) #24079
[f49b4fc794
] - fs : replace pushValueToArray with pure C++ API (Joyee Cheung) #24125
[d59dc0d6bf
] - fs : remove unused catch bindings (cjihrig) #24079
[424be28840
] - fs : handle result of access binding directly in fs.existsSync (Joyee Cheung) #24015
[2aa23cd433
] - (SEMVER-MINOR) fs,net : standardize pending
stream property (Anna Henningsen) #24067
[86aa27f85d
] - http : remove pushValueToArray in Parser::CreateHeaders() (Joyee Cheung) #24264
[c2599a14de
] - http : remove obsolete function escapeHeaderValue (Lauri Piisang) #24173
[62fefd8aeb
] - http2 : remove pushValueToArray in Http2Session::HandleOriginFrame (Joyee Cheung) #24264
[7ffbb1f55f
] - http2 : remove pushValueToArray in Http2Session::HandleHeadersFrame (Joyee Cheung) #24264
[4a0f27656d
] - (SEMVER-MINOR) http2 : add Http2Stream.bufferSize (Ouyang Yadong) #23711
[c7f471ab97
] - http2 : improve http2 code a bit (James M Snell) #23984
[4dbcf7ac1f
] - inspector : remove unused catch bindings (cjihrig) #24079
[5ca0cf7ae6
] - lib : improved conditional check in zlib (Dan Corman) #24190
[d8d93442aa
] - lib : adjust params from uvExceptionWithHostPort (msmichellegar) #24159
[6f80a45528
] - lib : combine contructor, tag, Object into a function (Paul Isache) #24171
[1225a0af09
] - lib : add crypto dependant modules cannotUseCache (Daniel Bevenius) #24100
[453c96ed2d
] - lib : move process prototype manipulation into setupProcessObject (Joyee Cheung) #24089
[6a6b036042
] - lib : move internalBinding whitelisting into loaders.js (Joyee Cheung) #24088
[b4c8158459
] - lib : fix grammar error and make it clearer for comments (MaleDong) #23799
[879c0f1f3e
] - lib : move module exports proxy into a separate method (Joyee Cheung) #24057
[874393bfd0
] - lib : remove useless getLibuvNow in internal/timers (ZYSzys) #23995
[7ee0cea028
] - lib : make coverage work for Node.js (Benjamin) #23941
[b3f3ebf3b3
] - lib : repl multiline history support (Anto Aravinth) #22153
[55adc25968
] - (SEMVER-MINOR) lib : enable TypedArray and DataView for the v8 module (Ouyang Yadong) #23953
[5ff1e67ff7
] - lib : fix code cache generation (Joyee Cheung) #23855
[164f2444a0
] - lib : remove useless cwd in posix.resolve (ZYSzys) #23902
[10156c612d
] - meta,doc : ping community about new release (Refael Ackermann) #24064
[1dd8191515
] - (SEMVER-MINOR) module : support multi-dot file extension (Geoffrey Booth) #23416
[72204d114f
] - n-api : add missing handle scopes (Daniel Bevenius) #24011
[10edc4f186
] - net : always invoke after-write callback (Anna Henningsen) #24291
[753f706858
] - net : add comments explaining error check (Steven Gabarro) #24222
[c53117e7ea
] - net : remove unreachable check in internalConnect (Philipp Dunkel) #24158
[74451263a3
] - net : partially revert "simplify Socket.prototype._final" (Anna Henningsen) #24288
[636e4e02a5
] - net : simplify Socket.prototype._final (Anna Henningsen) #24075
[cd227eb791
] - net : net.Server.listen()
avoid operations on null
when fail (Ouyang Yadong) #23920
[293983a112
] - os : do not call into JS to push values to an array in GetCPUInfo (Joyee Cheung) #24264
[ccc3bb73db
] - process : remove pushValueToArray in GetActiveHandles (Joyee Cheung) #24264
[ba4337d77d
] - process : remove pushValueToArray in GetActiveRequests (Joyee Cheung) #24264
[e5888462f6
] - process : remove pushValueToArray in EnvEnumerator (Joyee Cheung) #24264
[52468b33f7
] - querystring : remove unused catch bindings (cjihrig) #24079
[213b6293fc
] - repl : remove unused catch bindings (cjihrig) #24079
[e27f43201c
] - repl : use promise#finally (Weijia Wang) #23971
[b7aded3300
] - src : compile native modules and their code cache in C++ (Joyee Cheung) #24221
[92a8cbe87a
] - src : enable detailed source positions in V8 (Yang Guo) #24274
[f8ed673308
] - src : remove pushValueToArray and SetupProcessObject (Joyee Cheung) #24264
[7601cdfe8b
] - src : bundle persistent-to-local methods as class (Gabriel Schulhof) #24276
[f5945c9279
] - src : sort internal binding list (cjihrig) #24292
[e1c792919e
] - src : fix v8 compiler warnings in src (Daniel Bevenius) #24246
[81f4fb2b3b
] - src : reuse std::make_unique (alyssaq) #24132
[a9053c38ea
] - src : cache the result of GetOptions() in JS land (Joyee Cheung) #24091
[17e80eca95
] - src : prefer param function check over args length (Shelley Vohr) #23835
[1cda9b3988
] - src : fix Set() usage in env-inl.h (cjihrig) #24060
[bef1c3b748
] - src : fix Set() usage in node.h (cjihrig) #24060
[2a93882498
] - src : fix Get() usage in tls_wrap.cc (cjihrig) #24060
[9437aaad26
] - src : fix Get() usage in async_wrap.cc (cjihrig) #24060
[cb7d9f9980
] - src : move error handling code into node_errors.cc (Joyee Cheung) #24058
[fdba226d13
] - src : fix compiler warning for debug build (Daniel Bevenius) #23994
[84e5807b1e
] - src : fix CreatePlatform header param mismatch (Shelley Vohr) #23947
[38b0525bc3
] - src : use v8:: for consistency in util (ZYSzys) #23934
[90872c4c6e
] - src : fix fully-static & large-pages combination (Suresh Srinivas) #23964
[063b40edc1
] - src : use "constants" string instead of creating new one (Ouyang Yadong) #23894
[24b18645b9
] - src,win : informative stack traces (Refael Ackermann) #23822
[13dee430cd
] - stream : make .destroy()
interact better with write queue (Anna Henningsen) #24062
[d6bcf8b98b
] - (SEMVER-MINOR) stream : add auto-destroy mode (Mathias Buus) #22795
[2593b40f5c
] - test : compare objects not identical by reference (Marie Terrier) #24189
[eeb5cc6305
] - test : add typeerror for vm/compileFunction params (Dan Corman) #24179
[dc26247e69
] - test : deep object to table not covered (Osmond van Hemert) #24257
[29a29f7f97
] - test : add tests for Socket.setNoDelay (James Herrington) #24250
[aa800b097a
] - test : assert diff no color (Florin-Daniel BÎLBÎE) #24181
[b6d2819b93
] - test : add process no deprecation (razvanbh) #24196
[dd9864b8d7
] - test : check for invalid module type in vm.js (alyssaq) #24161
[957ceaabe6
] - test : fix flaky test-vm-timeout-escape-queuemicrotask (Rich Trott) #24296
[89c3388a77
] - test : fix arguments order in assertions (Emanuel Kluge) #24149
[ea5d1841af
] - test : remove unused parameters in function definition (Paul Hodgson) #24268
[cb4c2dd33e
] - test : esm loader unknown builtin module (Fran Herrero) #24183
[1a86499947
] - test : fixed order of actual and expected arguments (kiyomizumia) #24178
[77163a9dee
] - test : add else and error case for TextDecoder (Lauri Piisang) #24162
[e5e9c6427b
] - test : dgram socket prints deprecation warnings (Robert Pamely) #24177
[366529654e
] - test : url format path ending hashchar not covered (Osmond van Hemert) #24259
[0a104ef33c
] - test : test add and remove for lib/domain (Petar Dodev) #24163
[fe7ef1ad11
] - test : add test for autoDestroy in stream (Daijiro Wachi) #24127
[02e9fa01f3
] - test : fix args order in process-getactiverequests (Vladyslav Kopylash) #24186
[f805db3620
] - test : check control characters replacing (Alessandro Gatti) #24182
[75e4f7db40
] - test : fix strictEqual argument order (Martin Kask) #24153
[09a8f4713d
] - test : correct order of args in assert.strictEqual() (Natalie Cluer) #24157
[c83b650a10
] - test : add tests for process.initgroups (James Herrington) #24154
[762bb94d72
] - test : add test case for completion bash flag (Aivo Paas) #24168
[afcfdec289
] - test : add test for deepEqual Float32Array (Yehiyam Livneh) #24164
[b02eed5e3b
] - test : fix arguments order in assert.strictEqual() (Ulises Santana Suárez) #24192
[768425f21a
] - test : fix assert.strictEqual argument order (John Mc Quillan) #24172
[26c625c3d2
] - test : fix v8 Set/Get compiler warnings (Daniel Bevenius) #24246
[beb0800ab3
] - test : move benchmark tests out of main test suite (Rich Trott) #24265
[883519679e
] - test : replacing fixture directory with temp (saurabhSiddhu) #24077
[ddbd0e1973
] - test : increase coverage internal readline (Berry de Witte) #24150
[56cd911cad
] - test : use NULL instead of 0 in common.h (Daniel Bevenius) #24104
[a05f2fc46b
] - test : move test-fs-watch-system-limit from sequential to pummel (Marcus Scott) #23692
[9af7ad592c
] - test : fix uses of deprecated assert.fail with multiple args (ivan.filenko) #23673
[2b0410a3ef
] - test : use assert.strictEqual instead of assert.equal (ivan.filenko) #23673
[825f0dda5b
] - test : add test for strictDeepEqual (Nikita Malyschkin) #24197
[b16e485910
] - test : add coverage for systemerror set name (Amer Alimanović) #24200
[bc97b62f35
] - test : fix order of arguments in assert.strictEqual (Alex Seifert) #24145
[4a69d218b6
] - test : add test for 'ERR_INVALID_CALLBACK' (razvanbh) #24224
[8b0626c836
] - test : add coverage for escape key switch case (Artur Daschevici) #24194
[92d2d7917f
] - test : fix NewFromUtf8 compiler warning (Daniel Bevenius) #24216
[0c4facfbaf
] - test : change arguments order in strictEqual (Paul Isache) #24156
[2baa59b897
] - test : switch order of strictEqual arguments (Jonah Polack) #24185
[c8d8e5cf2c
] - test : fix the arguments order in assert.strictEqual
(mzucker) #24227
[4245cbbf49
] - test : fix the arguments order in assert.strictEqual
(mzucker) #24226
[be40fd1e50
] - test : fix order in assert.strictEqual to actual, expected (Kevin Seidel) #24184
[a1f5179e09
] - test : fix arguments order in assert.strictEqual (szabolcsit) #24143
[5510bec3cc
] - test : fix assert argument order (Manish Poddar) #24160
[e46b8edb58
] - test : add error code tests in dgram test (Mark Arranz) #24215
[6076ccf90d
] - test : fix order of arguments in test-delayed-require assertion (reineke-fox) #24165
[989c2aaf83
] - test : fix flaky test-vm-timeout-escape-nexttick (Rich Trott) #24251
[b68734b66a
] - test : initialize test/wpt to run URL and console .js tests (Joyee Cheung) #24035
[c973551eca
] - test : use URL fixtures under test/fixtures/wpt/url/resources (Joyee Cheung) #24035
[3f935d74e0
] - test : remove WPT tests that are now .any.js in the upstream (Joyee Cheung) #24035
[121a3f8855
] - test : use git node wpt to pull WPT into test/fixtures (Joyee Cheung) #24035
[317901174c
] - test : fix arguments order in test-fs-write-buffer (razvanbh) #24155
[9b3c2e5054
] - test : fix argument order in assert.strictEqual() (Clement) #24147
[2d87ce3d8b
] - test : switch arguments in strictEqual (Mathieu Pavageau) #24141
[6c8b128fcc
] - test : fix arguments order (Simona Cotin) #24151
[3d19a04b51
] - test : fixe argument order in assert.strictEqual (Marc Posth) #24140
[a0681b7211
] - test : removed extraneous argument 's' (Jackson Chui) #24213
[12429812bc
] - test : fixing arguments order in assert.strictEqual()
(G. Carcaci) #24152
[fc494cdb16
] - test : add tests for OutgoingMessage setTimeout (Robin Drexler) #24148
[ce124aca65
] - test : swap expected and actual in assert.strictEqual (Florin-Daniel BÎLBÎE) #24146
[737f897b51
] - test : fix assert parameter order (Roland Broekema) #24144
[d85161cbfd
] - test : change order of assert.strictEqual() (Remy Parzinski) #24142
[fb58ada9dd
] - test : fix invalid argument order in test-http-expect-continue.js (Morgan Roderick) #24138
[7cc0a46e85
] - test : strictEqual argument order (actual, expected) (Ahmad Nassri) #24137
[a5ac7b94ea
] - test : fixed the arguments order in assert.strictEqual
(mzucker) #24135
[71545e6284
] - test : swap the order of arguments (Musa Hamwala) #24134
[a8908f16f7
] - test : fs readfile, swap arguments in strictEqual (Petar Dodev) #24133
[7c04fe07a6
] - test : fix arguments order (Fran Herrero) #24131
[6f80a5eeda
] - test : http-client-timeout error assert arguments (Tadhg Creedon) #24130
[415fcded15
] - test : fix flaky VM timeout test on Raspberry Pi (Rich Trott) #24238
[a2e2c91cfa
] - test : disable color formating for test-internal-errors.js (Refael Ackermann) #24204
[a35bcd5ef5
] - test : remove unused catch bindings (cjihrig) #24079
[9bf36bc6c3
] - test : add a test for tls.Socket
with allowHalfOpen
(Ouyang Yadong) #23866
[8a3836ec72
] - test : add crypto check to test-benchmark-http2 (Daniel Bevenius) #24096
[b86a89b9ad
] - test : increase --stack_size test-async-wrap-pop (Daniel Bevenius) #23996
[1b97dbd6b5
] - test : assert that invalidcmd throws error code (Jerome Covington) #23942
[63778b7ae1
] - test : fix strictEqual arguments order (Esteban Sotillo) #23956
[dccf4a6c38
] - test : add property for RangeError in test-buffer-copy (mritunjaygoutam12) #23968
[8bffd90933
] - test : fix test-fs-watch-system-limit (Ali Ijaz Sheikh) #23986
[7a2134c414
] - test : run code cache test by default and test generator (Joyee Cheung) #23855
[5b9ef11e35
] - timers : fix priority queue removeAt (Anatoli Papirovski) #24322
[d6f91ba139
] - (SEMVER-MINOR) tls : get the local certificate after tls handshake (Sam Roberts) #24261
[ad72e40e5b
] - tools : update ESLint to 5.9.0 (cjihrig) #24280
[6fdc5d9c9a
] - tools : enable 80-char line length markdown linting (Rich Trott) #24094
[b3c163f11b
] - tools : lint for unused catch bindings (cjihrig) #24079
[1541c7f401
] - tools : add script to lint first PR commit message (Richard Lau) #24030
[4d7fbc3e0f
] - tools : update alternative docs versions (Richard Lau) #23980
[8de1030a70
] - tracing : fix static destruction order issue (Anna Henningsen) #24123
[0063448b04
] - url : make the context non-enumerable (Joyee Cheung) #24218
[953697a7b8
] - util : deleted unreachable code from util.inspect (kiyomizumia) #24187
[fb7c1b3e81
] - v8_prof_polyfill : remove unused catch bindings (cjihrig) #24079
[9c15124aa8
] - vm : clarify timeout option in vm (Vladimir de Turckheim) #23512
[2331181410
] - vm : allow cachedData
to also be TypedArray|DataView (Benjamin Chen) #22921
[4709fe676d
] - win : add customization warning to tools script (João Reis) #24348
[57a2b957de
] - win : add prompt to tools installation script (João Reis) #23987
[df1ca0fd82
] - win : clarify Boxstarter behavior on install tools (Rob Reynolds) #23987
You can’t perform that action at this time.