-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build,tools: update make-v8.sh for s390x #23839
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
tools
Issues and PRs related to the tools directory.
v8 engine
Issues and PRs related to the V8 dependency.
labels
Oct 23, 2018
mhdawson
approved these changes
Oct 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jasnell
approved these changes
Nov 10, 2018
pull bot
pushed a commit
to shakir-abdo/node
that referenced
this pull request
Nov 10, 2018
PR-URL: nodejs#23839 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
Lande in d0e593e |
3 tasks
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
PR-URL: #23839 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
PR-URL: nodejs#23839 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Nov 15, 2018
codebytere
pushed a commit
that referenced
this pull request
Dec 14, 2018
PR-URL: #23839 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 26, 2018
PR-URL: #23839 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Jan 29, 2019
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to nodejs/build#1536
/CC @nodejs/platform-s390
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes