build: make benchmark/napi all prereq order-only #23951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the all prerequisites order-only to prevent this target's rules to be executed every time which is currently the case as the all target is a phony target and will be executed every time.
nodejs-github-bot
added
the
build
refack
reviewed
Oct 29, 2018
Makefile
Outdated
| benchmark/napi/function_call/binding.gyp | ||
| $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \ | ||
| benchmark/napi/function_call/binding.gyp | all | ||
| @$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \ |
There was a problem hiding this comment.
As a general rule I prefer not to silence make commands without an escape hatch via V=1
There was a problem hiding this comment.
Maybe if we make a rule for binding.gyp files we could catch two birds. (1) get it to echo iff V=1 and DRY the code.
There was a problem hiding this comment.
Something like:
quiet_cmd_node_gyp = NODE-GYP($(TOOLSET)) $@
cmd_node_gyp = $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild --python="$(PYTHON)" --nodedir="$(shell pwd)" --directory="$(abspath $(dir $(dir $(dir $@))))"
$(obj).$(TOOLSET)/binding.node: $(obj).$(TOOLSET)/binding.gyp FORCE_DO_CMD
@$(call do_cmd,node_gyp,1)Derived for the GYP generated /out/MakeFile
There was a problem hiding this comment.
This PR was not intended to be about silencing the command, but not having this recipe executed every time. I added the @ by mistake. I'll update shortly, thanks.
|
For build file related changes please ping @nodejs/build-files, thank you. |
richardlau
approved these changes
Oct 30, 2018
fhinkel
approved these changes
Oct 30, 2018
refack
approved these changes
Oct 30, 2018
jasnell
approved these changes
Nov 1, 2018
|
Landed in 98819df. |
danbev
added a commit
that referenced
this pull request
Nov 1, 2018
This commit makes the all prerequisites order-only to prevent this target's rules to be executed every time which is currently the case as the all target is a phony target and will be executed every time. PR-URL: #23951 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 2, 2018
This commit makes the all prerequisites order-only to prevent this target's rules to be executed every time which is currently the case as the all target is a phony target and will be executed every time. PR-URL: #23951 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
This was referenced Nov 15, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Nov 27, 2018
This commit makes the all prerequisites order-only to prevent this target's rules to be executed every time which is currently the case as the all target is a phony target and will be executed every time. PR-URL: #23951 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
This commit makes the all prerequisites order-only to prevent this target's rules to be executed every time which is currently the case as the all target is a phony target and will be executed every time. PR-URL: #23951 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
This commit makes the all prerequisites order-only to prevent this target's rules to be executed every time which is currently the case as the all target is a phony target and will be executed every time. PR-URL: #23951 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 3, 2018
This commit makes the all prerequisites order-only to prevent this target's rules to be executed every time which is currently the case as the all target is a phony target and will be executed every time. PR-URL: #23951 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the all prerequisites order-only to prevent this
target's rules to be executed every time which is currently the case as
the all target is a phony target and will be executed every time.
There is some code duplication in these two targets but I though it might make reviewing difficult so I've left this for a follow up commit/pull request.
make -j4 test(UNIX), orvcbuild test(Windows) passes