Skip to content

Commit

Permalink
tools: lint for unused catch bindings
Browse files Browse the repository at this point in the history
PR-URL: #24079
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Wyatt Preul <[email protected]>
  • Loading branch information
cjihrig authored and targos committed Nov 6, 2018
1 parent 40b3ad3 commit b3c163f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Module._findPath = (request, paths, isMain) => {
if (!r && hacks.includes(request)) {
try {
return require.resolve(`./tools/node_modules/${request}`);
} catch (err) {
} catch {
return require.resolve(
`./tools/node_modules/eslint/node_modules/${request}`);
}
Expand Down Expand Up @@ -212,7 +212,7 @@ module.exports = {
'no-unsafe-finally': 'error',
'no-unsafe-negation': 'error',
'no-unused-labels': 'error',
'no-unused-vars': ['error', { args: 'none' }],
'no-unused-vars': ['error', { args: 'none', caughtErrors: 'all' }],
'no-use-before-define': ['error', {
classes: true,
functions: false,
Expand Down
4 changes: 2 additions & 2 deletions lib/stream.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ try {
// readable-stream.
Stream._isUint8Array = process.binding('util').isUint8Array;
}
} catch (e) {
} catch (e) { // eslint-disable-line no-unused-vars
}

if (!Stream._isUint8Array) {
Expand All @@ -74,7 +74,7 @@ if (version[0] === 0 && version[1] < 12) {
chunk.byteOffset,
chunk.byteLength);
};
} catch (e) {
} catch (e) { // eslint-disable-line no-unused-vars
}

if (!Stream._uint8ArrayToBuffer) {
Expand Down

0 comments on commit b3c163f

Please sign in to comment.