Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix strictEqual argument order #24153

Closed
wants to merge 1 commit into from
Closed

test: fix strictEqual argument order #24153

wants to merge 1 commit into from

Conversation

KaskMartin
Copy link
Contributor

Fix the order of assert.strictEqual() arguments.
It should have first argument as the calculated/tested value

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2018
@BridgeAR BridgeAR added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2018
@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18437/

@KaskMartin KaskMartin force-pushed the fix-test-buffer-slice-assert-argument-order branch from e2e7046 to 414c953 Compare November 10, 2018 10:18
@KaskMartin
test: fix strictEqual argument order
ad527cd 
Fix the order of assert.strictEqual() arguments.
It should have first argument as the calculated/tested value.
@KaskMartin KaskMartin force-pushed the fix-test-buffer-slice-assert-argument-order branch from 414c953 to ad527cd Compare November 10, 2018 11:35
@Trott
Copy link
Member

Trott commented Nov 11, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18539/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 11, 2018
@Trott
Copy link
Member

Trott commented Nov 12, 2018

Landed in 8efad19.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 12, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 12, 2018
@KaskMartin @Trott
test: fix strictEqual argument order
8efad19 
Fix the order of assert.strictEqual() arguments.
It should have first argument as the calculated/tested value.

PR-URL: nodejs#24153
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@KaskMartin @BridgeAR
test: fix strictEqual argument order
75e4f7d 
Fix the order of assert.strictEqual() arguments.
It should have first argument as the calculated/tested value.

PR-URL: #24153
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@KaskMartin @kiyomizumia
test: fix strictEqual argument order
19799c5 
Fix the order of assert.strictEqual() arguments.
It should have first argument as the calculated/tested value.

PR-URL: nodejs#24153
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Dec 14, 2018
@KaskMartin @codebytere
test: fix strictEqual argument order
77c2cc9 
Fix the order of assert.strictEqual() arguments.
It should have first argument as the calculated/tested value.

PR-URL: #24153
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@KaskMartin @MylesBorins
test: fix strictEqual argument order
09bb491 
Fix the order of assert.strictEqual() arguments.
It should have first argument as the calculated/tested value.

PR-URL: #24153
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Jan 4, 2019
Merged
@beevelop beevelop mentioned this pull request Jan 29, 2019
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@KaskMartin @gireeshpunathil @Trott @jasnell @cjihrig @BridgeAR @trivikr @nodejs-github-bot