Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: promote v8 name spaces with using #23934

Closed
wants to merge 1 commit into from
Closed

src: promote v8 name spaces with using #23934

wants to merge 1 commit into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Oct 28, 2018 •
edited
Loading

Promote v8 name spaces with using for consistent in util related codebase.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. util Issues and PRs related to the built-in util module. labels Oct 28, 2018
fhinkel
fhinkel requested changes Oct 30, 2018
View reviewed changes
Copy link
Member

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you change the commit message please. I think it should be "for consistency".

@ZYSzys
Copy link
Member Author

ZYSzys commented Oct 30, 2018

@fhinkel Aha, sorry for the commit message typo😅. Fixed now.

@danbev
Copy link
Contributor

danbev commented Oct 31, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18254/

@danbev
Copy link
Contributor

danbev commented Nov 2, 2018

Landed in 9e31a72.

@danbev danbev closed this Nov 2, 2018
danbev pushed a commit that referenced this pull request Nov 2, 2018
@ZYSzys @danbev
src: use v8:: for consistency in util
9e31a72 
PR-URL: #23934
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@ZYSzys ZYSzys deleted the src/util branch November 2, 2018 10:25
targos pushed a commit that referenced this pull request Nov 2, 2018
@ZYSzys @targos
src: use v8:: for consistency in util
38b0525 
PR-URL: #23934
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@ZYSzys ZYSzys mentioned this pull request Nov 5, 2018
Closed
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
@MylesBorins
Copy link
Contributor

MylesBorins commented Nov 27, 2018 •
edited
Loading

This does not land cleanly in v10.x LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

@ZYSzys ZYSzys mentioned this pull request Nov 27, 2018
Closed
2 tasks
@ZYSzys ZYSzys mentioned this pull request Dec 13, 2018
Closed
2 tasks
BethGriggs pushed a commit that referenced this pull request Feb 4, 2019
@ZYSzys @BethGriggs
src: use v8:: for consistency in util
450bcde 
Backport-PR-URL: #25005
PR-URL: #23934
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@ZYSzys @rvagg
src: use v8:: for consistency in util
f9fc1ea 
Backport-PR-URL: #25005
PR-URL: #23934
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.