Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct order of args in assert.strictEqual() #24157

Closed
wants to merge 1 commit into from
Closed

fix: correct order of args in assert.strictEqual() #24157

wants to merge 1 commit into from

Conversation

ncluer
Copy link

@ncluer ncluer commented Nov 6, 2018

Ensure literal values are passed in as second argument

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

fix: correct order of args in assert.strictEqual()
c320af3 
Ensure literal values are passed in as second argument
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2018
@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2018
@trivikr
Copy link
Member

trivikr commented Nov 7, 2018

Hi @ncluer, the author of this commit is not registered on Github (steps defined here)

Either:

  • add the email ID associated with the commit to Github
  • change the author of the commit to current email ID registered with the Github by following these steps

@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18440/

@gireeshpunathil
Copy link
Member

Resume CI: https://ci.nodejs.org/job/node-test-commit/23108/

@Trott
Copy link
Member

Trott commented Nov 11, 2018

Landed in 7c67cfd.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 11, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 11, 2018
@Trott
test: correct order of args in assert.strictEqual()
7c67cfd 
Ensure literal values are passed in as second argument

PR-URL: nodejs#24157
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@trivikr
Copy link
Member

trivikr commented Nov 12, 2018

The author did not get contributor status, as the email ID is not registered with Github #24157 (comment)
@ncluer Can you register the email ID associated with the commit with Github?

BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@BridgeAR
test: correct order of args in assert.strictEqual()
09a8f47 
Ensure literal values are passed in as second argument

PR-URL: #24157
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@kiyomizumia
test: correct order of args in assert.strictEqual()
572535c 
Ensure literal values are passed in as second argument

PR-URL: nodejs#24157
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Dec 14, 2018
@codebytere
test: correct order of args in assert.strictEqual()
7483c5b 
Ensure literal values are passed in as second argument

PR-URL: #24157
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@MylesBorins
test: correct order of args in assert.strictEqual()
704d886 
Ensure literal values are passed in as second argument

PR-URL: #24157
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Jan 4, 2019
Merged
This was referenced Jan 29, 2019
Closed
Closed
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ncluer @trivikr @gireeshpunathil @Trott @jasnell @cjihrig @BridgeAR @addaleax @nodejs-github-bot