Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: check for invalid importModuleDynamically type in vm.js #24161

Closed
wants to merge 1 commit into from
Closed

test: check for invalid importModuleDynamically type in vm.js #24161

wants to merge 1 commit into from

Conversation

alyssaq
Copy link
Contributor

@alyssaq alyssaq commented Nov 6, 2018

Added test for checking the thrown error when the option importModuleDynamically is not a function.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2018
@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2018
@alyssaq alyssaq mentioned this pull request Nov 6, 2018
Closed
2 tasks
@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18524/

gireeshpunathil
gireeshpunathil reviewed Nov 12, 2018
View reviewed changes
test/parallel/test-vm-module-dynamic-import.js Outdated
'import("foo")',
{ importModuleDynamically: false }),
{ code: 'ERR_INVALID_ARG_TYPE' }
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter failed due to missing semicolon here; @alyssaq - can you please make that change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18568/

@gireeshpunathil
Copy link
Member

landed as dde9b3a , thanks!

gireeshpunathil pushed a commit that referenced this pull request Nov 13, 2018
@alyssaq @gireeshpunathil
test: check for invalid module type in vm.js
dde9b3a 
PR-URL: #24161
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@alyssaq @BridgeAR
test: check for invalid module type in vm.js
dd9864b 
PR-URL: #24161
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@alyssaq @kiyomizumia
test: check for invalid module type in vm.js
18981e8 
PR-URL: nodejs#24161
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alyssaq @gireeshpunathil @jasnell @addaleax @BridgeAR @codebytere @nodejs-github-bot