test: add tests for OutgoingMessage setTimeout

[robin-drexler]

These tests ensure that OutgoingMessage setTimeout method
will call setTimeout on its socket

Co-authored-by: ZauberNerd [email protected]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[addaleax]

CI: https://ci.nodejs.org/job/node-test-pull-request/18371/

[robin-drexler]

I think the CI failed due to reasons unrelated to our changes. I'd rebase against current master and see if CI gets green, however I think this would invalidate all existing reviews.

Any hints what to do? :)

[danbev]

Any hints what to do? :)

We can re-run the failing node-test-commit-smartos/ saving us from having to re-run the ones that succeeded.

[robin-drexler]

@danbev I'm afraid I'm not allowed to do it. Can you?

[danbev]

I'm afraid I'm not allowed to do it. Can you?

Yep, sorry about not being clear on this. I restarted the build and you should be able to see the result here:
https://ci.nodejs.org/job/node-test-commit-smartos/21484/

[Trott]

Landed in 730ec83.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

[robin-drexler]

Thanks for merging! :)

The altered commit seems to have removed @ZauberNerd as co-author (although it's still in the commit message).

Do you know if there's any way to get him his github attribution back?

[Trott]

Do you know if there's any way to get him his github attribution back?

I'm guessing that merging the Co-Author: trailer with our metadata will mess up our tooling, so I think it may not be simple to get the attribution back, I'm sorry to say... But I welcome correction from anyone more knowledgable than me on this stuff.