src: move error handling code into node_errors.cc

Move the following code into a new node_errors.cc file and declare them in node_errors.h for clarity and make it possible to include them with node_errors.h. - AppendExceptionLine() - DecorateErrorStack() - FatalError() - OnFatalError() - PrintErrorString() - FatalException() - ReportException() - FatalTryCatch And move the following definitions (declared elsewhere than node_errors.h) to node_errors.cc: - Abort() (in util.h) - Assert() (in util.h) PR-URL: #24058 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
nodejs · Nov 6, 2018 · cb7d9f9 · cb7d9f9
1 parent 6b697d4
commit cb7d9f9
Show file tree

Hide file tree

Showing 12 changed files with 516 additions and 505 deletions.
diff --git a/node.gyp b/node.gyp
@@ -345,6 +345,7 @@
         'src/node_domain.cc',
         'src/node_encoding.cc',
         'src/node_errors.h',
+        'src/node_errors.cc',
         'src/node_file.cc',
         'src/node_http2.cc',
         'src/node_http_parser.cc',

diff --git a/src/async_wrap.cc b/src/async_wrap.cc
@@ -21,9 +21,10 @@
 
 #include "async_wrap-inl.h"
 #include "env-inl.h"
+#include "node_errors.h"
 #include "node_internals.h"
-#include "util-inl.h"
 #include "tracing/traced_value.h"
+#include "util-inl.h"
 
 #include "v8.h"
 #include "v8-profiler.h"

diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc
@@ -1,12 +1,13 @@
 #include "inspector_agent.h"
 
-#include "inspector_io.h"
 #include "inspector/main_thread_interface.h"
 #include "inspector/node_string.h"
 #include "inspector/tracing_agent.h"
 #include "inspector/worker_agent.h"
 #include "inspector/worker_inspector.h"
+#include "inspector_io.h"
 #include "node/inspector/protocol/Protocol.h"
+#include "node_errors.h"
 #include "node_internals.h"
 #include "node_url.h"
 #include "v8-inspector.h"