Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: edit BUILDING.md #24243

Closed
wants to merge 4 commits into from
Closed

doc: edit BUILDING.md #24243

wants to merge 4 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 8, 2018

Minor edits to BUILDING.md to keep sentences short and clear.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Nov 8, 2018
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 8, 2018
@Trott
Copy link
Member Author

Trott commented Nov 8, 2018

Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions

BUILDING.md Outdated Show resolved Hide resolved
BUILDING.md Outdated Show resolved Hide resolved
BUILDING.md Show resolved Hide resolved
BUILDING.md Show resolved Hide resolved
@refack refack removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 8, 2018
Minor edits to BUILDING.md to keep sentences short and clear.
@Trott
Copy link
Member Author

Trott commented Nov 9, 2018

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 10, 2018
@Trott
Copy link
Member Author

Trott commented Nov 10, 2018

Landed in c17fef7.

@Trott Trott closed this Nov 10, 2018
Trott added a commit to Trott/io.js that referenced this pull request Nov 10, 2018
Minor edits to BUILDING.md to keep sentences short and clear.

PR-URL: nodejs#24243
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
Minor edits to BUILDING.md to keep sentences short and clear.

PR-URL: #24243
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
Minor edits to BUILDING.md to keep sentences short and clear.

PR-URL: nodejs#24243
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
codebytere pushed a commit that referenced this pull request Dec 14, 2018
Minor edits to BUILDING.md to keep sentences short and clear.

PR-URL: #24243
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
Minor edits to BUILDING.md to keep sentences short and clear.

PR-URL: #24243
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@codebytere codebytere mentioned this pull request Jan 4, 2019
@Trott Trott deleted the build-edits branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants