Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove unused parameters in function definition #24268

Closed
wants to merge 1 commit into from
Closed

test: remove unused parameters in function definition #24268

wants to merge 1 commit into from

Conversation

prh1
Copy link
Contributor

@prh1 prh1 commented Nov 9, 2018

Remove unused parameters triggerAsyncId and resource from oninit function in test-async-await.js.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

@prh1
test: remove unused parameters in function definition
383e22f 
Remove unused parameters triggerAsyncId and resource from oninit
function in test-async-await.js.
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Nov 9, 2018
@Trott
Copy link
Member

Trott commented Nov 11, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18537/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 12, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 12, 2018
@prh1 @Trott
test: remove unused parameters in function definition
49b0f7f 
Remove unused parameters triggerAsyncId and resource from oninit
function in test-async-await.js.

PR-URL: nodejs#24268
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 12, 2018

Landed in 49b0f7f

@Trott Trott closed this Nov 12, 2018
@Trott
Copy link
Member

Trott commented Nov 12, 2018

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@prh1 @BridgeAR
test: remove unused parameters in function definition
ea5d184 
Remove unused parameters triggerAsyncId and resource from oninit
function in test-async-await.js.

PR-URL: #24268
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@prh1 @kiyomizumia
test: remove unused parameters in function definition
bf6e886 
Remove unused parameters triggerAsyncId and resource from oninit
function in test-async-await.js.

PR-URL: nodejs#24268
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 12, 2019
@prh1 @codebytere
test: remove unused parameters in function definition
d4fd76a 
Remove unused parameters triggerAsyncId and resource from oninit
function in test-async-await.js.

PR-URL: #24268
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
This was referenced Jan 29, 2019
Closed
Closed
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starkwang starkwang starkwang approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@prh1 @Trott @danbev @jasnell @lpinca @cjihrig @tniessen @BridgeAR @starkwang @nodejs-github-bot