Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document http request.finished boolean #24319

Closed
wants to merge 1 commit into from
Closed

doc: document http request.finished boolean #24319

wants to merge 1 commit into from

Conversation

watson
Copy link
Member

@watson watson commented Nov 12, 2018

This boolean have been there from the beginning and have always been set synchronously to true during the call to request.end().

In early versions request.end() was called request.close() (pre v0.1.90) and even earlier request.finish() (pre v0.1.29), but the concept was the same.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@watson build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1585/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Nov 12, 2018
cjihrig
cjihrig approved these changes Nov 12, 2018
View reviewed changes
doc/api/http.md Outdated Show resolved Hide resolved
doc/api/http.md Outdated Show resolved Hide resolved
@mafintosh
Copy link
Member

Great stuff 👍

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 12, 2018
vsemozhetbyt
vsemozhetbyt approved these changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With some nits)

doc/api/http.md Outdated Show resolved Hide resolved
doc/api/http.md Outdated Show resolved Hide resolved
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1594/

@watson
Copy link
Member Author

watson commented Nov 14, 2018

Should this be backported as well?

@vsemozhetbyt
Copy link
Contributor

Landed in fab97ee

vsemozhetbyt pushed a commit that referenced this pull request Nov 14, 2018
@watson @vsemozhetbyt
doc: document http request.finished boolean
fab97ee 
PR-URL: #24319
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@watson @BridgeAR
doc: document http request.finished boolean
f46a787 
PR-URL: #24319
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
BridgeAR pushed a commit that referenced this pull request Nov 15, 2018
@watson @BridgeAR
doc: document http request.finished boolean
a01e829 
PR-URL: #24319
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Nov 15, 2018
Merged
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
@beevelop beevelop mentioned this pull request Nov 16, 2018
Closed
@watson watson deleted the http-docs branch November 16, 2018 14:46
codebytere pushed a commit that referenced this pull request Jan 12, 2019
@watson @codebytere
doc: document http request.finished boolean
e111d71 
PR-URL: #24319
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@mafintosh mafintosh mafintosh approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@watson @nodejs-github-bot @mafintosh @vsemozhetbyt @fhinkel @lpinca @cjihrig @BridgeAR @trivikr