Fixed a11y issue in add a failure instance panel. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waabid
previously approved these changes
Jan 25, 2019
waabid
approved these changes
Jan 25, 2019
dbjorge
pushed a commit
that referenced
this pull request
Nov 21, 2019
#### Description of changes
One of the most common timeout issue in our e2e was in settings-panel & high-contrast e2e tests where the `keyPress('escape')` was not getting registered properly and so I changed that event with pressing the cross button on the settings panel to exit it. This should hopefully fix that timeout error on settings panel tests.
Also added `--no-cache` to `yarn:dev` in our docker to avoid a dev build cache system which I was hitting regularly in my local build.
<!--
A great PR description includes:
* A high level overview (usually a sentence or two) describing what the PR changes
* What is the motivation for the change? This can be as simple as "addresses issue #123"
* Were there any alternative approaches you considered? What tradeoffs did you consider?
* What **doesn't** the change try to do? Are there any parts that you've intentionally left out-of-scope for a later PR to handle? What are the issues/work items tracking that later work?
* Is there any other context that reviewers should consider? For example, other related issues/PRs, or any particularly tricky/subtle bits of implementation that need closer-than-normal review?
-->
#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox -->
- [ ] Addresses an existing issue: #0000
- [ ] Ran `yarn fastpass`
- [ ] Added/updated relevant unit test(s) (and ran `yarn test`)
- [ ] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage`
- [ ] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). Check workflow guide at: `<rootDir>/docs/workflow.md`
- [ ] (UI changes only) Added screenshots/GIFs to description above
- [ ] (UI changes only) Verified usability with NVDA/JAWS
dbjorge
pushed a commit
that referenced
this pull request
Apr 14, 2020
…ssessment guidance (#2480) #### Description of changes Remove the `WCAG 1.3.1` link from headings guidance. <!-- A great PR description includes: * A high level overview (usually a sentence or two) describing what the PR changes * What is the motivation for the change? This can be as simple as "addresses issue #123" * Were there any alternative approaches you considered? What tradeoffs did you consider? * What **doesn't** the change try to do? Are there any parts that you've intentionally left out-of-scope for a later PR to handle? What are the issues/work items tracking that later work? * Is there any other context that reviewers should consider? For example, other related issues/PRs, or any particularly tricky/subtle bits of implementation that need closer-than-normal review? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: #2444 - [x] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [x] (UI changes only) Added screenshots/GIFs to description above - [ ] (UI changes only) Verified usability with NVDA/JAWS #### Screenshot <img width="567" alt="Screen Shot 2020-04-12 at 3 17 05 PM" src="https://user-images.githubusercontent.com/4496335/79081322-3789ac80-7cd1-11ea-9774-25888a65161a.png">
dbjorge
pushed a commit
that referenced
this pull request
Apr 14, 2020
#### Description of changes These changes add the option to export reports to CodePen in addition to an HTML file. There is a [relevant open issue](#1739) detailing a need for this type of functionality. I wasn't quite sure what the design should look like for this so I've went ahead and used a split `PrimaryButton` from `office-ui-fabric-react` in the `ExportDialog ` component but I'm definitely open to alternative approaches!  I was also considering splitting out the HTML and CSS before sending the payload to CodePen but I figured I'd get some feedback on the changes within this PR before moving forward with more in-depth functionality. <!-- A great PR description includes: * A high level overview (usually a sentence or two) describing what the PR changes * What is the motivation for the change? This can be as simple as "addresses issue #123" * Were there any alternative approaches you considered? What tradeoffs did you consider? * What **doesn't** the change try to do? Are there any parts that you've intentionally left out-of-scope for a later PR to handle? What are the issues/work items tracking that later work? * Is there any other context that reviewers should consider? For example, other related issues/PRs, or any particularly tricky/subtle bits of implementation that need closer-than-normal review? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: #1739 - [x] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). Check workflow guide at: `<rootDir>/docs/workflow.md` - [x] (UI changes only) Added screenshots/GIFs to description above - [x] (UI changes only) Verified usability with NVDA/JAWS
jalkire
pushed a commit
that referenced
this pull request
May 19, 2021
…ils button from an insecure target page (#4234) #### Details This PR is a continuation of PR #4170 and addresses the bug described in #4211. Previously, from an insecure target page, if a user clicks the "Copy failure details" button then two messages will render: 1. help message under the button that reads "To copy failure details, first open the Accessibility Insights for Web page." 2. toast pop-up reading "Failed to copy failure details." Now, this PR removes the aforementioned toast pop-up. Example screenshot is shown below.  <!-- Usually a sentence or two describing what the PR changes --> ##### Motivation Addresses bug #4211 <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: #4211 - [x] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [x] (UI changes only) Added screenshots/GIFs to description above - [x] (UI changes only) Verified usability with NVDA/JAWS
ZakiyaN0
added a commit
that referenced
this pull request
Aug 29, 2022
#### Details <!-- Usually a sentence or two describing what the PR changes --> This PR removes the feature flag under which development of the accessible names feature took place. Although the main goal of this PR is to remove the feature flag, it also contains very small changes related to the "display-accessible-names" rule; with respect to that, this PR adds another native element attribute (summary, to be specific,) check for elements that get their names from author-provided attributes. The PR also includes the addition of the "section" element to the selectors we query. ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context The "summary" attribute check was added to this PR because some elements like table can get their accessible name from the summary attribute. For more information, please refer to PR #5960 <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [ ] Addresses an existing issue: #0000 - [x] Ran `yarn null:autoadd` - [x] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [x] (UI changes only) Added screenshots/GIFs to description above - [ ] (UI changes only) Verified usability with NVDA/JAWS 
ZakiyaN0
added a commit
that referenced
this pull request
Aug 30, 2022
…t for Accessible names (#5973) #### Details This PR allows the user to add a custom shortcut for the accessible names toggle. <!-- Usually a sentence or two describing what the PR changes --> ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: #0000 - [x] Ran `yarn null:autoadd` - [x] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [x] (UI changes only) Added screenshots/GIFs to description above - [ ] (UI changes only) Verified usability with NVDA/JAWS  
ferBonnin
pushed a commit
that referenced
this pull request
Oct 27, 2022
#### Details <!-- Usually a sentence or two describing what the PR changes --> chore: rephrase parsing instructions in assessments as suggested under #6130 (comment) > Suggestion: maybe "Go to the browser tab containing your target page and, in that browser window, select the first bookmarklet"? ##### Motivation <!-- This can be as simple as "addresses issue #123" --> closes #6130 ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> Instructions shown to user during **Parsing Assessments** <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> currently; https://github.com/microsoft/accessibility-insights-web/blob/7ef8ee7aa066968ef0085ab2a72d5505a397a83c/src/assessments/parsing/test-steps/parsing.tsx#L52-L56 #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: #6130 - [-] Ran `yarn null:autoadd` - [-] Ran `yarn fastpass` - [-] Added/updated relevant unit test(s) (and ran `yarn test`) - [-] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [-] (UI changes only) Added screenshots/GIFs to description above - [-] (UI changes only) Verified usability with NVDA/JAWS
ferBonnin
pushed a commit
that referenced
this pull request
Oct 31, 2022
- [x] point to correct ARIA APG links - [x] fix various broken links w/ (typos) - [x] fix unit tests for the same :) #### Details #6116 (comment) > This is the [landing page link](https://www.w3.org/WAI/ARIA/apg/patterns), we would need to point to the right subpage for each pattern. For example for combobox the current link is: https://www.w3.org/TR/wai-aria-practices-1.1/#combobox the new link should be: https://www.w3.org/WAI/ARIA/apg/patterns/combobox/ <!-- Usually a sentence or two describing what the PR changes --> ##### Motivation <!-- This can be as simple as "addresses issue #123" --> closes #6116 ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: #6116 - [-] Ran `yarn null:autoadd` - [-] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [-] (UI changes only) Added screenshots/GIFs to description above - [-] (UI changes only) Verified usability with NVDA/JAWS
dbjorge
added a commit
that referenced
this pull request
Nov 22, 2022
#### Details <!-- Usually a sentence or two describing what the PR changes --> ##### Motivation <!-- This can be as simple as "addresses issue #123" --> close #5610 ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> > Design team suggested trying multiple border colors with red in the center and white surrounding this. I implemented this based on one of the design team's suggestions listed in the issue. This will make failure highlight more visible, especially for a dark background as in the following picture. However, for pages with white or other background colors, it is not very effective. ##### screenshots/GIFs to description above Dark Background | Before | After | | ----- | ----- | |<img width="1267" alt="スクリーンショット 2022-11-03 20 00 00" src="https://user-images.githubusercontent.com/49313042/199704496-45e60ebe-4818-46a2-9203-c5d0364fd1f2.png">|<img width="1245" alt="スクリーンショット 2022-11-03 19 58 34" src="https://user-images.githubusercontent.com/49313042/199704535-48475702-dd3a-4b62-83ce-750d17137731.png">| White Background | Before | After | | ----- | ----- | |<img width="1015" alt="スクリーンショット 2022-11-03 20 14 26" src="https://user-images.githubusercontent.com/49313042/199707053-d05a56dc-be96-4a81-9fb8-c8e7ab1cc3d4.png">|<img width="1141" alt="スクリーンショット 2022-11-03 20 11 11" src="https://user-images.githubusercontent.com/49313042/199706541-03591b81-7287-4dd1-86c5-d437a87bc5fd.png">| #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: #5610 - [x] Ran `yarn null:autoadd` - [x] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [x] (UI changes only) Added screenshots/GIFs to description above - [x] (UI changes only) Verified usability with NVDA/JAWS --- I've pushed an update that swaps to the box-shadow + outline version. It updates all the box drawers and their labels. It pushes the determination of box width to CSS to reduce the amount of per-element overhead in `style` attributes. It touches a bunch of files to change some `DrawerConfiguration` types from using `borderColor` to `outlineColor`. I also made some related refactorings while patching up the tests: * The `HighlightBoxDrawer` previously allowed for no formatter to be passed and contained a "default drawer configuration" for that case. This was never used except for tests; I've removed it and updated `drawer.test.ts` accordingly * Removed an obsolete `LandmarkValue` type (not used anywhere and referenced `borderColor`) I also fixed up some issues specific to the landmark visualizer; per discussion with @ferBonnin, I included the same white border there but reduced the width of the dashed part from 3px to 2px. I also fixed an issue I noticed with high-contrast-mode rendering of the landmark visualizer's dashed highlight boxes (previously, we used HC colors for the outer box, but not the text label box; this fixes it to be consistent). For reviewers, I recommend including the Deque Mars test page among your smoke tests; it has a lot of failures against non-white backgrounds that are good test cases. Screenshots of new behavior:    Tab stops is not changed by this update and would need to be addressed in a separate PR:  In Windows HC mode:   Co-authored-by: Dan Bjorge <[email protected]>
waabid
pushed a commit
that referenced
this pull request
Dec 2, 2022
…6227) #### Details <!-- Usually a sentence or two describing what the PR changes --> This PR ensures that the MediumPass/QuickAssess equivalents of Assessment callbacks are registered in ActionCreator ##### Motivation <!-- This can be as simple as "addresses issue #123" --> Part of feature work ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue: #0000 - [x] Ran `yarn null:autoadd` - [x] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [n/a] (UI changes only) Added screenshots/GIFs to description above - [n/a] (UI changes only) Verified usability with NVDA/JAWS
DaveTryon
added a commit
that referenced
this pull request
Sep 22, 2023
#### Details Due to jestjs/jest#14305, our inline snapshots are causing problems when using `yarn test -u`. We discussed this internally and decided that the simplest approach was to convert the inline snapshots to traditional snapshots. For most cases, this was just removing "Inline" from the method name and removing the string that provided the snapshot. A small number of test cases were checking multiple inline snapshots in the same test, so the approach there was to build an array of the things that were previously checked individually, then having a single snapshot for the test case. I ran `yarn test -u` and `yarn format:fix` after making all of the changes, just to make sure that we're ready for future changes. It will probably be easiest to review this one commit at a time--each of the 32 commits represents the conversion of a single test case. ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue - [x] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [n/a] (UI changes only) Added screenshots/GIFs to description above - [n/a] (UI changes only) Verified usability with NVDA/JAWS
JGibson2019
added a commit
that referenced
this pull request
Dec 12, 2023
#### Details This is to validate the release secret update <!-- Usually a sentence or two describing what the PR changes --> ##### Motivation Quarterly rotation; standard <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [ ] Addresses an existing issue: #0000 - [ ] Ran `yarn fastpass` - [ ] Added/updated relevant unit test(s) (and ran `yarn test`) - [ ] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [ ] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [ ] (UI changes only) Added screenshots/GIFs to description above - [ ] (UI changes only) Verified usability with NVDA/JAWS
v-singhanjal
added a commit
that referenced
this pull request
Jan 30, 2024
…7207) #### Details <!-- Usually a sentence or two describing what the PR changes --> Enzyme replacement in files under src/tests/unit/tests/DetailsView/components ##### Motivation <!-- This can be as simple as "addresses issue #123" --> Existing story: [User Story 2136480](https://dev.azure.com/mseng/1ES/_workitems/edit/2136480) Replaced the use of Enzyme in the below files: 1. react-extension-point.test.tsx 2. named-fc.test.tsx 3. index.test.tsx 4. current-view.test.tsx 5. telemetry-common-fields.test.tsx 6. telemetry-messages-list.test.tsx 7. telemetry-viewer.test.tsx 8. debug-tools-nav.test.tsx 9. debug-tools-view.test.tsx 10. stores-tree.test.tsx 11. preview-features-container.test.tsx 12. scoping-container.test.tsx 13. auto-detected-failures-dialog-settings.test.tsx 14. high-contrast/high-contrast-settings.test.tsx 15. issue-filing-settings.test.tsx 16. save-assessment-dialog.test.tsx 17. telemetry-settings.test.tsx 18. settings-panel.test.tsx 19. assessment-left-nav.test.tsx 20. details-view-left-nav.test.tsx Code coverage before and after codeshift checked and it is same. ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: [2136480](https://dev.azure.com/mseng/1ES/_workitems/edit/2136480) - [x] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [n/a] (UI changes only) Added screenshots/GIFs to description above - [n/a ] (UI changes only) Verified usability with NVDA/JAWS
v-viyada
pushed a commit
that referenced
this pull request
Feb 13, 2024
…7210) #### Details - Enzyme replacement done for total 20 files. <!-- Usually a sentence or two describing what the PR changes --> File names are mentioned below- src/tests/unit/tests/DetailsView/components/nav-link-button.test.tsx src/tests/unit/tests/DetailsView/components/next-requirement-button.test.tsx src/tests/unit/tests/DetailsView/components/no-displayable-preview-features-message.test.tsx src/tests/unit/tests/DetailsView/components/preview-features-toggle-list.test.tsx src/tests/unit/tests/DetailsView/components/quick-assess-command-bar.test.tsx src/tests/unit/tests/DetailsView/components/quick-assess-to-assessment-dialog.test.tsx src/tests/unit/tests/DetailsView/components/report-export-button.test.tsx src/tests/unit/tests/DetailsView/components/report-export-component.test.tsx src/tests/unit/tests/DetailsView/components/requirement-context-section-factory.test.tsx src/tests/unit/tests/DetailsView/components/requirement-context-section.test.tsx src/tests/unit/tests/DetailsView/components/requirement-instructions.test.tsx src/tests/unit/tests/DetailsView/components/requirement-view-title-factory.test.tsx src/tests/unit/tests/DetailsView/components/requirement-view.test.tsx src/tests/unit/tests/DetailsView/components/restart-scan-visual-helper-toggle.test.tsx src/tests/unit/tests/DetailsView/components/save-assessment-button.test.tsx src/tests/unit/tests/DetailsView/components/scan-incomplete-warning.test.tsx src/tests/unit/tests/DetailsView/components/start-over-component-factory.test.tsx src/tests/unit/tests/DetailsView/components/start-over-dialog.test.tsx src/tests/unit/tests/DetailsView/components/start-over-dropdown.test.tsx src/tests/unit/tests/DetailsView/components/static-content-details-view.test.tsx ##### Motivation enzyme replacement in files under **src/tests/unit/tests/DetailsView/components** <!-- This can be as simple as "addresses issue #123" --> **Associated User Story** - https://dev.azure.com/mseng/1ES/_workitems/edit/2136485 ##### Context - All changes are done in test files only and snapshots are updated. <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a ] Addresses an existing issue: #0000 - [x] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [ n/a ] (UI changes only) Added screenshots/GIFs to description above - [ n/a ] (UI changes only) Verified usability with NVDA/JAWS
v-viyada
pushed a commit
that referenced
this pull request
Feb 27, 2024
…7236) #### Details Enzyme Replacement done for total - 20 files as below - src/tests/unit/tests/reports/components/outcome-chip.test.tsx src/tests/unit/tests/reports/components/outcome-icon-set.test.tsx src/tests/unit/tests/reports/components/outcome-icon.test.tsx src/tests/unit/tests/reports/components/outcome-summary-bar.test.tsx src/tests/unit/tests/reports/components/report-head.test.tsx src/tests/unit/tests/reports/components/report-instance-list.test.tsx src/tests/unit/tests/reports/components/summary-report-head.test.tsx src/tests/unit/tests/reports/package/footer-text-for-service.test.tsx src/tests/unit/tests/views/content/markup/code-example.test.tsx src/tests/unit/tests/views/content/content-include.test.tsx src/tests/unit/tests/views/content/content-link.test.tsx src/tests/unit/tests/views/content/content-page.test.tsx src/tests/unit/tests/views/content/content-panel-button.test.tsx src/tests/unit/tests/views/content/content-panel.test.tsx src/tests/unit/tests/views/content/content-view.test.tsx src/tests/unit/tests/views/content/content.test.tsx src/tests/unit/tests/views/content/guidance-title.test.tsx src/tests/unit/tests/views/content/markup.test.tsx src/tests/unit/tests/views/insights/insights-router.test.tsx src/tests/unit/tests/views/page/page.test.tsx Associated User Story - [User Story 2142863](https://dev.azure.com/mseng/1ES/_workitems/edit/2142863) ##### Motivation Enzyme Replacement for total - 20 files . <!-- This can be as simple as "addresses issue #123" --> ##### Context All changes are done in test files only and snapshots are updated. <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue: #0000 - [n/a] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [n/a] (UI changes only) Added screenshots/GIFs to description above - [n/a] (UI changes only) Verified usability with NVDA/JAWS
v-singhanjal
added a commit
that referenced
this pull request
Mar 5, 2024
…7232) #### Details Enzyme replacement in files under src/tests/unit/tests/DetailsView/ <!-- Usually a sentence or two describing what the PR changes --> ##### Motivation Existing story: [User Story 2142857](https://dev.azure.com/mseng/1ES/_workitems/edit/2142857) Replaced the use of Enzyme in the below files: 1. src/tests/unit/tests/DetailsView/components/status-icon.test.tsx 2. src/tests/unit/tests/DetailsView/components/switcher.test.tsx 3. src/tests/unit/tests/DetailsView/components/tab-stops-failed-instance-section.test.tsx 4. src/tests/unit/tests/DetailsView/components/tab-stops-minimal-requirement-header.test.tsx 5. src/tests/unit/tests/DetailsView/components/tab-stops-requirement-instances-collapsible-content.test.tsx 6. src/tests/unit/tests/DetailsView/components/tab-stops-requirements-with-instances.test.tsx 7. src/tests/unit/tests/DetailsView/components/target-change-dialog.test.tsx 8. src/tests/unit/tests/DetailsView/components/target-page-changed-view.test.tsx 9. src/tests/unit/tests/DetailsView/components/target-page-hidden-bar.test.tsx 10. src/tests/unit/tests/DetailsView/components/test-status-choice-group.test.tsx 11. src/tests/unit/tests/DetailsView/components/test-view-container.test.tsx 12. src/tests/unit/tests/DetailsView/components/transfer-to-assessment-button.test.tsx 13. src/tests/unit/tests/DetailsView/details-view-body.test.tsx 14. src/tests/unit/tests/DetailsView/details-view-container.test.tsx 15. src/tests/unit/tests/DetailsView/details-view-content.test.tsx <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: [User Story 2142857](https://dev.azure.com/mseng/1ES/_workitems/edit/2142857) - [x] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [n/a] (UI changes only) Added screenshots/GIFs to description above - [n/a] (UI changes only) Verified usability with NVDA/JAWS --------- Co-authored-by: Prachi Naigaonkar <[email protected]>
SaanicaG
added a commit
that referenced
this pull request
Mar 7, 2024
#### Details
As part of Typescript migration added/removed the error causing fields.
1. src/DetailsView/components/details-view-content.tsx
- For the above file we were getting errors on getOverviewHeadingIntro,
linkDataSource, getOverviewHelpSectionAbout these properties.
- These properties are referred in details-view-switcher-nav.ts,
overview-content-container.tsx.
- Hence, we are not removing these properties, and added it in
details-view-body.tsx.
2.
src/DetailsView/components/details-view-overlay/scoping-panel/scoping-panel.tsx
- We were getting error on deps={this.props.deps}.
- In details-view-overlay.tsx class ScopingPanel is used.
- Hence, we are not removing these properties and added it in
scoping-container.tsx
3. Details-view-switcher-nav.ts
- Got error on shouldShowQuickAssessRequirementView: true,
- Couldn’t find any reference to the above property in any of the files.
- Tested it after removing the property. There are no errors and also on
UI level couldnt find any issues.
-Hence, it seems like it is safe to remove it.
##### Motivation
TypeScript 5.0 has marked some options as deprecated. We can temporarily
override these deprecations, but the documented plan is for the ability
to override the flag to go away in TypeScript 5.5
<!-- This can be as simple as "addresses issue #123" -->
Associated User story - [User Story
2151430](https://dev.azure.com/mseng/1ES/_workitems/edit/2151430)
##### Context
<!-- Are there any parts that you've intentionally left out-of-scope for
a later PR to handle? -->
<!-- Were there any alternative approaches you considered? What
tradeoffs did you consider? -->
#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [x] Addresses an existing issue:
#(#6611)
- [ ] Ran `yarn fastpass`
- [ ] Added/updated relevant unit test(s) (and ran `yarn test`)
- [ ] Verified code coverage for the changes made. Check coverage report
at: `<rootDir>/test-results/unit/coverage`
- [ ] PR title *AND* final merge commit title both start with a semantic
tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See
`CONTRIBUTING.md`.
- [ ] (UI changes only) Added screenshots/GIFs to description above
- [ ] (UI changes only) Verified usability with NVDA/JAWS
v-viyada
added a commit
that referenced
this pull request
Mar 12, 2024
#### Details Unit test case for details-view-command-bar.test is failing due to mismatched dates between saved snapshot and rendered object. Rendered object always takes the current date. Mocked the date in the test case to return specific date instead of current date. ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue: #0000 - [x] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [n/a] (UI changes only) Added screenshots/GIFs to description above - [n/a] (UI changes only) Verified usability with NVDA/JAWS
v-viyada
added a commit
that referenced
this pull request
Mar 20, 2024
#### Details 1ES PT adds tags to pipeline runs using the access token provided by ADO. In the case of pipeline runs against forked repos of a GitHub repo, the access token does not have Edit build quality permissions and hence cannot add tags. To unblock those pipelines, skipped tagging by using the option SkipBuildTagsForGitHubPullRequests. This is similar change which we did earlier for other pipelines like microsoft/accessibility-insights-docs#1921 Verified that the only change in the pipeline run is that it do not add "1ES.PT.Unofficial" tag on the Run. In place of that it adds below warning message. ##[warning]1ES PT Warning: Skipping build tags as this build is a pull request form GitHub which does not have permissions to add tags. ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [ ] Addresses an existing issue: #0000 - [ ] Ran `yarn fastpass` - [ ] Added/updated relevant unit test(s) (and ran `yarn test`) - [ ] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [ ] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [ ] (UI changes only) Added screenshots/GIFs to description above - [ ] (UI changes only) Verified usability with NVDA/JAWS
v-viyada
added a commit
that referenced
this pull request
Apr 25, 2024
… github PR workflow (#7318) CI pipeline is failing frequently with transient timeout issues in e2e testing. GitHub PR workflow does not fail for the same step. So updating Linux image to ubuntu 20.04 in CI to match image version in GitHub PR workflow. #### Details <!-- Usually a sentence or two describing what the PR changes --> ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [ ] Addresses an existing issue: #0000 - [x] Ran `yarn fastpass` - [ ] Added/updated relevant unit test(s) (and ran `yarn test`) - [ ] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [ ] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [ ] (UI changes only) Added screenshots/GIFs to description above - [ ] (UI changes only) Verified usability with NVDA/JAWS
v-viyada
added a commit
that referenced
this pull request
Apr 26, 2024
#### Details Update package version for accessibility insights report for axe-core release. Please refer #7274 ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue: #0000 - [x] Ran `yarn fastpass` - [n/a] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [n/a] (UI changes only) Added screenshots/GIFs to description above - [n/a] (UI changes only) Verified usability with NVDA/JAWS
v-viyada
pushed a commit
that referenced
this pull request
Jun 19, 2024
…accessibility insights ui (#7370) #### Details Update package version for accessibility insights report and accessibility insights ui for React 18 upgrade. Please refer #7336 Note : Making as major version update. On local testing we found that it will bring a breaking change as application consuming these packages also needs to update react and react-dom to v18 to avoid type mismatch. ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [na] Addresses an existing issue: #0000 - [x] Ran `yarn fastpass` - [na] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [na] (UI changes only) Added screenshots/GIFs to description above - [na] (UI changes only) Verified usability with NVDA/JAWS
v-viyada
pushed a commit
that referenced
this pull request
Jun 20, 2024
![https://user-images.githubusercontent.com/49313042/199704496-45e60ebe-4818-46a2-9203-c5d0364fd1f2.png">|<img](https://user-images.githubusercontent.com/49313042/199704496-45e60ebe-4818-46a2-9203-c5d0364fd1f2.png">|<img){kind=link}
![https://user-images.githubusercontent.com/49313042/199704535-48475702-dd3a-4b62-83ce-750d17137731.png">|](https://user-images.githubusercontent.com/49313042/199704535-48475702-dd3a-4b62-83ce-750d17137731.png">|){kind=link}
![https://user-images.githubusercontent.com/49313042/199707053-d05a56dc-be96-4a81-9fb8-c8e7ab1cc3d4.png">|<img](https://user-images.githubusercontent.com/49313042/199707053-d05a56dc-be96-4a81-9fb8-c8e7ab1cc3d4.png">|<img){kind=link}
![https://user-images.githubusercontent.com/49313042/199706541-03591b81-7287-4dd1-86c5-d437a87bc5fd.png">|](https://user-images.githubusercontent.com/49313042/199706541-03591b81-7287-4dd1-86c5-d437a87bc5fd.png">|){kind=link}
#### Details Merge latest main into fluent ui v9 branch ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [ ] Addresses an existing issue: #0000 - [ ] Ran `yarn fastpass` - [ ] Added/updated relevant unit test(s) (and ran `yarn test`) - [ ] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [ ] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [ ] (UI changes only) Added screenshots/GIFs to description above - [ ] (UI changes only) Verified usability with NVDA/JAWS --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anjali Singh <[email protected]> Co-authored-by: Jeevani Chinthala <[email protected]> Co-authored-by: JeevaniChinthala <[email protected]> Co-authored-by: v-sharmachir <[email protected]> Co-authored-by: Chirag Sharma <[email protected]> Co-authored-by: Saanica Ghate <[email protected]> Co-authored-by: Saanica Ghate <[email protected]>
v-rakeshsh
added a commit
that referenced
this pull request
Aug 9, 2024
#### Details <!-- Usually a sentence or two describing what the PR changes --> ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [ ] Addresses an existing issue: #0000 - [ ] Ran `yarn fastpass` - [ ] Added/updated relevant unit test(s) (and ran `yarn test`) - [ ] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [ ] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [ ] (UI changes only) Added screenshots/GIFs to description above - [ ] (UI changes only) Verified usability with NVDA/JAWS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added aira-label to fix a11y issue in add a failure instance panel.
id:1423768