Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enzyme replacement in test files- PR 5 of 6 for part 3 of 3 #7236

Merged
merged 36 commits into from
Feb 27, 2024

Conversation

SaanicaG
Copy link
Contributor

@SaanicaG SaanicaG commented Feb 7, 2024

Details

Enzyme Replacement done for total - 20 files as below -

src/tests/unit/tests/reports/components/outcome-chip.test.tsx
src/tests/unit/tests/reports/components/outcome-icon-set.test.tsx
src/tests/unit/tests/reports/components/outcome-icon.test.tsx
src/tests/unit/tests/reports/components/outcome-summary-bar.test.tsx
src/tests/unit/tests/reports/components/report-head.test.tsx
src/tests/unit/tests/reports/components/report-instance-list.test.tsx
src/tests/unit/tests/reports/components/summary-report-head.test.tsx
src/tests/unit/tests/reports/package/footer-text-for-service.test.tsx
src/tests/unit/tests/views/content/markup/code-example.test.tsx
src/tests/unit/tests/views/content/content-include.test.tsx
src/tests/unit/tests/views/content/content-link.test.tsx
src/tests/unit/tests/views/content/content-page.test.tsx
src/tests/unit/tests/views/content/content-panel-button.test.tsx
src/tests/unit/tests/views/content/content-panel.test.tsx
src/tests/unit/tests/views/content/content-view.test.tsx
src/tests/unit/tests/views/content/content.test.tsx
src/tests/unit/tests/views/content/guidance-title.test.tsx
src/tests/unit/tests/views/content/markup.test.tsx
src/tests/unit/tests/views/insights/insights-router.test.tsx
src/tests/unit/tests/views/page/page.test.tsx

Associated User Story - User Story 2142863

Motivation

Enzyme Replacement for total - 20 files .

Context

All changes are done in test files only and snapshots are updated.

Pull request checklist

  • [n/a] Addresses an existing issue: #0000
  • [n/a] Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

Sorry, something went wrong.

@SaanicaG SaanicaG changed the title V sghate/enzyme replacement part3 chore: Enzyme replacement in test files- PR 5 of 6 for part 3 of 3 Feb 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f54c31a) 94.31% compared to head (fee78dd) 94.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7236   +/-   ##
=======================================
  Coverage   94.31%   94.31%           
=======================================
  Files        1224     1224           
  Lines       20696    20696           
  Branches     1308     1308           
=======================================
  Hits        19520    19520           
  Misses       1157     1157           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SaanicaG SaanicaG marked this pull request as ready for review February 13, 2024 13:33
@SaanicaG SaanicaG requested a review from a team as a code owner February 13, 2024 13:33
Copy link
Contributor

@madalynrose madalynrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge chunk of work! A few small adjustments and then this looks good to go!

@v-viyada v-viyada merged commit d792f85 into microsoft:main Feb 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants