feat(axe-core 4.8): Axe core version upgrade for Web #7274
Conversation
This reverts commit be808a4.
v-viyada
force-pushed
the
v-sghate/AxeVersionUpgradeForWeb
branch
from
92d6f0b to
ee00852
Compare
v-rakeshsh
force-pushed
the
v-sghate/AxeVersionUpgradeForWeb
branch
from
4a6d569 to
eceb58c
Compare
| interface Dom { | ||
| isVisible: Function; | ||
| idrefs: (node: HTMLElement, attr: string) => HTMLElement[]; | ||
| } | ||
| interface Aria { | ||
| label: Function; | ||
| implicitRole: Function; | ||
| getRolesByType: Function; | ||
| lookupTable: any; | ||
| } | ||
|
|
||
| interface Text { | ||
| accessibleText: Function; | ||
| isHumanInterpretable: Function; | ||
| sanitize: Function; | ||
| subtreeText: Function; | ||
| } |
There was a problem hiding this comment.
What impact do these changes have? Was there some kind of error without the interfaces? It seems odd to me that the calls that use these functions didn't need to be updated but I'm not that familiar with setting up a .d.ts file for a library like we've done here.
There was a problem hiding this comment.
Hi @madalynrose
Yes correct, we will get errors.
Because for 4.7.2 the above properties were part of axe-extension.d.ts, because in 4.7.2 package these properties were not there. So its added in the code repo.
But in 4.8.4, these properties are added in package, but not fully like few properties are not added fully which is used by our code. So those missing properties are added above.
Please let me know if need further information.
Thanks
| @@ -16,9 +16,18 @@ exports[`getRuleInclusions getRuleInclusions matches snapshotted list of product | |||
| "reason": "best practice rule that was investigated with no known false positives, implemented as an automated check.", | |||
| "status": "included", | |||
| }, | |||
| "aria-braille-equivalent": { | |||
There was a problem hiding this comment.
Enabling new rules usually includes adding documentation to info-examples. Have we done that for these?
There was a problem hiding this comment.
PM team is working on the documentation for these. We will release both Web extension and docs in sync. @nang4ally to add more details if required.
v-viyada
changed the title
#### Details Update package version for accessibility insights report for axe-core release. Please refer #7274 ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue: #0000 - [x] Ran `yarn fastpass` - [n/a] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [n/a] (UI changes only) Added screenshots/GIFs to description above - [n/a] (UI changes only) Verified usability with NVDA/JAWS
Details
This PR updates axe-core to its latest version, 4.8.4, from 4.7.2. It also bumps the accessibility-insights-report package version. As part of the axe-core update:
checks: enable help-same-as-label, but remove from rules (feat(checks): enable help-same-as-label, but remove from rules dequelabs/axe-core#4096)
Various improvements were made to the types. Potentially the most impactful of which is that the target and ancestry property now return as UnlabelledFrameSelector instead of as string[],
Major version upgrade 4.8.0 details https://github.com/dequelabs/axe-core/releases/tag/v4.8.0
Motivation
This change is part of https://dev.azure.com/mseng/1ES/_workitems/edit/2157659/
Context
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.