Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate & disable duplicate-id / duplicate-id-active #4071

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

WilcoFiers
Copy link
Contributor

Disable, remove, and update tags for duplicate-id and duplicate-id-active.

Closes: #3892

@WilcoFiers WilcoFiers requested a review from a team as a code owner June 28, 2023 13:59
@dylanb
Copy link
Contributor

dylanb commented Jun 28, 2023

Don't we also need to disable these by default?

@dylanb
Copy link
Contributor

dylanb commented Jun 28, 2023

Don't we also need to disable these by default?

They are disabled by default

@WilcoFiers WilcoFiers merged commit 733c45e into develop Jun 29, 2023
@WilcoFiers WilcoFiers deleted the duplicate-id-deprecated branch June 29, 2023 10:21
@adamraine

This comment was marked as outdated.

v-viyada added a commit to microsoft/accessibility-insights-web that referenced this pull request Apr 25, 2024
#### Details
This PR updates axe-core to its latest version,
[4.8.4](https://github.com/dequelabs/axe-core/releases/v4.8.4), from
[4.7.2](https://github.com/dequelabs/axe-core/releases/v4.7.2). It also
bumps the accessibility-insights-report package version. As part of the
axe-core update:

- The deprecate & disable duplicate-id / duplicate-id-active rule has
been deprecated (dequelabs/axe-core#4071).
- moved duplicate-id-aria to needs review.
(dequelabs/axe-core#4075)
<img width="922" alt="image"
src="https://github.com/microsoft/accessibility-insights-web/assets/95463767/152c51ce-16d9-4550-aee2-6ddd8155a722">


- checks: enable help-same-as-label, but remove from rules
(dequelabs/axe-core#4096)

- Various improvements were made to the types. Potentially the most
impactful of which is that the target and ancestry property now return
as UnlabelledFrameSelector instead of as string[],

- Major version upgrade 4.8.0 details
https://github.com/dequelabs/axe-core/releases/tag/v4.8.0

<!-- Usually a sentence or two describing what the PR changes -->

##### Motivation

This change is part of
https://dev.azure.com/mseng/1ES/_workitems/edit/2157659/

##### Context

<!-- Are there any parts that you've intentionally left out-of-scope for
a later PR to handle? -->

<!-- Were there any alternative approaches you considered? What
tradeoffs did you consider? -->

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [ ] Addresses an existing issue: #0000
- [ ] Ran `yarn fastpass`
- [x] Added/updated relevant unit test(s) (and ran `yarn test`)
- [x] Verified code coverage for the changes made. Check coverage report
at: `<rootDir>/test-results/unit/coverage`
- [x] PR title *AND* final merge commit title both start with a semantic
tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See
`CONTRIBUTING.md`.
- [ ] (UI changes only) Added screenshots/GIFs to description above
- [ ] (UI changes only) Verified usability with NVDA/JAWS

---------

Co-authored-by: Rakesh Shivapooja <[email protected]>
Co-authored-by: Vikash Yadav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update duplicate-id rules to align with WCAG 2.2
3 participants