Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(duplicate-id-aria): set to review on fail and tag as wcag412 #4075

Merged
merged 2 commits into from
Jul 3, 2023
Merged

feat(duplicate-id-aria): set to review on fail and tag as wcag412 #4075

merged 2 commits into from
Jul 3, 2023

Conversation

WilcoFiers
Copy link
Contributor

Closes: #3892

@WilcoFiers WilcoFiers requested a review from a team as a code owner June 30, 2023 09:29
WilcoFiers
WilcoFiers commented Jun 30, 2023
View reviewed changes
test/integration/rules/runner.js
Comment on lines +98 to +100
assert.lengthOf(
test[collection],
0,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lets us say not to expect any violations. Previously that was just erroring.

@dbjorge
Copy link
Contributor

dbjorge commented Jun 30, 2023

This is marked as closing 3892, but that issue includes this note that I don't think has been resolved yet:

Future: We've been talking about possibly replacing [duplicate-id-aria] with a more focused idref-labels-and-aria rule that doesn't just look at duplicates, but considers whether based on DOM order that's likely to cause an accessibility problem. As part of resolving this issue we should have a proposal of that rule written.

Are we still planning that? Do we at least want to extract that bit to a separate rule suggestion issue before allowing this PR to close it?

dbjorge
dbjorge approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@dbjorge dbjorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM!

@WilcoFiers
Copy link
Contributor Author

Here's the issue you asked for: #4076

@WilcoFiers WilcoFiers merged commit 9f1a3e3 into develop Jul 3, 2023
@WilcoFiers WilcoFiers deleted the aria-ids-review branch July 3, 2023 10:07
@attest-team-ci attest-team-ci mentioned this pull request Sep 6, 2023
Merged
@v-viyada v-viyada mentioned this pull request Apr 8, 2024
Merged
7 tasks
v-viyada added a commit to microsoft/accessibility-insights-web that referenced this pull request Apr 25, 2024
@SaanicaG @v-rakeshsh @v-viyada
feat(axe-core 4.8): Axe core version upgrade for Web (#7274)
df756f3 
#### Details
This PR updates axe-core to its latest version,
[4.8.4](https://github.com/dequelabs/axe-core/releases/v4.8.4), from
[4.7.2](https://github.com/dequelabs/axe-core/releases/v4.7.2). It also
bumps the accessibility-insights-report package version. As part of the
axe-core update:

- The deprecate & disable duplicate-id / duplicate-id-active rule has
been deprecated (dequelabs/axe-core#4071).
- moved duplicate-id-aria to needs review.
(dequelabs/axe-core#4075)
<img width="922" alt="image"
src="https://github.com/microsoft/accessibility-insights-web/assets/95463767/152c51ce-16d9-4550-aee2-6ddd8155a722">


- checks: enable help-same-as-label, but remove from rules
(dequelabs/axe-core#4096)

- Various improvements were made to the types. Potentially the most
impactful of which is that the target and ancestry property now return
as UnlabelledFrameSelector instead of as string[],

- Major version upgrade 4.8.0 details
https://github.com/dequelabs/axe-core/releases/tag/v4.8.0

<!-- Usually a sentence or two describing what the PR changes -->

##### Motivation

This change is part of
https://dev.azure.com/mseng/1ES/_workitems/edit/2157659/

##### Context

<!-- Are there any parts that you've intentionally left out-of-scope for
a later PR to handle? -->

<!-- Were there any alternative approaches you considered? What
tradeoffs did you consider? -->

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [ ] Addresses an existing issue: #0000
- [ ] Ran `yarn fastpass`
- [x] Added/updated relevant unit test(s) (and ran `yarn test`)
- [x] Verified code coverage for the changes made. Check coverage report
at: `<rootDir>/test-results/unit/coverage`
- [x] PR title *AND* final merge commit title both start with a semantic
tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See
`CONTRIBUTING.md`.
- [ ] (UI changes only) Added screenshots/GIFs to description above
- [ ] (UI changes only) Verified usability with NVDA/JAWS

---------

Co-authored-by: Rakesh Shivapooja <[email protected]>
Co-authored-by: Vikash Yadav <[email protected]>
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 3, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 9, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 19, 2024
Open
@organich organich mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbjorge dbjorge dbjorge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update duplicate-id rules to align with WCAG 2.2
2 participants
@WilcoFiers @dbjorge