Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export: provide hosted export targets #1739

Closed
bnb opened this issue Nov 23, 2019 · 6 comments
Closed

export: provide hosted export targets #1739

bnb opened this issue Nov 23, 2019 · 6 comments
Assignees
@adarshrema
Labels
feature request status: resolved This issue has been merged into main and deployed to canary.

Comments

@bnb
Copy link

bnb commented Nov 23, 2019

Is your feature request related to a problem? Please describe.

Nope.

Describe the desired outcome

Currently, if I export I just get a bare HTML file. If I want to share this with peers, I need to publish it myself.

While I personally know of and have access to a dozen ways to publish a single HTML file rapidly, this isn't true of everyone who may use Accessibility Insights.

I'd love to see something like "Export to..." built-in to this project - more specifically, it would be cool to see "Export to..." options for Glitch, CodePen, GitHub Pages (if authed and a repo is selected?), and possibly even enable the community to contribute additional targets.

Describe alternatives you've considered

The status quo is one alternative - it doesn't add any complexity, but does make exporting and sharing results harder.

An additional option would be an interactive CLI published to npm that requires you have npm and Node.js installed. Running something like npx insights-publish ./path/to/insights/export.html could be another option. This seems like potentially a significantly larger amount of work would be needed, though if you wanted to build built-in plugin support you could add something like npx insights-publish --to=glitch ./path/to/insights/export.html where the module resolves --to=glitch as an additional module with a prefix like insights-plugin-glitch that it will install and that can hook into an extension API and publish as the author of insights-plugin-glitch defines.

Additional context

None.
@msft-github-bot msft-github-bot added the status: new This issue is new and requires triage by DRI. label Nov 23, 2019
@adarshrema adarshrema added status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. and removed status: new This issue is new and requires triage by DRI. labels Nov 25, 2019
@msft-github-bot
Copy link
Collaborator

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@adarshrema
Copy link

Hello @bnb, thank you for using Accessibility Insights for Web and this feature request. Looks like this would support a workflow specific to your team/ project. We welcome any contributions from your team to make this happen.

We are interested in gauging how attractive this feature might be for the larger community. However, given our current priorities and information we have about this feature request so far, it is not likely that we will be able to pick this up anytime soon.

@adarshrema adarshrema added help wanted Extra attention is needed and removed status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. labels Nov 27, 2019
@sean-beard sean-beard mentioned this issue Feb 28, 2020
Merged
7 tasks
dbjorge pushed a commit that referenced this issue Apr 14, 2020
@sean-beard
feat(report): support ability to export to CodePen (#2252)
1c8ff9b 
#### Description of changes
These changes add the option to export reports to CodePen in addition to an HTML file. There is a [relevant open issue](#1739) detailing a need for this type of functionality. 

I wasn't quite sure what the design should look like for this so I've went ahead and used a split `PrimaryButton` from `office-ui-fabric-react` in the `ExportDialog ` component but I'm definitely open to alternative approaches!


![a11y-report-export](https://user-images.githubusercontent.com/8262156/75588928-d8c8e600-5a36-11ea-930e-155c459a8bae.gif)


I was also considering splitting out the HTML and CSS before sending the payload to CodePen but I figured I'd get some feedback on the changes within this PR before moving forward with more in-depth functionality.

<!--
  A great PR description includes:
    * A high level overview (usually a sentence or two) describing what the PR changes
    * What is the motivation for the change? This can be as simple as "addresses issue #123"
    * Were there any alternative approaches you considered? What tradeoffs did you consider?
    * What **doesn't** the change try to do? Are there any parts that you've intentionally left out-of-scope for a later PR to handle? What are the issues/work items tracking that later work?
    * Is there any other context that reviewers should consider? For example, other related issues/PRs, or any particularly tricky/subtle bits of implementation that need closer-than-normal review?
-->

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox -->
- [x] Addresses an existing issue: #1739
- [x] Ran `yarn fastpass`
- [x] Added/updated relevant unit test(s) (and ran `yarn test`)
- [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage`
- [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). Check workflow guide at: `<rootDir>/docs/workflow.md`
- [x] (UI changes only) Added screenshots/GIFs to description above
- [x] (UI changes only) Verified usability with NVDA/JAWS
@juchampa
Copy link

juchampa commented Jun 27, 2020 •
edited
Loading

Hi @bnb ,

We are happy to inform you this issue has been addressed through a public contribution to our open source repository here, by @sean-beard . This feature is now under a public flag, so feel free to use this feature and contribute to it if you'd like.

@bnb
Copy link
Author

bnb commented Jun 27, 2020

Thought I had responded to this initially, but apparently not.

Hello @bnb, thank you for using Accessibility Insights for Web and this feature request. Looks like this would support a workflow specific to your team/ project. We welcome any contributions from your team to make this happen.

This has nothing to do with my specific team. The context in which I was asking was open-source work in which I used Accessibility Insights to provide feedback on how extremely inaccessible the site being proposed was. I outlined the entire scope of why I was requesting this in my initial comment and am concerned that the context that was extracted there was that it’s something my team was requesting when that is categorically not true and I provided no such indicator.

This feature is now under a public flag, so feel free to use this feature and contribute to it if you'd like.

Would you be open to PRs from maintainers of additional sites similar to CodePen PRing support for their sites?

@ferBonnin
Copy link
Contributor

This has nothing to do with my specific team. The context in which I was asking was open-source work in which I used Accessibility Insights to provide feedback on how extremely inaccessible the site being proposed was. I outlined the entire scope of why I was requesting this in my initial comment and am concerned that the context that was extracted there was that it’s something my team was requesting when that is categorically not true and I provided no such indicator.

Hi @bnb thanks for clarifying that and our apologies for the confusion!

Would you be open to PRs from maintainers of additional sites similar to CodePen PRing support for their sites?

We are open to contributions like the existing CodePen one, however we would prioritize sites for where there is user demand and we might need a different UX experience if we were to have more than 2-3 options on where to export to.

@ferBonnin ferBonnin added status: resolved This issue has been merged into main and deployed to canary. and removed help wanted Extra attention is needed labels Jul 6, 2020
@ferBonnin
Copy link
Contributor

this has been resolved for a while after the codePen integration with no other users' comments. closing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adarshrema adarshrema

Labels
feature request status: resolved This issue has been merged into main and deployed to canary.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@bnb @ferBonnin @JGibson2019 @msft-github-bot @adarshrema @juchampa