Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added setting to skip tags for e2e-reliability pipeline #7282

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

v-viyada
Copy link
Contributor

Details

1ES PT adds tags to pipeline runs using the access token provided by ADO. In the case of pipeline runs against forked repos of a GitHub repo, the access token does not have Edit build quality permissions and hence cannot add tags. To unblock those pipelines, skipped tagging by using the option SkipBuildTagsForGitHubPullRequests. This is similar change which we did earlier for other pipelines like https://github.com/microsoft/accessibility-insights-docs/pull/1921

Verified that the only change in the pipeline run is that it do not add "1ES.PT.Unofficial" tag on the Run. In place of that it adds below warning message.

##[warning]1ES PT Warning: Skipping build tags as this build is a pull request form GitHub which does not have permissions to add tags.

Motivation
Context

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@v-viyada v-viyada force-pushed the disable-tagging-fork-PR branch from e5535ee to 16deb02 Compare March 20, 2024 17:23
@v-viyada v-viyada changed the title fix: Added setting to skip tags for 1ES PT fix: Added setting to skip tags for e2e-reliability pipeline Mar 20, 2024
@v-viyada v-viyada marked this pull request as ready for review March 20, 2024 17:40
@v-viyada v-viyada requested a review from a team as a code owner March 20, 2024 17:40
@v-viyada v-viyada merged commit a5a4401 into microsoft:main Mar 20, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants