Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Links to Design Pattern > Assessment #6155

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

Pranav-yadav
Copy link
Contributor

@Pranav-yadav Pranav-yadav commented Oct 27, 2022

  • point to correct ARIA APG links
  • fix various broken links w/ (typos)
  • fix unit tests for the same :)

Details

#6116 (comment)

This is the landing page link, we would need to point to the right subpage for each pattern. For example for combobox the current link is: https://www.w3.org/TR/wai-aria-practices-1.1/#combobox the new link should be: https://www.w3.org/WAI/ARIA/apg/patterns/combobox/

Motivation

closes #6116

Context

Pull request checklist

  • Addresses an existing issue: Links to Design Pattern in Assessment take you to main ARIA APG page #6116
  • [-] Ran yarn null:autoadd
  • [-] Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [-] (UI changes only) Added screenshots/GIFs to description above
  • [-] (UI changes only) Verified usability with NVDA/JAWS

- point to correct ARIA APG
- fix various broken links w/ (typos)
@Pranav-yadav Pranav-yadav requested a review from a team as a code owner October 27, 2022 18:55
Copy link
Member

@waabid waabid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

Copy link
Contributor

@ferBonnin ferBonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor change requested, otherwise looks good!

@ferBonnin ferBonnin self-requested a review October 28, 2022 18:00
@Pranav-yadav
Copy link
Contributor Author

Looks like tests also needs update.
Updating..

@Pranav-yadav
Copy link
Contributor Author

@ferBonnin Apart from this PR, I wasn't able to setup the local dev env for this repo, getting errors due to node version. PFA, (tried upgrading node, re-installing, cleaning caches, etc. still it didn't work) any guess?
image

@Pranav-yadav
Copy link
Contributor Author

Pranav-yadav commented Oct 28, 2022

Andd this one isn't related to changes in this PR I guess? :-
actions/runs/3347486791/jobs/5545523927#step:11:932

Edit: Done!

@Pranav-yadav Pranav-yadav force-pushed the chore/design-pattern-hrefs branch from 015fe08 to 114af3f Compare October 28, 2022 19:17
@Pranav-yadav
Copy link
Contributor Author

Fixed the tests :)

PS: Lmk, how to resolve 👇

@ferBonnin Apart from this PR, I wasn't able to setup the local dev env for this repo, getting errors due to node version. PFA, (tried upgrading node, re-installing, cleaning caches, etc. still it didn't work) any guess? image

@ferBonnin
Copy link
Contributor

Andd this one isn't related to changes in this PR I guess? :- actions/runs/3347486791/jobs/5545523927#step:11:932

I re-ran that job and it looks ok now 🙂

@ferBonnin
Copy link
Contributor

@ferBonnin Apart from this PR, I wasn't able to setup the local dev env for this repo, getting errors due to node version. PFA, (tried upgrading node, re-installing, cleaning caches, etc. still it didn't work) any guess? image

tagging @lisli1 to see if we can help with this!

@lisli1
Copy link
Contributor

lisli1 commented Oct 28, 2022

@ferBonnin Apart from this PR, I wasn't able to setup the local dev env for this repo, getting errors due to node version. PFA, (tried upgrading node, re-installing, cleaning caches, etc. still it didn't work) any guess? image

@Pranav-yadav we only support the version that we actively test against, which is currently 16. Please try using node version ^16.14.2 and see if that solves your issue. For managing different node installs side-by-side, you may try using Volta (on Windows) or nvm (on mac/linux/WSL).

@Pranav-yadav
Copy link
Contributor Author

Thanks @lisli1 , got it.

@Pranav-yadav
Copy link
Contributor Author

Hey @lisli1!
Are any further changes required? :)

@ferBonnin ferBonnin merged commit 0ce2120 into microsoft:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links to Design Pattern in Assessment take you to main ARIA APG page
4 participants