-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update Links to Design Pattern > Assessment #6155
chore: update Links to Design Pattern > Assessment #6155
Conversation
- point to correct ARIA APG - fix various broken links w/ (typos)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor change requested, otherwise looks good!
src/assessments/custom-widgets/custom-widgets-column-renderer.tsx
Outdated
Show resolved
Hide resolved
Looks like tests also needs update. |
@ferBonnin Apart from this PR, I wasn't able to setup the local dev env for this repo, getting errors due to node version. PFA, (tried upgrading node, re-installing, cleaning caches, etc. still it didn't work) any guess? |
Andd this one isn't related to changes in this PR I guess? :- Edit: Done! |
015fe08
to
114af3f
Compare
Fixed the tests :) PS: Lmk, how to resolve 👇
|
I re-ran that job and it looks ok now 🙂 |
tagging @lisli1 to see if we can help with this! |
@Pranav-yadav we only support the version that we actively test against, which is currently 16. Please try using node version ^16.14.2 and see if that solves your issue. For managing different node installs side-by-side, you may try using Volta (on Windows) or nvm (on mac/linux/WSL). |
Thanks @lisli1 , got it. |
Hey @lisli1! |
Details
#6116 (comment)
Motivation
closes #6116
Context
Pull request checklist
yarn null:autoadd
yarn fastpass
yarn test
)<rootDir>/test-results/unit/coverage
fix:
,chore:
,feat(feature-name):
,refactor:
). SeeCONTRIBUTING.md
.