Skip to content

Commit

Permalink
chore: update Links to Design Pattern > Assessment (#6155)
Browse files Browse the repository at this point in the history 
- [x] point to correct ARIA APG links
- [x] fix various broken links w/ (typos)
- [x] fix unit tests for the same :)

#### Details

#6116 (comment)
> This is the [landing page
link](https://www.w3.org/WAI/ARIA/apg/patterns), we would need to point
to the right subpage for each pattern. For example for combobox the
current link is: https://www.w3.org/TR/wai-aria-practices-1.1/#combobox
the new link should be:
https://www.w3.org/WAI/ARIA/apg/patterns/combobox/

<!-- Usually a sentence or two describing what the PR changes -->

##### Motivation

<!-- This can be as simple as "addresses issue #123" -->
closes #6116 

##### Context

<!-- Are there any parts that you've intentionally left out-of-scope for
a later PR to handle? -->

<!-- Were there any alternative approaches you considered? What
tradeoffs did you consider? -->

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [x] Addresses an existing issue: #6116 
- [-] Ran `yarn null:autoadd`
- [-] Ran `yarn fastpass`
- [x] Added/updated relevant unit test(s) (and ran `yarn test`)
- [x] Verified code coverage for the changes made. Check coverage report
at: `<rootDir>/test-results/unit/coverage`
- [x] PR title *AND* final merge commit title both start with a semantic
tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See
`CONTRIBUTING.md`.
- [-] (UI changes only) Added screenshots/GIFs to description above
- [-] (UI changes only) Verified usability with NVDA/JAWS
  • Loading branch information
@Pranav-yadav
Pranav-yadav authored Oct 31, 2022
1 parent 4d58ece commit 0ce2120
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 34 deletions.
52 changes: 24 additions & 28 deletions src/assessments/custom-widgets/custom-widgets-column-renderer.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,94 +55,90 @@ function makeFlatDesignPatternString(patterns: DesignPattern[]): string {
}

const roleToDesignPatternsMapping: DictionaryStringTo<DesignPattern[]> = {
alert: [{ designPattern: 'Alert', URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#alert' }],
alert: [{ designPattern: 'Alert', URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/alert' }],
alertdialog: [
{
designPattern: 'Alert or Message Dialog',
URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#alertdialog',
URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/alertdialog',
},
],
button: [
{
designPattern: 'Accordion',
URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#accordion',
URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/accordion',
},
{ designPattern: 'Button', URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#button' },
{ designPattern: 'Button', URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/button' },
{
designPattern: 'Disclosure (Show/Hide)',
URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#disclosure',
URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/disclosure',
},
{
designPattern: 'Menu Button',
URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#menubutton',
URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/menubutton',
},
],
checkbox: [
{
designPattern: 'Checkbox',
URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#checkbox',
URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/checkbox',
},
],
combobox: [
{
designPattern: 'Combo Box',
URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#combobox',
URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/combobox',
},
],
dialog: [
{
designPattern: 'Dialog (Modal)',
URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#dialog_modal',
URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/dialogmodal',
},
],
feed: [{ designPattern: 'Feed', URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#feed' }],
grid: [{ designPattern: 'Grid', URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#grid' }],
link: [{ designPattern: 'Link', URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#link' }],
feed: [{ designPattern: 'Feed', URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/feed' }],
grid: [{ designPattern: 'Grid', URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/grid' }],
link: [{ designPattern: 'Link', URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/link' }],
listbox: [
{ designPattern: 'Listbox', URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#Listbox' },
],
menu: [{ designPattern: 'Menu', URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#menu' }],
menubar: [
{ designPattern: 'Menu Bar', URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#menu' },
{ designPattern: 'Listbox', URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/listbox' },
],
menu: [{ designPattern: 'Menu', URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/menu' }],
menubar: [{ designPattern: 'Menu Bar', URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/menu' }],
radiogroup: [
{
designPattern: 'Radio Group',
URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#radiobutton',
URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/radiobutton',
},
],
separator: [
{
designPattern: 'Window Splitter',
URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#windowsplitter',
URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/windowsplitter',
},
],
slider: [
{ designPattern: 'Slider', URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#slider' },
{ designPattern: 'Slider', URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/slider' },
{
designPattern: 'Slider (Multi-thumb)',
URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#sliderwothumb',
URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/slidertwothumb',
},
],
spinbutton: [
{
designPattern: 'Spinbutton',
URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#spinbutton',
URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/spinbutton',
},
],
tablist: [
{ designPattern: 'Tabs', URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#tabpanel' },
],
tablist: [{ designPattern: 'Tabs', URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/tabpanel' }],
toolbar: [
{ designPattern: 'Toolbar', URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#toolbar' },
{ designPattern: 'Toolbar', URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/toolbar' },
],
tooltip: [
{ designPattern: 'Tooltip', URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#tooltip' },
{ designPattern: 'Tooltip', URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/tooltip' },
],
tree: [
{
designPattern: 'Tree View',
URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#TreeView',
URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/treeview',
},
],
};
12 changes: 6 additions & 6 deletions src/tests/unit/tests/assessments/custom-widgets/custom-widgets-column-renderer.test.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -62,19 +62,19 @@ describe('CustomWidgetsColumnRenderer', () => {
const expectedValues = [
{
designPattern: 'Accordion',
URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#accordion',
URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/accordion',
},
{
designPattern: 'Button',
URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#button',
URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/button',
},
{
designPattern: 'Disclosure (Show/Hide)',
URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#disclosure',
URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/disclosure',
},
{
designPattern: 'Menu Button',
URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#menubutton',
URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/menubutton',
},
];
item.instance.propertyBag.role = 'button';
Expand Down Expand Up @@ -103,11 +103,11 @@ describe('CustomWidgetsColumnRenderer', () => {
const expectedValues = [
{
designPattern: 'Slider',
URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#slider',
URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/slider',
},
{
designPattern: 'Slider (Multi-thumb)',
URL: 'https://www.w3.org/TR/wai-aria-practices-1.1/#sliderwothumb',
URL: 'https://www.w3.org/WAI/ARIA/apg/patterns/slidertwothumb',
},
];
item.instance.propertyBag.role = 'slider';
Expand Down

0 comments on commit 0ce2120

Please sign in to comment.