Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enzyme replacement in test files- PR 1 of 6 for part 3 of 3 #7232

Merged
merged 18 commits into from
Mar 5, 2024

Conversation

v-singhanjal
Copy link
Contributor

@v-singhanjal v-singhanjal commented Feb 2, 2024

Details

Enzyme replacement in files under src/tests/unit/tests/DetailsView/

Motivation

Existing story: User Story 2142857
Replaced the use of Enzyme in the below files:

  1. src/tests/unit/tests/DetailsView/components/status-icon.test.tsx
  2. src/tests/unit/tests/DetailsView/components/switcher.test.tsx
  3. src/tests/unit/tests/DetailsView/components/tab-stops-failed-instance-section.test.tsx
  4. src/tests/unit/tests/DetailsView/components/tab-stops-minimal-requirement-header.test.tsx
  5. src/tests/unit/tests/DetailsView/components/tab-stops-requirement-instances-collapsible-content.test.tsx
  6. src/tests/unit/tests/DetailsView/components/tab-stops-requirements-with-instances.test.tsx
  7. src/tests/unit/tests/DetailsView/components/target-change-dialog.test.tsx
  8. src/tests/unit/tests/DetailsView/components/target-page-changed-view.test.tsx
  9. src/tests/unit/tests/DetailsView/components/target-page-hidden-bar.test.tsx
  10. src/tests/unit/tests/DetailsView/components/test-status-choice-group.test.tsx
  11. src/tests/unit/tests/DetailsView/components/test-view-container.test.tsx
  12. src/tests/unit/tests/DetailsView/components/transfer-to-assessment-button.test.tsx
  13. src/tests/unit/tests/DetailsView/details-view-body.test.tsx
  14. src/tests/unit/tests/DetailsView/details-view-container.test.tsx
  15. src/tests/unit/tests/DetailsView/details-view-content.test.tsx
Context

Pull request checklist

  • Addresses an existing issue: User Story 2142857
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@v-singhanjal v-singhanjal changed the title chore: Enzyme replacement in test files (Part 3) chore: Enzyme replacement in test files- PR 1 of 6 for part 3 of 3 Feb 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0ec9a0) 94.30% compared to head (bd65411) 94.32%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7232      +/-   ##
==========================================
+ Coverage   94.30%   94.32%   +0.02%     
==========================================
  Files        1225     1224       -1     
  Lines       20697    20696       -1     
  Branches     1308     1308              
==========================================
+ Hits        19518    19522       +4     
+ Misses       1160     1155       -5     
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@v-prachin v-prachin marked this pull request as ready for review February 12, 2024 08:39
@v-prachin v-prachin requested a review from a team as a code owner February 12, 2024 08:39
Copy link
Contributor

@madalynrose madalynrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! There were a lot of complex tests here. I made some suggestions and once those are implemented it's ready to go!

@v-singhanjal v-singhanjal merged commit 4694165 into microsoft:main Mar 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants