Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor changes to improve stability for e2e tests #1722

Merged
merged 2 commits into from
Nov 21, 2019

Conversation

Shobhit1
Copy link
Contributor

Description of changes

One of the most common timeout issue in our e2e was in settings-panel & high-contrast e2e tests where the keyPress('escape') was not getting registered properly and so I changed that event with pressing the cross button on the settings panel to exit it. This should hopefully fix that timeout error on settings panel tests.

Also added --no-cache to yarn:dev in our docker to avoid a dev build cache system which I was hitting regularly in my local build.

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). Check workflow guide at: <rootDir>/docs/workflow.md
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@Shobhit1 Shobhit1 added pr: auto-merge Automatically squash merge all checks have passed and approvals granted. There is a 15 minute delay. category: engineering labels Nov 20, 2019
@Shobhit1 Shobhit1 requested a review from a team as a code owner November 20, 2019 21:26
@Shobhit1 Shobhit1 self-assigned this Nov 20, 2019
@msft-github-bot
Copy link
Collaborator

Hello @Shobhit1!

Because this pull request has the pr: auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 1 minute. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.

@dbjorge dbjorge merged commit 9975951 into microsoft:master Nov 21, 2019
@Shobhit1 Shobhit1 deleted the shobhit1/docker-improvements branch November 21, 2019 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: engineering pr: auto-merge Automatically squash merge all checks have passed and approvals granted. There is a 15 minute delay.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants