Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mocked date for command Bar unit test case #7270

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

v-viyada
Copy link
Contributor

Details

Unit test case for details-view-command-bar.test is failing due to mismatched dates between saved snapshot and rendered object. Rendered object always takes the current date. Mocked the date in the test case to return specific date instead of current date.

Motivation
Context

Pull request checklist

  • [n/a] Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@v-viyada v-viyada marked this pull request as ready for review March 12, 2024 18:32
@v-viyada v-viyada requested a review from a team as a code owner March 12, 2024 18:32
@v-viyada v-viyada merged commit 046449c into main Mar 12, 2024
12 checks passed
@v-viyada v-viyada deleted the fixcommandbartest branch March 13, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants