chore: Remove deprecated TypeScript options #6611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 3, 2023
|
Closing this as we only wanted the build information |
7 tasks
7 tasks
JeevaniChinthala
added a commit
that referenced
this pull request
Feb 29, 2024
…ctedtest (#7249) #### Details As part of Typescript migration added/removed the error causing fields. ##### Motivation TypeScript 5.0 has marked some options as deprecated. We can temporarily override these deprecations, but the documented plan is for the ability to override the flag to go away in TypeScript 5.5 ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> 1. **tooltip** - **Error :** No overload matches this call. Property 'tooltipId' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<AssessmentInstanceDetailsColumn> - As per the history of commits it was present earlier and in one of the commits they removed. - Comment given was null strictness fixes for leaf files in assessment ,common,DetailsView ,reports,tests, view. - Considering this, removing the property. 2. **status** - **Error :** Object literal may only specify known properties, and 'status' does not exist in type 'CardRuleResult'. - If we observe the usage of const createCardRuleResult -> status: string, createRuleResultWithoutNodes -> status: CardRuleResultStatus where ‘status’ has pre-defined values which will be passed to status property which is giving error. - Status holds some value, considering this, added the property. 3. **selectedtest** - **Error :** { triggeredBy: TriggeredBy; source: TelemetryEventSource.DetailsView; selectedRequirement: string; selectedTest: string; }' is not assignable to type 'RequirementActionTelemetryData'. - For this property in given file it has been passed value of VisualizationType[test] and can see similar behavior of properties used in the same file. - Considering this, added the property. 4. **deps:props.deps** - **Error:** - { deps: TargetChangeDialogDeps; prevTab: PersistedTabInfo; dialogContentTitle: string; subtitleAriaId: string; divId: string; leftButtonText: string; ... 8 more ...; rightButtonDataAutomationId: string; }' is not assignable to type 'ChangeAssessmentDialogProps'. Object literal may only specify known properties, and 'deps' does not exist in type 'ChangeAssessmentDialogProps' - Checked all the relevant files and did check in UI, compared with old UI with new change, they didn't used this property. #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: #(#6611) - [ ] Ran `yarn fastpass` - [ ] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [ ] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [ ] (UI changes only) Added screenshots/GIFs to description above - [ ] (UI changes only) Verified usability with NVDA/JAWS
7 tasks
SaanicaG
added a commit
that referenced
this pull request
Mar 7, 2024
#### Details
As part of Typescript migration added/removed the error causing fields.
1. src/DetailsView/components/details-view-content.tsx
- For the above file we were getting errors on getOverviewHeadingIntro,
linkDataSource, getOverviewHelpSectionAbout these properties.
- These properties are referred in details-view-switcher-nav.ts,
overview-content-container.tsx.
- Hence, we are not removing these properties, and added it in
details-view-body.tsx.
2.
src/DetailsView/components/details-view-overlay/scoping-panel/scoping-panel.tsx
- We were getting error on deps={this.props.deps}.
- In details-view-overlay.tsx class ScopingPanel is used.
- Hence, we are not removing these properties and added it in
scoping-container.tsx
3. Details-view-switcher-nav.ts
- Got error on shouldShowQuickAssessRequirementView: true,
- Couldn’t find any reference to the above property in any of the files.
- Tested it after removing the property. There are no errors and also on
UI level couldnt find any issues.
-Hence, it seems like it is safe to remove it.
##### Motivation
TypeScript 5.0 has marked some options as deprecated. We can temporarily
override these deprecations, but the documented plan is for the ability
to override the flag to go away in TypeScript 5.5
<!-- This can be as simple as "addresses issue #123" -->
Associated User story - [User Story
2151430](https://dev.azure.com/mseng/1ES/_workitems/edit/2151430)
##### Context
<!-- Are there any parts that you've intentionally left out-of-scope for
a later PR to handle? -->
<!-- Were there any alternative approaches you considered? What
tradeoffs did you consider? -->
#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [x] Addresses an existing issue:
#(#6611)
- [ ] Ran `yarn fastpass`
- [ ] Added/updated relevant unit test(s) (and ran `yarn test`)
- [ ] Verified code coverage for the changes made. Check coverage report
at: `<rootDir>/test-results/unit/coverage`
- [ ] PR title *AND* final merge commit title both start with a semantic
tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See
`CONTRIBUTING.md`.
- [ ] (UI changes only) Added screenshots/GIFs to description above
- [ ] (UI changes only) Verified usability with NVDA/JAWS
7 tasks
5 tasks
JeevaniChinthala
added a commit
that referenced
this pull request
Apr 1, 2024
#### Details
As part of Typescript migration added/removed the error causing fields.
As most of the files are test cases which were removed from actual file
but not updated the test case files.
##### Motivation
TypeScript 5.0 has marked some options as deprecated. We can temporarily
override these deprecations, but the documented plan is for the ability
to override the flag to go away in TypeScript 5.5
##### Context
**1. displayName: 'JSON'**
- **Error:** Type '{ key: "json"; displayName: string; generateMenuItem:
(onMenuItemClick: (event: MouseEvent<HTMLButtonElement |
HTMLAnchorElement, MouseEvent>, selectedServiceKey:
ReportExportServiceKey) => void, href: string, download: string) => {
...; }; }' is not assignable to type 'ReportExportService'.
- Object literal may only specify known properties, and 'displayName'
does not exist in type 'ReportExportService'.
**2. columnConfiguration: []**
- **Error :** Type '{ instancesMap:
DictionaryStringTo<GeneratedAssessmentInstance<{}, {}>>;
columnConfiguration: undefined[]; assessmentNavState: { ...; }; ... 4
more ...; hasVisualHelper: true; }' is not assignable to type
'AssessmentInstanceTableProps'
- Object literal may only specify known properties, and
'columnConfiguration' does not exist in type
'AssessmentInstanceTableProps'.
**3. noClick**
- **Error:** Property 'noClick' does not exist on type
**4. newTab: newTab**
- **Error:** Type '{ deps: { urlParser: UrlParser;
getAssessmentActionMessageCreator: () => AssessmentActionMessageCreator;
detailsViewId: undefined; }; prevTab: PersistedTabInfo; ... 4 more ...;
isOpen: true; }' is not assignable to type 'LoadAssessmentDialogProps'.
- Object literal may only specify known properties, and 'newTab' does
not exist in type 'LoadAssessmentDialogProps'.
**5. showAssessment: true**
- **Error:** Type '{ showAssessment: true; showTest: true; }' is not
assignable to type 'StartOverContextMenuKeyOptions'.
Object literal may only specify known properties, and 'showAssessment'
does not exist in type 'StartOverContextMenuKeyOptions'.
- In actual file they removed the StartOverContextMenuKeyOptions
'showAssessment: true,' and didn't removed from test file
**6. status: 'fail'**
- **Error:** Type '{ deps: { tabStopRequirementActionMessageCreator:
TabStopRequirementActionMessageCreator; tabStopsTestViewController:
TabStopsTestViewController; }; requirementState:
TabStopRequirementState; status: string; }' is not assignable to type
'TabStopsRequirementsTableProps'.
- Object literal may only specify known properties, and 'status' does
not exist in type 'TabStopsRequirementsTableProps'
**7. highlightState: 'hidden**
- **Error:** Type '{ deps: InstanceDetailsFooterDeps; result:
CardResult; rule: UnifiedRule; targetAppInfo: TargetAppData;
highlightState: string; userConfigurationStoreData:
UserConfigurationStoreData; }' is not assignable to type
'InstanceDetailsFooterProps'.
- Object literal may only specify known properties, and 'highlightState'
does not exist in type 'InstanceDetailsFooterProps'.
- highlightState was removed from actual file and didn't update the test
case.
**8. fixInstructionProcessor**
- **Error:** Type '{ deps: InstanceDetailsGroupDeps;
fixInstructionProcessor: FixInstructionProcessor; recommendColor:
RecommendColor; rule: CardRuleResult; userConfigurationStoreData: null;
targetAppInfo: { ...; }; cardSelectionMessageCreator:
CardSelectionMessageCreator; }' is not assignable to type
'InstanceDetailsGroupProps'.
- Object literal may only specify known properties, and
'fixInstructionProcessor' does not exist in type
'InstanceDetailsGroupProps'.
**9. showCongratsIfNotInstances: true**
- **Error:** Type '{ deps: ResultSectionContentDeps; results:
CardRuleResult[]; outcomeType: "pass"; showCongratsIfNotInstances:
boolean; userConfigurationStoreData: null; ... 5 more ...;
cardSelectionMessageCreator: CardSelectionMessageCreator; }' is not
assignable to type 'ResultSectionContentProps'.
- Object literal may only specify known properties, and
'showCongratsIfNotInstances' does not exist in type
'ResultSectionContentProps'.
**10. iconName="test icon"**
- **Error :** Type '{ deps: { contentProvider: ContentProvider;
contentActionMessageCreator: ContentActionMessageCreator; }; guidance:
string; headingTitle: string; iconName: string; }' is not assignable to
type 'IntrinsicAttributes & HeaderWithContentLinkProps & { children?:
ReactNode; }'
- Property 'iconName' does not exist on type 'IntrinsicAttributes &
HeaderWithContentLinkProps
**11. selectedTest: VisualizationType[-1]**
- Here for this error the props imported was wrong instead of
AssessmentRequirementScanTelemetryData they used
RuleAnalyzerScanTelemetryData due to this getting error.
**12. requirementName**
- **Error:** Type '{ scanDuration: number; NumberOfElementsScanned:
number; include: undefined[]; exclude: undefined[]; testName: string;
requirementName: string; }' is not assignable to type
'RuleAnalyzerScanTelemetryData'.
Object literal may only specify known properties, and 'requirementName'
does not exist in type 'RuleAnalyzerScanTelemetryData'.
**13. status: ManualTestStatus.FAIL,**
- **Error:** Type '{ step: string; test:
VisualizationType.HeadingsAssessment; status: ManualTestStatus;
assessmentInstanceTableHandler: AssessmentInstanceTableHandler;
manualTestStepResultMap: { ...; }; assessmentsProvider:
AssessmentsProvider; featureFlagStoreData: FeatureFlagStoreData;
pathSnippetStoreData: { ...; }; }' is not assignable to type
'ManualTestStepViewProps'.
- Object literal may only specify known properties, and 'status' does
not exist in type 'ManualTestStepViewProps'.
**14. featureFlagStoreData: {},**
- **Error:** Type '{ container: DetailsDialog; dialogHandler:
IssueDetailsNavigationClickHandler; featureFlagStoreData: {};
failuresCount: number; }' is not assignable to type
'IssueDetailsNavigationControlsProps'.
- Object literal may only specify known properties, and
'featureFlagStoreData' does not exist in type
'IssueDetailsNavigationControlsProps'.
**15. userConfigurationStoreData**
- **Error:** Type '{ deps: IssueFilingSettingsContainerDeps;
selectedIssueFilingService: IssueFilingService;
userConfigurationStoreData: UserConfigurationStoreData;
selectedIssueFilingServiceData: IssueFilingServiceProperties;
onPropertyUpdateCallback: () => any; onSelectedServiceChange: () => any;
}' is not assignable to type 'IssueFilingSettingsContainerProps'.
- Object literal may only specify known properties, and
'userConfigurationStoreData' does not exist in type
'IssueFilingSettingsContainerProps'.
**16. featureFlagStoreData: {},**
- **Error:** Type '{ backLinkHandler: () => void;
diagnosticViewToggleFactory: DiagnosticViewToggleFactory;
featureFlagStoreData: {}; }' is not assignable to type
'AdHocToolsPanelProps'.
- Object literal may only specify known properties, and
'featureFlagStoreData' does not exist in type 'AdHocToolsPanelProps'.
**17. shortcutModifyHandler**
- **Error:** Argument of type '{ diagnosticViewClickHandler: null;
popupViewControllerHandler: PopupViewControllerHandler;
launchPanelHeaderClickHandler: null; shortcutModifyHandler: null; }' is
not assignable to parameter of type 'PopupHandlers'.
- Object literal may only specify known properties, and
'shortcutModifyHandler' does not exist in type 'PopupHandlers'.
#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [x] Addresses an existing issue:
#(#6611)
- [ ] Ran `yarn fastpass`
- [x] Added/updated relevant unit test(s) (and ran `yarn test`)
- [x] Verified code coverage for the changes made. Check coverage report
at: `<rootDir>/test-results/unit/coverage`
- [ ] PR title *AND* final merge commit title both start with a semantic
tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See
`CONTRIBUTING.md`.
- [ ] (UI changes only) Added screenshots/GIFs to description above
- [ ] (UI changes only) Verified usability with NVDA/JAWS
This was referenced Apr 1, 2024
v-prachin
added a commit
that referenced
this pull request
Apr 1, 2024
…ementLink, leftNavLinkBuilder & height:0 (#7276) #### Details Typescript Cleanup Part 2 of 3 We have total 140 errors in 104 files. Thus, targeting each error and fixing it. ##### Motivation Errors observed in below files observed after removing deprecated properties from tsconfig file: 1 **renderRequirementDescription: requirementLink =>** src/assessments/automated-checks/build-test-steps-from-rules.tsx No. Of Error: 1 Removed this property based on this PR: #3163 2.**selector: selector** src/background/assessment-data-converter.ts No. Of Error: 1 Added the property in the interface 3.**selector: selectorStub** src/tests/unit/tests/background/assessment-data-converter.test.ts No. Of Error: 3 Added the property in the interface 4.**isEnabled: true** src/assessments/cognitive/assessment src/assessments/headings/assessment.tsx src/assessments/parsing/assessment.tsx No. Of Error: 3 Added the property in the interface. 5.**leftNavLinkBuilder: leftNavLinkBuilderMock.object** src/tests/unit/tests/DetailsView/components/left-nav/assessment-left-nav.test.tsx No. Of Error: 1 6.**leftNavLinkBuilder: leftNavLinkBuilderMock.object** src/tests/unit/tests/DetailsView/components/left-nav/quick-assess-left-nav.test.tsx No. Of Error: 1 7.**leftNavLinkBuilder: leftNavLinkBuilderMock.object** src/tests/unit/tests/DetailsView/components/left-nav/visualization-based-left-nav.test.tsx No. Of Error: 1 8.**height: 0** src/tests/unit/tests/DetailsView/components/narrow-mode-detector.test.tsx No. Of Error: 1 This property is not present in the main file, thus removed it from the test file. Thus, total number of errors covered as part of this user story: **12** ##### Context #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: #(#6611) - [x] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [n/a] (UI changes only) Added screenshots/GIFs to description above - [n/a] (UI changes only) Verified usability with NVDA/JAWS
This was referenced Apr 3, 2024
v-prachin
added a commit
that referenced
this pull request
Apr 8, 2024
…lType: panelType (#7289) #### Details Typescript Cleanup Part 2 of 3 We have total 140 errors in 104 files. Thus, targeting each error and fixing it. ##### Motivation Errors observed in below files observed after removing deprecated properties from tsconfig file: 1.**rule: ruleStub** src/tests/unit/tests/injected/element-based-view-model-creator.test.ts (9) scanNodeResults consists of unified results as well as ruleStub. So, using scanNodeResults to resolve the issue. 2.**launchPanelType: panelType** src/popup/actions/popup-action-message-creator.ts(1) src/tests/unit/tests/popup/actions/popup-action-message-creator.test.ts(1) Added new type LaunchPanelTelemetryData in extension-telemetry-events.ts, to resolve the error for launchPanelType: panelType Thus, total number of errors covered as part of this user story: **11** ##### Context #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: #(#6611) - [x] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [n/a] (UI changes only) Added screenshots/GIFs to description above - [n/a] (UI changes only) Verified usability with NVDA/JAWS
5 tasks
v-prachin
added a commit
that referenced
this pull request
Apr 8, 2024
…equirement, titleSize="title & defaultViewport: null (#7280) #### Details Typescript Cleanup Part 2 of 3 We have total 140 errors in 104 files. Thus, targeting each error and fixing it. ##### Motivation Errors observed in below files observed after removing deprecated properties from tsconfig file: 1.**order:0** src/issue-filing/services/null-issue-filing-service/null-issue-filing-service.tsx Removed this property as NullIssueFilingService has this order property which seems to be not consumed, as per my understanding. As checked for the references order: and couldn't observe anything relevant to NullIssueFilingService. 2.**titleSize="title"** src/reports/components/report-sections/combined-report-rules-only-sections.tsx (1) Removed this property as CombinedReportResultSectionTitle in other files only has three entities in it, outcomeCount, outcomeType, title. That file is combined-report-failed-section.tsx 3.**defaultViewport: null** src/tests/end-to-end/common/browser-factory.ts (1) Removed this property as defaultViewport has only one reference in the entire solution and that is in brower-factory.ts 4.**requirement: requirementKey** src/tests/unit/tests/background/stores/assessment-store.test.ts (3) Added appropriate interface for requirement & selector properties. 5.**pageTitle** src/tests/unit/tests/reports/components/fast-pass-report-automated-checks-results.test.tsx (1) src/tests/unit/tests/reports/components/fast-pass-report.test.tsx (1) Removed this property as it was not needed in the test file. 6.**x:left** src/injected/visualization/drawer-utils.ts (1) Removed this property as BoundingRect already has left and top properties defined. Thus, total number of errors covered as part of this user story: **9** ##### Context #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: #(#6611) - [x] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [n/a] (UI changes only) Added screenshots/GIFs to description above - [n/a] (UI changes only) Verified usability with NVDA/JAWS
JeevaniChinthala
added a commit
that referenced
this pull request
Apr 9, 2024
…uctionProcessor (#7256) #### Details As part of Typescript migration added/removed the error causing fields. ##### Motivation TypeScript 5.0 has marked some options as deprecated. We can temporarily override these deprecations, but the documented plan is for the ability to override the flag to go away in TypeScript 5.5 ##### Context 1. **Requirement** - **Error:** Type '{ test: VisualizationType; requirement: string; telemetry: AssessmentTelemetryData; }' is not assignable to type 'ToggleActionPayload'. - Object literal may only specify known properties, and 'requirement' does not exist in type 'ToggleActionPayload'. - In AssessmentToggleActionPayload interface the methods enableFastPassVisualHelperWithoutScan and rescanVisualizationWithoutTelemetry uses the requirement property which was an optional property. To avoid null check error a new interface named RequirementToggleActionPayload was introduced, in which the requirement property is declared as either string or undefined. 2. **isSelected** - **Error:** Type '{ isSelected: boolean; status: InstanceResultStatus; ruleId: string; uid: string; identifiers: { conciseName: string; identifier: string; 'css-selector': string; target: Target; }; descriptors: { ...; }; resolution: { ...; }; rule: { ...; }; }' is not assignable to type 'ScanNodeResult'. - Object literal may only specify known properties, and 'isSelected' does not exist in type 'ScanNodeResult'. - Added isSelected in ScanNodeResult in order to get required data. 3. **fixInstructionProcessor** - **Error:** Type'{ deps: InstanceDetailsGroupDeps; fixInstructionProcessor: FixInstructionProcessor; recommendColor: RecommendColor; rule: CardRuleResult; userConfigurationStoreData: null; targetAppInfo: { ...; }; cardSelectionMessageCreator: CardSelectionMessageCreator; }' is not assignable to type 'InstanceDetailsGroupProps'. - Object literal may only specify known properties, and 'fixInstructionProcessor' does not exist in type 'InstanceDetailsGroupProps'. - Upon verifying in UI, fixInstructionProcessor is defined in 'deps' property. So, removed from code. #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: #(#6611) - [ ] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [ ] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [ ] (UI changes only) Added screenshots/GIFs to description above - [ ] (UI changes only) Verified usability with NVDA/JAWS
7 tasks
v-viyada
pushed a commit
that referenced
this pull request
Apr 11, 2024
…atureFlagStoreData,deps,requirementState,outline, (#7292) #### Details As part of Typescript migration added/removed the error causing fields. ##### Motivation TypeScript 5.0 has marked some options as deprecated. We can temporarily override these deprecations, but the documented plan is for the ability to override the flag to go away in TypeScript 5.5 ##### Context 1. **includeStepsText={false}** - **Error:** No overload matches this call.Type '{ needsReviewCardsViewData: CardsViewModel; needsReviewCardSelectionMessageCreator: CardSelectionMessageCreator; automatedChecksCardsViewData: CardsViewModel }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<AssessmentIssuesTestView> & Readonly<AssessmentIssuesTestViewProps> & Readonly<...>' - Property 'includeStepsText' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<AssessmentIssuesTestView> & Readonly<AssessmentIssuesTestViewProps> - In file src/DetailsView/components/default-test-view-container-provider.tsx getting error for includeStepsText. Added the property in reference file. 2. **requirementState={requirementState}** - **Error:** Type '{ deps: AdhocTabStopsTestViewDeps; failureInstanceState: FailureInstanceState; requirementState: TabStopRequirementState; }' is not assignable to type 'IntrinsicAttributes & TabStopsFailedInstancePanelProps & { children?: ReactNode; }'. - Property 'requirementState' does not exist on type 'IntrinsicAttributes & TabStopsFailedInstancePanelProps & { children?: ReactNode; }'. - As per the previous commits, someone removed from the reference interface/type but didn't remove from actual usage. 3. **featureFlagStoreData={featureFlagStoreData}** - **Error:** Type '{ deps: DetailsViewLeftNavDeps; featureFlagStoreData: FeatureFlagStoreData; pivotKey: DetailsViewPivotType; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Switcher> & Readonly<SwitcherProps> & Readonly<...>'. - Property 'featureFlagStoreData' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Switcher> - As per the previous commits, someone removed from the reference interface/type but didn't remove from actual usage. 4. **Deps** - **Error:** Type '{ deps: ReportExportComponentDeps; isOpen: boolean; htmlFileName: string; jsonFileName: string; description: string; htmlExportData: string; jsonExportData: string; ... 9 more ...; exportResultsClickedTelemetry: (reportExportFormat: ReportExportFormat, selectedServiceKey: ReportExportServiceKey, event: MouseEvent<.....' is not assignable to type 'IntrinsicAttributes & ExportDialogProps & { children?: ReactNode; }'. - Property 'deps' does not exist on type 'IntrinsicAttributes & ExportDialogProps & { children?: ReactNode; }'. - As per the previous commits, someone removed from the reference interface/type but didn't remove from actual usage. 5. **outline: '3px dashed'** - **Error:** Type '{ fontColor: string; background: string; text: string; fontWeight: string; fontSize: string; outline: string; }' is not assignable to type 'TextBoxConfig'. - Object literal featureFlagData={featureFlags}may only specify known properties, and 'outline' does not exist in type 'TextBoxConfig'. - As per the previous commits, someone removed from the reference interface/type but didn't remove from actual usage. 6. **featureFlagData={featureFlags}** - **Error:** Type '{ deps: LaunchPanelHeaderDeps; popupWindow: Window; header: this; featureFlagData: FeatureFlagStoreData; }' is not assignable to type 'IntrinsicAttributes & HamburgerMenuButtonProps & { children?: ReactNode; }'. - Property 'featureFlagData' does not exist on type 'IntrinsicAttributes & HamburgerMenuButtonProps & { children?: ReactNode; }'. - As per the previous commits, someone removed from the reference interface/type but didn't remove from actual usage. 7. **isContextMenuVisible** - **Error:** Argument of type '{ target: any; isContextMenuVisible: boolean; }' is not assignable to parameter of type 'LaunchPanelHeaderState | ((prevState: Readonly<LaunchPanelHeaderState>, props: Readonly<LaunchPanelHeaderProps>) => LaunchPanelHeaderState | Pick<...>) | Pick<...>'. - Object literal may only specify known properties, and 'isContextMenuVisible' does not exist in type 'LaunchPanelHeaderState - As per the previous commits, someone removed from the reference interface/type but didn't remove from actual usage. 8. **featureFlagStoreData** - **Error:** Property 'featureFlagStoreData' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<FastPassReportSummary> - As per the previous commits, someone removed from the reference interface/type but didn't remove from actual usage. 9. **deps:null** - **Error:** Argument of type '{ id: string; header: JSX.Element; content: JSX.Element; headingLevel: number; deps: null; }' is not assignable to parameter of type 'ReportCollapsibleContainerProps'. - Object literal may only specify known properties, and 'deps' does not exist in type 'ReportCollapsibleContainerProps'. - As per the previous commits, someone removed from the reference interface/type but didn't remove from actual usage. 10. **testName: 'test-name'** - **Error:** Type '{ key: string; testName: string; rules: string[]; testType: VisualizationType; }' is not assignable to type 'Readonly<Partial<RuleAnalyzerConfiguration>>'. - Object literal may only specify known properties, and 'testName' does not exist in type 'Readonly<Partial<RuleAnalyzerConfiguration>>'. 11. **openGettingStartedDialog** - **Error:** Type '{ deps: LaunchPanelHeaderDeps; title: string; subtitle: string; openGettingStartedDialog: any; openFeedbackDialog: any; popupWindow: Window; featureFlags: FeatureFlagStoreData; openAdhocToolsPanel: () => void; dropdownClickHandler: DropdownClickHandler; }' is not assignable to type 'LaunchPanelHeaderProps'. - Object literal may only specify known properties, and 'openGettingStartedDialog' does not exist in type 'LaunchPanelHeaderProps'. - As per the previous commits, someone removed from the reference interface/type but didn't remove from actual usage. 12. **deps** - **Error:** Type '{ deps: { collapsibleControl: (collapsibleControlProps: ReportCollapsibleContainerProps) => JSX.Element; }; failed: { url: string; numFailures: number; reportLocation: string; }[]; passed: { ...; }[]; unscannable: { ...; }[]; }' is not assignable to type 'SummaryScanResults'. - Object literal may only specify known properties, and 'deps' does not exist in type 'SummaryScanResults'. - As per the previous commits, someone removed from the reference interface/type but didn't remove from actual usage. #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: #[0000](#6611) - [ ] Ran `yarn fastpass` - [ ] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x ] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [ ] (UI changes only) Added screenshots/GIFs to description above - [ ] (UI changes only) Verified usability with NVDA/JAWS --------- Co-authored-by: Prachi Naigaonkar <[email protected]>
v-viyada
referenced
this pull request
Apr 11, 2024
#### Details
As part of Typescript migration added/removed the error causing fields.
##### Motivation
TypeScript 5.0 has marked some options as deprecated. We can temporarily
override these deprecations, but the documented plan is for the ability
to override the flag to go away in TypeScript 5.5
##### Context
1. **featureFlagStoreData**
- **Error:** Type '{ backLinkHandler: () => void;
diagnosticViewToggleFactory: DiagnosticViewToggleFactory;
featureFlagStoreData: FeatureFlagStoreData; }' is not assignable to type
'IntrinsicAttributes & AdHocToolsPanelProps & { children?: ReactNode;
}'.
Property 'featureFlagStoreData' does not exist on type
'IntrinsicAttributes & AdHocToolsPanelProps & { children?: ReactNode;
}'.
2. **avatarUrl: 'avatarUrl'**
- **Error:** Type '{ featureFlagStoreData: { 'test-flag': true; };
avatarUrl: string; tabClosed: boolean; deps: InteractiveHeaderDeps;
selectedPivot: DetailsViewPivotType.assessment; navMenu:
ReactFCWithDisplayName<...>; narrowModeStatus: NarrowModeStatus;
isSideNavOpen: false; setSideNavOpen: null; }' is not assignable to type
'InteractiveHeaderProps'.
- Object literal may only specify known properties, and 'avatarUrl' does
not exist in type 'InteractiveHeaderProps'.
3. **status: ManualTestStatus.FAIL**
- **Error:** Type '{ step: string; test:
VisualizationType.HeadingsAssessment; status: ManualTestStatus;
assessmentInstanceTableHandler: AssessmentInstanceTableHandler;
manualTestStepResultMap: { ...; }; assessmentsProvider:
AssessmentsProvider; featureFlagStoreData: FeatureFlagStoreData;
pathSnippetStoreData: { ...; }; }' is not assignable to type
'ManualTestStepViewProps'.
- Object literal may only specify known properties, and 'status' does
not exist in type 'ManualTestStepViewProps'.
4. **supportLinkHandler: null**
- **Error:** Type '{ deps: LaunchPanelHeaderDeps; title: string;
subtitle: string; supportLinkHandler: null; popupWindow: null;
featureFlags: null; openAdhocToolsPanel: null; dropdownClickHandler:
null; }' is not assignable to type 'LaunchPanelHeaderProps'.
- Object literal may only specify known properties, and
'supportLinkHandler' does not exist in type 'LaunchPanelHeaderProps'.
- In the reference file the supportLinkHandler is removed and
dropdownClickHandler is already defined in LaunchPanelHeaderDeps
5. **browserAdapter: browserAdapterMock.object**
- **Error:** Type '{ diagnosticViewClickHandler:
DiagnosticViewClickHandler; popupViewControllerHandler:
PopupViewControllerHandler; launchPanelHeaderClickHandler:
LaunchPanelHeaderClickHandler; browserAdapter: BrowserAdapter; }' is not
assignable to type 'PopupHandlers'.
- Object literal may only specify known properties, and 'browserAdapter'
does not exist in type 'PopupHandlers'.
6. **targetAppInfo**
- **Error:** Type '{ targetAppInfo: { name: string; url: string; };
description: string; environmentInfo: { browserSpec: string;
extensionVersion: string; axeCoreVersion: string; }; toUtcString: (date:
Date) => string; scanMetadata: ScanMetadata; }' is not assignable to
type 'DetailsSectionProps'.
- Object literal may only specify known properties, and 'targetAppInfo'
does not exist in type 'DetailsSectionProps'.
- Removed 'environmentInfo' property as there are no references defined
in 'DetailsSectionProps' type
7. **outcomeType: outcomeType,**
- **Error:** Type '{ customCongratsContinueInvestigatingMessage: string;
outcomeType: InstanceOutcomeType; }' is not assignable to type
'NoFailedInstancesCongratsDeps'.
- Object literal may only specify known properties, and 'outcomeType'
does not exist in type 'NoFailedInstancesCongratsDeps'.
8. **pageTitle**
- **Error:** Type '{ deps: ResultSectionContentDeps;
fixInstructionProcessor: FixInstructionProcessor; recommendColor:
RecommendColor; ... 13 more ...; sectionHeadingLevel: 3; }' is not
assignable to type 'SectionProps'.
- Object literal may only specify known properties, and 'pageTitle' does
not exist in type 'SectionProps'
- pageUrl,toolData,scanResult doesn't exist in type 'SectionProps'.
Hence removed.
9. **deps:null**
- **Error:** Type '{ [x: string]: string | number | boolean |
JSX.Element; id: string; header: JSX.Element; content: JSX.Element;
headingLevel: number; deps: null; isExpanded: boolean; }' is not
assignable to type 'ReportCollapsibleContainerProps'.
- Object literal may only specify known properties, and 'deps' does not
exist in type 'ReportCollapsibleContainerProps'.
- isExpanded doesn't exist in type 'ReportCollapsibleContainerProps'.
Hence removed.
10. **{ name: 'Any', key: 'any' }**
- **Error :** Type '{ name: string; key: string; }' is not assignable to
type 'IRequirementSubsetForSummary'.
- Object literal may only specify known properties, and 'key' does not
exist in type 'IRequirementSubsetForSummary'.
11. **cardSelectionMessageCreator**
- **Error:** Type '{ serviceName: string; axeVersion: string; userAgent:
string; browserResolution: string; scanDetails: ScanSummaryDetails;
results: CombinedReportResults; cardSelectionMessageCreator:
CardSelectionMessageCreator; }' is not assignable to type
'CombinedReportParameters'.
- Object literal may only specify known properties, and
'cardSelectionMessageCreator' does not exist in type
'CombinedReportParameters'.
#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [x] Addresses an existing issue:
#[[0000](https://github.com/microsoft/accessibility-insights-web/pull/6611)](https://github.com/microsoft/accessibility-insights-web/pull/6611)
- [ ] Ran `yarn fastpass`
- [x] Added/updated relevant unit test(s) (and ran `yarn test`)
- [x] Verified code coverage for the changes made. Check coverage report
at: `<rootDir>/test-results/unit/coverage`
- [ ] PR title *AND* final merge commit title both start with a semantic
tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See
`CONTRIBUTING.md`.
- [ ] (UI changes only) Added screenshots/GIFs to description above
- [ ] (UI changes only) Verified usability with NVDA/JAWS
---------
Co-authored-by: Madalyn <[email protected]>
JeevaniChinthala
added a commit
that referenced
this pull request
May 3, 2024
…a,storeActionMessageCreator,axeResultToIssueFilingDataConverter (#7302) #### Details As part of Typescript migration added/removed the error causing fields. ##### Motivation TypeScript 5.0 has marked some options as deprecated. We can temporarily override these deprecations, but the documented plan is for the ability to override the flag to go away in TypeScript 5.5 ##### Context 1. **urls: urlsConfiguration** - **Error:** Object literal may only specify known properties, and 'urls' does not exist in type 'PropertyIdToConfigurationMap'. - Added urls property. 2. **cardsViewStoreData={this.props.cardsViewStoreData}** - **Error:** Property 'cardsViewStoreData' does not exist on type 'IntrinsicAttributes & CommonInstancesSectionProps - Added cardsViewStoreData in CommonInstancesSectionProps added the property in file [common-instances-section-props.ts] 3. **storeActionMessageCreator** - **Error:** Object literal may only specify known properties, and 'storeActionMessageCreator' does not exist in type 'PageDeps'. - Removed storeActionMessageCreator as there are no references available for the property. 4. **deps:null** - **Error:** Object literal may only specify known properties, and 'deps' does not exist in type 'ReportCollapsibleContainerProps'. - Getting the error in collapsible-result-section.tsx file. - Added deps and onExpandToggle properties in ReportCollapsibleContainerProps in file report-collapsible-container.tsx. 5. **selectedIssueFilingServiceData** - **Error:** Object literal may only specify known properties, but 'selectedIssueFilingServiceData' does not exist in type 'IssueFilingNeedsSettingsContentProps' - This property is used in props in the file [issue-filing-settings-container.tsx] 6. **isMoveToAssessmentDialogOpen** - **Error:** Object literal may only specify known properties, but 'isMoveToAssessmentDialogOpen' does not exist in type 'Readonly<DetailsViewCommandBarState>' - Upon checking previous history and references it is not used anywhere 9. **rel="noopener"** - **Error:** Type '{ children: Element[]; action: string; method: string; target: string; rel: string; style: { visibility: "hidden"; }; }' is not assignable to type 'DetailedHTMLProps<FormHTMLAttributes<HTMLFormElement>, HTMLFormElement>'. 10. **value** - **Error:** Type '{ value: boolean; label: string; onChange: (event: MouseEvent<any, MouseEvent>, checked?: boolean) => void; }' is not assignable to type 'IntrinsicAttributes & ICheckboxProps & { children?: ReactNode; }'. 11. **isLableVisisble** - **Error:** Property 'isLabelVisible' does not exist on type 'IntrinsicAttributes & IChoiceGroupProps & { children?: ReactNode; }'. #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: #(#6611) - [ ] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [ ] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [ ] (UI changes only) Added screenshots/GIFs to description above - [ ] (UI changes only) Verified usability with NVDA/JAWS
JeevaniChinthala
added a commit
that referenced
this pull request
May 9, 2024
#### Details Typescript Cleanup Part 3 of 3 **Covering 80 errors in 40 files in this PR** ##### Motivation **SUBPART 1:** 1. src/tests/unit/tests/common/configs/web-visualization-configuration-factory.test.ts (4) 2. src/tests/unit/tests/DetailsView/actions/assessment-action-message-creator.test.ts (4) 3. src/tests/unit/tests/DetailsView/components/assessment-issues-test-view.test.tsx (6) 4. src/tests/unit/tests/DetailsView/components/test-view-container.test.tsx (1) 5. src/tests/unit/tests/DetailsView/details-view-body.test.tsx (1) 6. src/tests/unit/tests/DetailsView/details-view-content.test.tsx (3) 7. src/tests/unit/tests/DetailsView/document-title-updater.test.ts (1) 8. src/tests/unit/tests/DetailsView/handlers/get-document-title.test.ts (2) 9. src/tests/unit/tests/DetailsView/components/left-nav/details-view-left-nav.test.tsx (1) 10. src/tests/unit/tests/DetailsView/components/next-requirement-button.test.tsx (1) 11. src/tests/unit/tests/DetailsView/components/scan-incomplete-warning.test.tsx (1) Number of errors covered as part of this user story: **25** **SUBPART 2:** Merged PR2 which had these files fixed: v-prachin#1 1. src/tests/unit/tests/injected/analyzer-state-update-handler.test.ts (5) 2. src/tests/unit/tests/injected/analyzers/analyzer-provider.test.ts (1) 3. src/tests/unit/tests/injected/analyzers/tab-stops-analyzer.test.ts (1) 4. src/tests/unit/tests/injected/selector-map-helper.test.ts (4) 5. src/tests/unit/tests/injected/target-page-visualization-updater.test.ts (1) 6. src/tests/unit/tests/injected/visualization-state-change-handler.test.ts (2) 7. src/tests/unit/tests/injected/visualization-type-drawer-registrar.test.ts (1) 8. src/tests/unit/tests/popup/components/diagnostic-view-toggle-factory.test.tsx (8) 9. src/tests/unit/tests/background/stores/visualization-scan-result-store.test.ts (2) Number of errors covered as part of this user story: **25** **SUBPART 3:** 1. src/tests/unit/tests/DetailsView/components/adhoc-static-test-view.test.tsx (1) 2. src/tests/unit/tests/DetailsView/components/adhoc-tab-stops-test-view.test.tsx (1) 3. src/tests/unit/tests/DetailsView/components/iframe-warning.test.tsx (2) 4. src/tests/unit/tests/DetailsView/components/issues-table.test.tsx (1) 5. src/tests/unit/tests/DetailsView/details-view-container.test.tsx (2) 6. src/tests/unit/tests/injected/adapters/resolution-creator.test.ts (1) 7. src/tests/unit/tests/reports/package/axe-results-report.test.ts (1) 8. src/tests/unit/tests/background/target-tab-controller.test.ts (1) 9. src/tests/unit/tests/background/stores/persistent-store.test.ts (1) 10. src/tests/unit/tests/DetailsView/components/adhoc-issues-test-view.test.tsx(1) 11. src/tests/unit/tests/background/initial-visualization-store-data-generator.test.ts (2) 12. src/tests/unit/tests/reports/components/inline-image.test.tsx (1) 13. src/tests/unit/tests/common/message-creators/assessment-card-selection-message-creator.test.ts 14. src/tests/unit/tests/common/message-creators/card-selection-message-creator.test.ts 15. src/tests/unit/tests/common/message-creators/needs-review-card-selection-message-creator.test.ts 16. src/tests/unit/tests/common/notification-creator.test.ts 17. src/tests/unit/tests/common/telemetry-data-factory.test.ts 18. src/tests/unit/tests/DetailsView/actions/details-view-action-message-creator.test.ts 19. src/tests/unit/tests/DetailsView/actions/tab-stop-requirement-action-message-creator.test.ts 20. src/tests/unit/tests/DetailsView/components/left-nav/visualization-based-left-nav.test.tsx Number of errors covered as part of this user story: **30** **Total Number of errors covered as part of this user story: **80**** - src/common/components/cards/instance-details-group.tsx - src/DetailsView/details-view-initializer.ts Due to typescript changes the style of the snapshot file got re-arranged. So updated the snapshot files. ##### Context #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: #(#6611) - [x] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [n/a] (UI changes only) Added screenshots/GIFs to description above - [n/a] (UI changes only) Verified usability with NVDA/JAWS --------- Co-authored-by: Jeevani Chinthala <[email protected]> Co-authored-by: Vikash Yadav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Determine the expected impact of removing deprecated TypeScript options. This will not be merged