Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech Debt]: TypeScript properties are being deprecated #6612

Closed
DaveTryon opened this issue May 3, 2023 · 3 comments
Closed

[Tech Debt]: TypeScript properties are being deprecated #6612

DaveTryon opened this issue May 3, 2023 · 3 comments
Labels
added to backlog This issue has been added to our internal backlog and will be closed automatically. category: engineering

Comments

@DaveTryon
Copy link
Contributor

DaveTryon commented May 3, 2023

Describe the bug

We have some tech debt to pay down. Our tsconfig.base.json file includes the following options:

        "suppressExcessPropertyErrors": true,
        "noImplicitUseStrict": false,
        "noStrictGenericChecks": false,

As called out at https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#deprecations-and-default-changes, these properties are all being deprecated. We can override this change until TypeScript 5.5, but we need to create a plan to prepare for this.

I removed these lines from the current main build, and opened it as #6611. It identifies 148 instances of failure, about 100 of which are unique. The naïve approach is to just add each missing property, but from what I've seen, a better option for some of these is probably to remove the property because it's not being used anywhere. We need to take some time to work through these on a case-by-case basis.

@DaveTryon DaveTryon added bug Something isn't working category: engineering labels May 3, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the status: new This issue is new and requires triage by DRI. label May 3, 2023
@DaveTryon DaveTryon added the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label May 3, 2023
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@microsoft-github-policy-service microsoft-github-policy-service bot removed the status: new This issue is new and requires triage by DRI. label May 3, 2023
@DaveTryon DaveTryon added status: blocked This issue is blocked. and removed status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. labels May 4, 2023
@DaveTryon
Copy link
Contributor Author

Created feature https://dev.azure.com/mseng/1ES/_workitems/edit/2062838 to track this work. Moving this to blocked until that feature gets onto the schedule.

@DaveTryon DaveTryon removed the bug Something isn't working label May 24, 2023
@DaveTryon DaveTryon moved this from Needs Triage to Old backlog in Accessibility Insights Jun 28, 2023
@DaveTryon DaveTryon added added to backlog This issue has been added to our internal backlog and will be closed automatically. and removed status: blocked This issue is blocked. labels Jun 29, 2023
@DaveTryon
Copy link
Contributor Author

Feature 2062838 tracks this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to backlog This issue has been added to our internal backlog and will be closed automatically. category: engineering
Projects
None yet
Development

No branches or pull requests

2 participants