Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove suppression that bugs TypeScript 5 #6607

Closed
wants to merge 4 commits into from
Closed

chore: Remove suppression that bugs TypeScript 5 #6607

wants to merge 4 commits into from

Conversation

DaveTryon
Copy link
Contributor

Details

TypeScript 5 deprecates the suppressExcessPropertyErrors flag. This is just a test to assess if it changes anything in our current code base.

Motivation
Context

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@DaveTryon DaveTryon added the pr: DO NOT MERGE Dont merge this PR. label May 3, 2023
@DaveTryon DaveTryon requested a review from a team as a code owner May 3, 2023 02:37
@DaveTryon
Copy link
Contributor Author

Replaced by #6611

@DaveTryon DaveTryon closed this May 4, 2023
@DaveTryon DaveTryon deleted the test-remove-suppression branch September 26, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: DO NOT MERGE Dont merge this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DaveTryon