Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Typescript Cleanup- Part 5 for Errors - urls,cardsViewStoreData,storeActionMessageCreator,axeResultToIssueFilingDataConverter #7302

Merged
merged 22 commits into from
May 3, 2024

Conversation

JeevaniChinthala
Copy link
Contributor

@JeevaniChinthala JeevaniChinthala commented Apr 10, 2024

Details

As part of Typescript migration added/removed the error causing fields.

Motivation

TypeScript 5.0 has marked some options as deprecated. We can temporarily override these deprecations, but the documented plan is for the ability to override the flag to go away in TypeScript 5.5

Context
  1. urls: urlsConfiguration
  • Error: Object literal may only specify known properties, and 'urls' does not exist in type 'PropertyIdToConfigurationMap'.
  • Added urls property.
  1. cardsViewStoreData={this.props.cardsViewStoreData}
  • Error: Property 'cardsViewStoreData' does not exist on type 'IntrinsicAttributes & CommonInstancesSectionProps
  • Added cardsViewStoreData in CommonInstancesSectionProps added the property in file [common-instances-section-props.ts]
  1. storeActionMessageCreator
  • Error: Object literal may only specify known properties, and 'storeActionMessageCreator' does not exist in type 'PageDeps'.
  • Removed storeActionMessageCreator as there are no references available for the property.
  1. deps:null
  • Error: Object literal may only specify known properties, and 'deps' does not exist in type 'ReportCollapsibleContainerProps'.
  • Getting the error in collapsible-result-section.tsx file.
  • Added deps and onExpandToggle properties in ReportCollapsibleContainerProps in file report-collapsible-container.tsx.
  1. selectedIssueFilingServiceData
  • Error: Object literal may only specify known properties, but 'selectedIssueFilingServiceData' does not exist in type 'IssueFilingNeedsSettingsContentProps'
  • This property is used in props in the file [issue-filing-settings-container.tsx]
  1. isMoveToAssessmentDialogOpen
  • Error: Object literal may only specify known properties, but 'isMoveToAssessmentDialogOpen' does not exist in type 'Readonly'
  • Upon checking previous history and references it is not used anywhere
  1. rel="noopener"
  • Error: Type '{ children: Element[]; action: string; method: string; target: string; rel: string; style: { visibility: "hidden"; }; }' is not assignable to type 'DetailedHTMLProps<FormHTMLAttributes, HTMLFormElement>'.
  1. value
  • Error: Type '{ value: boolean; label: string; onChange: (event: MouseEvent<any, MouseEvent>, checked?: boolean) => void; }' is not assignable to type 'IntrinsicAttributes & ICheckboxProps & { children?: ReactNode; }'.
  1. isLableVisisble
  • Error: Property 'isLabelVisible' does not exist on type 'IntrinsicAttributes & IChoiceGroupProps & { children?: ReactNode; }'.

Pull request checklist

  • Addresses an existing issue: #(chore: Remove deprecated TypeScript options #6611)
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@JeevaniChinthala JeevaniChinthala changed the title chore: Typescript Cleanup- Part 5 for Errors - urls,cardsViewStoreData,storeActionMessageCreator,browserSpec chore: Typescript Cleanup- Part 5 for Errors - urls,cardsViewStoreData,storeActionMessageCreator,axeResultToIssueFilingDataConverter Apr 12, 2024
src/DetailsView/details-view-initializer.ts Outdated Show resolved Hide resolved
src/DetailsView/details-view-initializer.ts Outdated Show resolved Hide resolved
src/DetailsView/details-view-initializer.ts Outdated Show resolved Hide resolved
@JeevaniChinthala JeevaniChinthala marked this pull request as ready for review April 19, 2024 15:12
@JeevaniChinthala JeevaniChinthala requested a review from a team as a code owner April 19, 2024 15:12
@JeevaniChinthala JeevaniChinthala merged commit f850ff1 into main May 3, 2024
12 checks passed
@JeevaniChinthala JeevaniChinthala deleted the users/v-jeevanic/TypeScriptFeatureV5 branch May 23, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants