-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Typescript Cleanup- Part 5 for Errors - urls,cardsViewStoreData,storeActionMessageCreator,axeResultToIssueFilingDataConverter #7302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-rakeshsh
reviewed
Apr 11, 2024
src/DetailsView/components/tab-stops/tab-stops-instance-section-props-factory.tsx
Show resolved
Hide resolved
JeevaniChinthala
changed the title
chore: Typescript Cleanup- Part 5 for Errors - urls,cardsViewStoreData,storeActionMessageCreator,browserSpec
chore: Typescript Cleanup- Part 5 for Errors - urls,cardsViewStoreData,storeActionMessageCreator,axeResultToIssueFilingDataConverter
Apr 12, 2024
v-viyada
reviewed
Apr 18, 2024
madalynrose
requested changes
May 1, 2024
src/reports/components/report-sections/report-collapsible-container.tsx
Outdated
Show resolved
Hide resolved
madalynrose
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
As part of Typescript migration added/removed the error causing fields.
Motivation
TypeScript 5.0 has marked some options as deprecated. We can temporarily override these deprecations, but the documented plan is for the ability to override the flag to go away in TypeScript 5.5
Context
Pull request checklist
yarn fastpass
yarn test
)<rootDir>/test-results/unit/coverage
fix:
,chore:
,feat(feature-name):
,refactor:
). SeeCONTRIBUTING.md
.