chore: Typescript Cleanup- Part 5 for Errors - urls,cardsViewStoreData,storeActionMessageCreator,axeResultToIssueFilingDataConverter

src/DetailsView/components/choice-group-pass-fail.tsx

@@ -55,7 +55,6 @@ export class ChoiceGroupPassFail extends React.Component<ChoiceGroupPassFailProp
                     onChange={this.props.onChange}
                     selectedKey={this.props.selectedKey}
                     options={this.props.options.map(this.makeOptions)}
-                    isLabelVisible={this.props.isLabelVisible}
                     data-automation-id={this.props['data-automation-id']}
                 />
                 <div className={styles.secondaryControlsWrapper}>

src/DetailsView/components/details-view-command-bar.tsx

@@ -123,7 +123,6 @@ export class DetailsViewCommandBar extends React.Component<
             isInvalidLoadAssessmentDialogOpen: false,
             isLoadAssessmentDialogOpen: false,
             isReportExportDialogOpen: false,
-            isMoveToAssessmentDialogOpen: false,
             loadedAssessmentData: {} as VersionedAssessmentData,
             startOverDialogState: 'none',
         };

src/DetailsView/components/issue-filing-dialog.tsx

@@ -9,7 +9,10 @@ import * as React from 'react';
 import { IssueFilingActionMessageCreator } from '../../common/message-creators/issue-filing-action-message-creator';
 import { UserConfigMessageCreator } from '../../common/message-creators/user-config-message-creator';
 import { CreateIssueDetailsTextData } from '../../common/types/create-issue-details-text-data';
-import { IssueFilingServicePropertiesMap } from '../../common/types/store-data/user-configuration-store';
+import {
+    IssueFilingServiceProperties,
+    IssueFilingServicePropertiesMap,
+} from '../../common/types/store-data/user-configuration-store';
 import {
     IssueFilingSettingsContainer,
     IssueFilingSettingsContainerDeps,
@@ -25,6 +28,7 @@ export interface IssueFilingDialogProps {
     isOpen: boolean;
     selectedIssueFilingService: IssueFilingService;
     selectedIssueData?: CreateIssueDetailsTextData;
+    selectedIssueFilingServiceData: IssueFilingServiceProperties;
     issueFilingServicePropertiesMap: IssueFilingServicePropertiesMap;
     onClose: (ev?: React.SyntheticEvent) => void;
     afterClosed?: () => void;

src/DetailsView/components/save-assessment-button.tsx

@@ -74,9 +74,6 @@ export const SaveAssessmentButton = NamedFC<SaveAssessmentButtonProps>(
                         >
                             <Stack.Item grow disableShrink>
                                 <Checkbox
-                                    value={
-                                        !props.userConfigurationStoreData.showSaveAssessmentDialog
-                                    }
                                     label="Don't show again"
                                     onChange={handleDontShowAgainClick}
                                 />

src/DetailsView/components/tab-stops/tab-stops-instance-section-props-factory.tsx

@@ -153,7 +153,6 @@ export const ReportTabStopsInstanceSectionPropsFactory: TabStopsInstanceSectionP
                 content: (
                     <TabStopsReportInstanceList
                         key={`${result.id}-requirement-group`}
-                        requirementId={result.id}
                         instances={instances}
                     />
                 ),

src/common/components/cards/common-instances-section-props.ts

@@ -6,6 +6,7 @@ import { ScanMetadata } from 'common/types/store-data/unified-data-interface';
 import { NarrowModeStatus } from 'DetailsView/components/narrow-mode-detector';
 import { CardsViewModel } from '../../types/store-data/card-view-model';
 import { UserConfigurationStoreData } from '../../types/store-data/user-configuration-store';
+import { CardsViewStoreData } from './cards-view-store-data';
 import { ResultSectionDeps } from './result-section';
 
 export type CommonInstancesSectionDeps = ResultSectionDeps;
@@ -18,4 +19,5 @@ export type CommonInstancesSectionProps = {
     cardSelectionMessageCreator?: CardSelectionMessageCreator;
     sectionHeadingLevel: HeadingLevel;
     narrowModeStatus?: NarrowModeStatus;
+    cardsViewStoreData?: CardsViewStoreData;
 };

src/common/components/visualization-toggle.tsx

@@ -30,7 +30,7 @@ export class VisualizationToggle extends React.Component<VisualizationToggleProp
             componentRef: this.props.componentRef,
             onBlur: this.props.onBlur,
             onFocus: this.props.onFocus,
-            'data-automation-id': this.props['data-automation-id'],
+            ...{ 'data-automation-id': this.props['data-automation-id'] },
         };
 
         return <Toggle {...props} />;

src/common/configs/unified-result-property-configurations.tsx

@@ -22,6 +22,7 @@ export const AllPropertyTypes = [
     'className',
     'contentDescription',
     'text',
+    'urls',
     'relatedCssSelectors',
 ] as const;
 export type PropertyType = (typeof AllPropertyTypes)[number];

src/injected/analyzers/analyzer.ts

@@ -31,6 +31,10 @@ export interface ScanUpdatePayload extends ScanBasePayload {
     results: TabStopEvent[];
 }
 
+export interface TabStopScanUpdatePayload extends ScanUpdatePayload {
+    tabbedElements: TabStopEvent[];
+}
+
 export interface ScanBasePayload extends BaseActionPayload {
     testType: VisualizationType;
     key: string;

src/injected/analyzers/tab-stops-analyzer.ts

@@ -9,7 +9,7 @@ import { TabStopsDoneAnalyzingTracker } from 'injected/analyzers/tab-stops-done-
 import { TabStopsRequirementResultProcessor } from 'injected/analyzers/tab-stops-requirement-result-processor';
 import { ScanIncompleteWarningDetector } from 'injected/scan-incomplete-warning-detector';
 import { debounce, DebouncedFunc } from 'lodash';
-import { FocusAnalyzerConfiguration, ScanBasePayload, ScanUpdatePayload } from './analyzer';
+import { FocusAnalyzerConfiguration, ScanBasePayload, TabStopScanUpdatePayload } from './analyzer';
 
 export interface ProgressResult<T> {
     result: T;
@@ -55,7 +55,7 @@ export class TabStopsAnalyzer extends BaseAnalyzer {
         const results = this.pendingTabbedElements;
         this.pendingTabbedElements = [];
 
-        const payload: ScanUpdatePayload = {
+        const payload: TabStopScanUpdatePayload = {
             key: this.config.key,
             testType: this.config.testType,
             tabbedElements: results,

src/packages/accessibility-insights-ui/ui-factory.tsx

@@ -32,9 +32,6 @@ export const contentViewFactory = ({ applicationTitle, getNarrowModeThresholds }
         textContent: {
             applicationTitle,
         },
-        storeActionMessageCreator: {
-            getAllStates: nullCreator,
-        },
         storesHub: nullStoresHub,
         getNarrowModeThresholds,
     };

src/report-export/services/code-pen-report-export-service.tsx

@@ -31,7 +31,6 @@ class CodePenExportForm extends React.Component<ReportExportFormProps> {
                 action="https://codepen.io/pen/define"
                 method="POST"
                 target="_blank"
-                rel="noopener"
                 style={{ visibility: 'hidden' }}
             >
                 <input

src/reports/components/report-sections/collapsible-result-section.tsx

@@ -36,7 +36,6 @@ export const CollapsibleResultSection = NamedFC<CollapsibleResultSectionProps>(
             header: <ResultSectionTitle {...props} titleSize="title" />,
             content: <RulesOnly {...props} />,
             headingLevel: props.headingLevel,
-            deps: null,
             testKey,
             onExpandToggle: (event: React.MouseEvent<HTMLDivElement>) => {
                 cardSelectionMessageCreator?.toggleRuleExpandCollapse(containerId, event);

src/reports/components/report-sections/collapsible-url-result-section.tsx

@@ -28,6 +28,7 @@ export const CollapsibleUrlResultSection = NamedFC<CollapsibleUrlResultSectionPr
             header: <ResultSectionTitle {...props} titleSize="heading" />,
             content,
             headingLevel: 3,
+            onExpandToggle: (event: React.MouseEvent<HTMLDivElement>) => {},
         });
 
         return <div className={styles.urlResultSection}>{CollapsibleContent}</div>;

src/reports/components/report-sections/report-collapsible-container.tsx

@@ -14,6 +14,7 @@ export interface ReportCollapsibleContainerProps {
     containerClassName?: string;
     buttonAriaLabel?: string;
     testKey?: string;
+    onExpandToggle: (event: React.MouseEvent<HTMLDivElement>) => void;
 }
 
 const ReportCollapsibleContainer = NamedFC<ReportCollapsibleContainerProps>(

src/tests/unit/tests/DetailsView/components/__snapshots__/choice-group-pass-fail.test.tsx.snap

@@ -6,7 +6,6 @@ exports[`ChoiceGroupPassFail render 1`] = `
     class="choiceGroupContainer"
   >
     <mock-styledchoicegroup
-      islabelvisible="false"
       options="[object Object],[object Object],[object Object]"
       selectedkey="unknown"
       styles="[object Object]"
@@ -29,7 +28,6 @@ exports[`ChoiceGroupPassFail render: selectedKey is set to FAIL 1`] = `
     class="choiceGroupContainer"
   >
     <mock-styledchoicegroup
-      islabelvisible="false"
       options="[object Object],[object Object],[object Object]"
       selectedkey="fail"
       styles="[object Object]"
@@ -64,7 +62,6 @@ exports[`ChoiceGroupPassFail render: selectedKey is set to FAIL: StyledChoiceGro
 {
   "componentRef": [Function],
   "data-automation-id": undefined,
-  "isLabelVisible": false,
   "onChange": [Function],
   "options": [
     {
@@ -111,7 +108,6 @@ exports[`ChoiceGroupPassFail render: selectedKey is set to PASS 1`] = `
     class="choiceGroupContainer"
   >
     <mock-styledchoicegroup
-      islabelvisible="false"
       options="[object Object],[object Object],[object Object]"
       selectedkey="pass"
       styles="[object Object]"
@@ -146,7 +142,6 @@ exports[`ChoiceGroupPassFail render: selectedKey is set to PASS: StyledChoiceGro
 {
   "componentRef": [Function],
   "data-automation-id": undefined,
-  "isLabelVisible": false,
   "onChange": [Function],
   "options": [
     {

src/tests/unit/tests/DetailsView/components/__snapshots__/save-assessment-button.test.tsx.snap

@@ -37,7 +37,6 @@ exports[`SaveAssessmentButton on dialog enabled render snapshot of dialog 1`] =
         >
           <mock-styledcheckboxbase
             label="Don't show again"
-            value="false"
           />
         </mock-stackitem>
         <mock-stackitem

src/tests/unit/tests/DetailsView/components/issue-filing-dialog.test.tsx

@@ -8,7 +8,10 @@ import { IMock, It, Mock, MockBehavior, Times } from 'typemoq';
 import { IssueFilingActionMessageCreator } from '../../../../../common/message-creators/issue-filing-action-message-creator';
 import { UserConfigMessageCreator } from '../../../../../common/message-creators/user-config-message-creator';
 import { CreateIssueDetailsTextData } from '../../../../../common/types/create-issue-details-text-data';
-import { IssueFilingServicePropertiesMap } from '../../../../../common/types/store-data/user-configuration-store';
+import {
+    IssueFilingServiceProperties,
+    IssueFilingServicePropertiesMap,
+} from '../../../../../common/types/store-data/user-configuration-store';
 import { ActionAndCancelButtonsComponent } from '../../../../../DetailsView/components/action-and-cancel-buttons-component';
 import {
     IssueFilingDialog,
@@ -93,12 +96,16 @@ describe('IssueFilingDialog', () => {
             getSettingsFromStoreData: getSettingsFromStoreDataMock.object,
             key: serviceKey,
         } as IssueFilingService;
+        const selectedIssueFilingServiceData: IssueFilingServiceProperties = {
+            repository: 'none',
+        };
         props = {
             deps,
             isOpen: true,
             onClose: onCloseMock.object,
             selectedIssueFilingService: issueFilingServiceStub,
             selectedIssueData: selectedIssueDataStub,
+            selectedIssueFilingServiceData,
             issueFilingServicePropertiesMap: issueFilingServicePropertiesMapStub,
             afterClosed: () => null,
         };

src/tests/unit/tests/DetailsView/components/tab-stops/__snapshots__/tab-stops-choice-group.test.tsx.snap

@@ -7,7 +7,6 @@ exports[`TabStopsChoiceGroup render with fail status 1`] = `
   >
     <mock-styledchoicegroup
       data-automation-id="tabStopsPassFailChoiceGroup"
-      islabelvisible="false"
       options="[object Object],[object Object]"
       selectedkey="fail"
       styles="[object Object]"
@@ -43,7 +42,6 @@ exports[`TabStopsChoiceGroup render with fail status: StyledChoiceGroup props 1`
 {
   "componentRef": [Function],
   "data-automation-id": "tabStopsPassFailChoiceGroup",
-  "isLabelVisible": false,
   "onChange": [Function],
   "options": [
     {
@@ -81,7 +79,6 @@ exports[`TabStopsChoiceGroup render with pass status 1`] = `
   >
     <mock-styledchoicegroup
       data-automation-id="tabStopsPassFailChoiceGroup"
-      islabelvisible="false"
       options="[object Object],[object Object]"
       selectedkey="pass"
       styles="[object Object]"
@@ -102,7 +99,6 @@ exports[`TabStopsChoiceGroup render with pass status: StyledChoiceGroup props 1`
 {
   "componentRef": [Function],
   "data-automation-id": "tabStopsPassFailChoiceGroup",
-  "isLabelVisible": false,
   "onChange": [Function],
   "options": [
     {
@@ -140,7 +136,6 @@ exports[`TabStopsChoiceGroup render with unknown status 1`] = `
   >
     <mock-styledchoicegroup
       data-automation-id="tabStopsPassFailChoiceGroup"
-      islabelvisible="false"
       options="[object Object],[object Object]"
       selectedkey="unknown"
       styles="[object Object]"
@@ -156,7 +151,6 @@ exports[`TabStopsChoiceGroup render with unknown status: StyledChoiceGroup props
 {
   "componentRef": [Function],
   "data-automation-id": "tabStopsPassFailChoiceGroup",
-  "isLabelVisible": false,
   "onChange": [Function],
   "options": [
     {

src/tests/unit/tests/DetailsView/components/tab-stops/__snapshots__/tab-stops-instance-section-props-factory.test.tsx.snap

@@ -209,7 +209,6 @@ exports[`TabStopsInstanceSectionPropsFactory for Report creates props as expecte
         },
       ]
     }
-    requirementId="keyboard-navigation"
   />,
   "deps": {
     "tabStopRequirementActionMessageCreator": [typemoq mock object],

src/tests/unit/tests/packages/accessibility-insights-ui/__snapshots__/ui-factory.test.tsx.snap

@@ -15,9 +15,6 @@ exports[`UIFactory exports ContentView: Content props 1`] = `
   "children": "CONTENTS",
   "deps": {
     "getNarrowModeThresholds": [Function],
-    "storeActionMessageCreator": {
-      "getAllStates": [Function],
-    },
     "storesHub": {
       "addChangedListenerToAllStores": [Function],
       "getAllStoreData": [Function],

src/tests/unit/tests/report-export/__snapshots__/code-pen-report-export-service.test.tsx.snap

@@ -5,7 +5,6 @@ exports[`CodePenReportExportService exportForm renders 1`] = `
   <form
     action="https://codepen.io/pen/define"
     method="POST"
-    rel="noopener"
     style="visibility: hidden;"
     target="_blank"
   >

src/tests/unit/tests/reports/components/report-sections/report-collapsible-container.test.tsx

@@ -3,6 +3,7 @@
 import { render } from '@testing-library/react';
 import { forOwn } from 'lodash';
 import * as React from 'react';
+import { Mock } from 'typemoq';
 
 import { HeadingElementForLevel } from '../../../../../../common/components/heading-element-for-level';
 import {
@@ -20,7 +21,7 @@ describe('ReportCollapsibleContainerControl', () => {
         buttonAriaLabel: [undefined, 'some button label'],
         id: [undefined, 'some id'],
     };
-
+    const onExpandToggleMock = Mock.ofType<(event: React.MouseEvent<HTMLDivElement>) => void>();
     forOwn(optionalPropertiesObject, (propertyValues, propertyName) => {
         propertyValues.forEach(value => {
             test(`render with ${propertyName} set to: ${value}`, () => {
@@ -30,6 +31,7 @@ describe('ReportCollapsibleContainerControl', () => {
                     content: <div>Some content</div>,
                     headingLevel: 5,
                     [propertyName]: value,
+                    onExpandToggle: onExpandToggleMock.object,
                 };
                 const control = ReportCollapsibleContainerControl(props);
                 const renderResult = render(control);