chore: cleaning up old left nav components #3163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
v-prachin
added a commit
that referenced
this pull request
Apr 1, 2024
…ementLink, leftNavLinkBuilder & height:0 (#7276) #### Details Typescript Cleanup Part 2 of 3 We have total 140 errors in 104 files. Thus, targeting each error and fixing it. ##### Motivation Errors observed in below files observed after removing deprecated properties from tsconfig file: 1 **renderRequirementDescription: requirementLink =>** src/assessments/automated-checks/build-test-steps-from-rules.tsx No. Of Error: 1 Removed this property based on this PR: #3163 2.**selector: selector** src/background/assessment-data-converter.ts No. Of Error: 1 Added the property in the interface 3.**selector: selectorStub** src/tests/unit/tests/background/assessment-data-converter.test.ts No. Of Error: 3 Added the property in the interface 4.**isEnabled: true** src/assessments/cognitive/assessment src/assessments/headings/assessment.tsx src/assessments/parsing/assessment.tsx No. Of Error: 3 Added the property in the interface. 5.**leftNavLinkBuilder: leftNavLinkBuilderMock.object** src/tests/unit/tests/DetailsView/components/left-nav/assessment-left-nav.test.tsx No. Of Error: 1 6.**leftNavLinkBuilder: leftNavLinkBuilderMock.object** src/tests/unit/tests/DetailsView/components/left-nav/quick-assess-left-nav.test.tsx No. Of Error: 1 7.**leftNavLinkBuilder: leftNavLinkBuilderMock.object** src/tests/unit/tests/DetailsView/components/left-nav/visualization-based-left-nav.test.tsx No. Of Error: 1 8.**height: 0** src/tests/unit/tests/DetailsView/components/narrow-mode-detector.test.tsx No. Of Error: 1 This property is not present in the main file, thus removed it from the test file. Thus, total number of errors covered as part of this user story: **12** ##### Context #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: #(#6611) - [x] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [n/a] (UI changes only) Added screenshots/GIFs to description above - [n/a] (UI changes only) Verified usability with NVDA/JAWS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This removes the components that are no longer being used as a result of the work in reflow work.
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.