chore: Typescript Cleanup Part 2 of 3 for selector, isEnabled, requir…

…ementLink, leftNavLinkBuilder & height:0 (#7276)

#### Details

Typescript Cleanup Part 2 of 3 
We have total 140 errors in 104 files. Thus, targeting each error and
fixing it.

##### Motivation

Errors observed in below files observed after removing deprecated
properties from tsconfig file:

1 **renderRequirementDescription: requirementLink =>**	
src/assessments/automated-checks/build-test-steps-from-rules.tsx
No. Of Error: 1
Removed this property based on this PR:
#3163

2.**selector: selector**	
src/background/assessment-data-converter.ts
No. Of Error: 1
Added the property in the interface

3.**selector: selectorStub**	
src/tests/unit/tests/background/assessment-data-converter.test.ts
No. Of Error: 3
Added the property in the interface
		
4.**isEnabled: true**	
src/assessments/cognitive/assessment
src/assessments/headings/assessment.tsx
src/assessments/parsing/assessment.tsx
No. Of Error: 3
Added the property in the interface.

5.**leftNavLinkBuilder: leftNavLinkBuilderMock.object**	

src/tests/unit/tests/DetailsView/components/left-nav/assessment-left-nav.test.tsx
No. Of Error: 1

6.**leftNavLinkBuilder: leftNavLinkBuilderMock.object**	

src/tests/unit/tests/DetailsView/components/left-nav/quick-assess-left-nav.test.tsx
No. Of Error: 1

7.**leftNavLinkBuilder: leftNavLinkBuilderMock.object**	

src/tests/unit/tests/DetailsView/components/left-nav/visualization-based-left-nav.test.tsx
No. Of Error: 1

8.**height: 0**	

src/tests/unit/tests/DetailsView/components/narrow-mode-detector.test.tsx
No. Of Error: 1
This property is not present in the main file, thus removed it from the
test file.

Thus, total number of errors covered as part of this user story: **12**


##### Context

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [x] Addresses an existing issue:
#(#6611)
- [x] Ran `yarn fastpass`
- [x] Added/updated relevant unit test(s) (and ran `yarn test`)
- [x] Verified code coverage for the changes made. Check coverage report
at: `<rootDir>/test-results/unit/coverage`
- [x] PR title *AND* final merge commit title both start with a semantic
tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See
`CONTRIBUTING.md`.
- [n/a] (UI changes only) Added screenshots/GIFs to description above
- [n/a] (UI changes only) Verified usability with NVDA/JAWS

src/assessments/automated-checks/build-test-steps-from-rules.tsx

@@ -52,8 +52,6 @@ function buildAutomatedCheckStep(rule: ScannerRuleInfo): Requirement {
         getInstanceStatus: getInstanceStatus,
         getInstanceStatusColumns: () => [],
         instanceTableHeaderType: 'none',
-        renderRequirementDescription: requirementLink =>
-            requirementLink.renderRequirementDescriptionWithoutIndex(),
         getDefaultMessage: defaultMessageGenerator =>
             defaultMessageGenerator.getNoFailingInstanceMessage,
         getVisualHelperToggle: props => <AutomatedChecksVisualizationToggle {...props} />,

src/assessments/types/iassessment.ts

@@ -23,6 +23,7 @@ interface BaseAssessment {
     extensions?: AnyExtension[];
     initialDataCreator?: InitialDataCreator;
     isNonCollapsible?: boolean;
+    isEnabled?: boolean;
 }
 
 export interface ManualAssessment extends BaseAssessment {}

src/common/types/store-data/assessment-result-data.ts

@@ -55,6 +55,7 @@ export interface GeneratedAssessmentInstance<T = {}, K = {}> {
     html: string;
     testStepResults: AssessmentResultType<K>;
     propertyBag?: T;
+    selector?: string;
 }
 
 export interface TestStepResult {

src/tests/unit/tests/DetailsView/components/left-nav/assessment-left-nav.test.tsx

@@ -65,15 +65,12 @@ describe(AssessmentLeftNav.displayName, () => {
         props = {
             deps,
             selectedKey: 'some key',
-            leftNavLinkBuilder: leftNavLinkBuilderMock.object,
             assessmentsProvider: assessmentsProviderStub,
             assessmentsData: assessmentsDataStub,
             featureFlagStoreData: {},
             expandedTest,
             onRightPanelContentSwitch,
             setNavComponentRef,
-            getAssessmentSummaryModelFromProviderAndStatusData:
-                getAssessmentSummaryModelFromProviderAndStatusDataMock.object,
         };
 
         leftNavLinkBuilderMock

src/tests/unit/tests/DetailsView/components/left-nav/quick-assess-left-nav.test.tsx

@@ -71,7 +71,6 @@ describe(QuickAssessLeftNav.displayName, () => {
         props = {
             deps,
             selectedKey: 'some key',
-            leftNavLinkBuilder: leftNavLinkBuilderMock.object,
             assessmentsProvider: assessmentsProviderStub,
             assessmentsData: assessmentsDataStub,
             featureFlagStoreData: {},

src/tests/unit/tests/DetailsView/components/left-nav/visualization-based-left-nav.test.tsx

@@ -56,7 +56,6 @@ describe('VisualizationBasedLeftNav', () => {
         props = {
             deps,
             selectedKey: 'some key',
-            leftNavLinkBuilder: leftNavLinkBuilderMock.object,
             onLinkClick: onLinkClickStub,
             visualizations: visualizationsStub,
             onRightPanelContentSwitch,

src/tests/unit/tests/DetailsView/components/narrow-mode-detector.test.tsx

@@ -207,7 +207,6 @@ describe(NarrowModeDetector, () => {
             expect(
                 renderFunc({
                     width: narrowModeThresholds.collapseHeaderAndNavThreshold - 1,
-                    height: 0,
                 }),
             ).toMatchSnapshot('All narrow mode status values should be false');
         });