Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rephrase parsing instructions in assessments #6154

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

Pranav-yadav
Copy link
Contributor

@Pranav-yadav Pranav-yadav commented Oct 27, 2022

Details

chore: rephrase parsing instructions in assessments

as suggested under #6130 (comment)

Suggestion: maybe "Go to the browser tab containing your target page and, in that browser window, select the first bookmarklet"?

Motivation

closes #6130

Context

Instructions shown to user during Parsing Assessments

currently;

Run the first bookmarklet in the browser tab containing your target page. It will
send the page's DOM to the checker and show the results in a new browser tab.
</li>
<li>
Run the second bookmarklet in the browser tab containing the checker results. It

Pull request checklist

  • Addresses an existing issue: Parsing instructions can be confusing #6130
  • [-] Ran yarn null:autoadd
  • [-] Ran yarn fastpass
  • [-] Added/updated relevant unit test(s) (and ran yarn test)
  • [-] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [-] (UI changes only) Added screenshots/GIFs to description above
  • [-] (UI changes only) Verified usability with NVDA/JAWS

@Pranav-yadav Pranav-yadav requested a review from a team as a code owner October 27, 2022 16:15
@Pranav-yadav Pranav-yadav force-pushed the chore/parsing-instructions branch from 79ec812 to 923c18e Compare October 27, 2022 16:27
@Pranav-yadav
Copy link
Contributor Author

@ferBonnin done the required changes! do review and merge :)

PS: reminder: add hacktoberfest-accepted label before merging 👍

@ferBonnin ferBonnin requested a review from waabid October 27, 2022 18:16
Copy link
Member

@waabid waabid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄

@ferBonnin ferBonnin merged commit 997a3d5 into microsoft:main Oct 27, 2022
@Pranav-yadav Pranav-yadav deleted the chore/parsing-instructions branch October 28, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing instructions can be confusing
3 participants