[DO-NOT-MERGE] Binarysearch/52 #2248

ykadowak · 2023-11-30T02:49:41Z

Description:

Related Issue:

Versions:

Go Version: 1.21.3
Docker Version: 20.10.8
Kubernetes Version: v1.28.2
NGT Version: 2.1.3

Checklist:

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer:

This reverts commit 7821619.

This reverts commit 623c302.

This reverts commit dd952e6.

This reverts commit dcf2064.

This reverts commit 3dc099a.

This reverts commit 193178e.

This reverts commit dfc9c2f.

This reverts commit c5cbfc9.

This reverts commit cadd72e.

This reverts commit 2d71cce.

…t locally (#2228)" This reverts commit 248a82a.

This reverts commit e59ded2.

This reverts commit 41cc83b.

…es (#2221)" This reverts commit 22fe741.

This reverts commit ca118d3.

This reverts commit d26b317.

This reverts commit 8197ffe.

This reverts commit 72a8582.

This reverts commit a7a746f.

…TEMPLATE (#2209)" This reverts commit 187edba.

This reverts commit ef0739c.

… cronjobs for operator to deploy index correction (#2205)" This reverts commit b4028e7.

This reverts commit 3af9773.

This reverts commit 9f27ff2.

This reverts commit 366cd02.

This reverts commit 001f741.

…2195)" This reverts commit 644d1ad.

This reverts commit 594b23b.

…es (#2192)" This reverts commit 4ada1d4.

This reverts commit a95676a.

This reverts commit 5b9dd88.

This reverts commit 74be94c.

This reverts commit ed6118a.

This reverts commit ac21880.

…TEMPLATE (#2164)" This reverts commit f38d948.

This reverts commit 3320464.

This reverts commit 2573b91.

…TEMPLATE (#2162)" This reverts commit 3fd6552.

cloudflare-workers-and-pages · 2023-11-30T02:49:58Z

Deploying with Cloudflare Pages

Latest commit:	`6ddf899`
Status:	✅ Deploy successful!
Preview URL:	https://45bf20f2.vald.pages.dev
Branch Preview URL:	https://binarysearch-52.vald.pages.dev

View logs

vdaas-ci · 2023-11-30T02:52:07Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

LanguageTool

docs/api/remove.md|178 col 59| “Google” is a proper noun and needs to be capitalized. (A_GOOGLE[1])
Suggestions: Google
Rule: https://community.languagetool.org/rule/show/A_GOOGLE?lang=en-US&subId=1
Category: GRAMMAR
docs/api/remove.md|254 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/remove.md|254 col 22| If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING
docs/api/remove.md|254 col 50| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/remove.md|268 col 7| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|86 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/search.md|134 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|190 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|238 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|295 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/search.md|344 col 59| “Google” is a proper noun and needs to be capitalized. (A_GOOGLE[1])
Suggestions: Google
Rule: https://community.languagetool.org/rule/show/A_GOOGLE?lang=en-US&subId=1
Category: GRAMMAR
docs/api/search.md|357 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|414 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|463 col 59| “Google” is a proper noun and needs to be capitalized. (A_GOOGLE[1])
Suggestions: Google
Rule: https://community.languagetool.org/rule/show/A_GOOGLE?lang=en-US&subId=1
Category: GRAMMAR
docs/api/search.md|476 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|546 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/search.md|604 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|675 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|733 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|786 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/search.md|832 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|887 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|933 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|988 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/search.md|1035 col 59| “Google” is a proper noun and needs to be capitalized. (A_GOOGLE[1])
Suggestions: Google
Rule: https://community.languagetool.org/rule/show/A_GOOGLE?lang=en-US&subId=1
Category: GRAMMAR
docs/api/search.md|1048 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|1103 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|1150 col 59| “Google” is a proper noun and needs to be capitalized. (A_GOOGLE[1])
Suggestions: Google
Rule: https://community.languagetool.org/rule/show/A_GOOGLE?lang=en-US&subId=1
Category: GRAMMAR
docs/api/search.md|1163 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|1231 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/search.md|1287 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|1356 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|1412 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/update.md|67 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/update.md|68 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/update.md|156 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/update.md|157 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/update.md|185 col 59| “Google” is a proper noun and needs to be capitalized. (A_GOOGLE[1])
Suggestions: Google
Rule: https://community.languagetool.org/rule/show/A_GOOGLE?lang=en-US&subId=1
Category: GRAMMAR
docs/api/update.md|278 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/update.md|279 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/upsert.md|71 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/upsert.md|72 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/upsert.md|159 col 6| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/upsert.md|160 col 75| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/upsert.md|188 col 57| “Google” is a proper noun and needs to be capitalized. (A_GOOGLE[1])
Suggestions: Google
Rule: https://community.languagetool.org/rule/show/A_GOOGLE?lang=en-US&subId=1
Category: GRAMMAR
docs/api/upsert.md|280 col 6| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/upsert.md|281 col 75| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/tutorial/get-started.md|326 col 8| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Conn
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/tutorial/vald-agent-standalone-on-k8s.md|239 col 8| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Conn
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/tutorial/vald-agent-standalone-on-k8s.md|340 col 31| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: IDs
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/tutorial/vald-agent-standalone-on-k8s.md|343 col 32| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: IDs
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING

github-actions · 2023-11-30T02:53:18Z

CONTRIBUTING.md

-// }
+func Test_unimplementedTest(t *testing.T) {
+    // this unit test function is not implemented yet
+}


[LanguageTool] _{reported by reviewdog 🐶}
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Func
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING

github-actions · 2023-11-30T02:53:18Z

docs/api/insert.md

    | :----: | :----- | :--------------------- | :------: | :------------------------------------------------------------- |
-    |   id   | string |                        |    \*    | The ID of a vector. ID should consist of 1 or more characters. |
-    | vector | float  | repeated(Array[float]) |    \*    | The vector data. Its dimension is between 2 and 65,536.        |
+    |   id   | string |                        |    \*    | the ID of a vector. ID should consist of 1 or more characters. |


[LanguageTool] _{reported by reviewdog 🐶}
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING

github-actions · 2023-11-30T02:53:18Z

docs/api/insert.md

-    |   id   | string |                        |    \*    | The ID of a vector. ID should consist of 1 or more characters. |
-    | vector | float  | repeated(Array[float]) |    \*    | The vector data. Its dimension is between 2 and 65,536.        |
+    |   id   | string |                        |    \*    | the ID of a vector. ID should consist of 1 or more characters. |
+    | vector | float  | repeated(Array[float]) |    \*    | the vector data. its dimension is between 2 and 65,536.        |


[LanguageTool] _{reported by reviewdog 🐶}
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING

github-actions · 2023-11-30T02:53:18Z

docs/api/insert.md

    | :----: | :----- | :--------------------- | :------: | :--------------------------------------------------------------- |
-    |   id   | string |                        |    \*    | The ID of the vector. ID should consist of 1 or more characters. |
-    | vector | float  | repeated(Array[float]) |    \*    | The vector data. Its dimension is between 2 and 65,536.          |
+    |   id   | string |                        |    \*    | the ID of the vector. ID should consist of 1 or more characters. |


[LanguageTool] _{reported by reviewdog 🐶}
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING

github-actions · 2023-11-30T02:53:18Z

docs/api/insert.md

-    |   id   | string |                        |    \*    | The ID of the vector. ID should consist of 1 or more characters. |
-    | vector | float  | repeated(Array[float]) |    \*    | The vector data. Its dimension is between 2 and 65,536.          |
+    |   id   | string |                        |    \*    | the ID of the vector. ID should consist of 1 or more characters. |
+    | vector | float  | repeated(Array[float]) |    \*    | the vector data. its dimension is between 2 and 65,536.          |


[LanguageTool] _{reported by reviewdog 🐶}
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING

github-actions · 2023-11-30T02:53:20Z

docs/api/remove.md

    | :---: | :----- | :---- | :------: | :------------------------------------------------------------- |
-    |  id   | string |       |    \*    | The ID of a vector. ID should consist of 1 or more characters. |
+    |  id   | string |       |    \*    | the ID of a vector. ID should consist of 1 or more characters. |


[LanguageTool] _{reported by reviewdog 🐶}
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING

github-actions · 2023-11-30T02:53:20Z

docs/api/remove.md

-    | config | Config    |       |    \*    | The configuration of the insert request. |
+    | field  | type      | label | required | desc.                                   |
+    | :----: | :-------- | :---- | :------: | :-------------------------------------- |
+    |   id   | Object.ID |       |    \*    | the id of vector                        |


[LanguageTool] _{reported by reviewdog 🐶}
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING

github-actions · 2023-11-30T02:53:21Z

docs/api/remove.md

-    | config | Config    |       |    \*    | The configuration of the insert request. |
+    | field  | type      | label | required | desc.                                   |
+    | :----: | :-------- | :---- | :------: | :-------------------------------------- |
+    |   id   | Object.ID |       |    \*    | the id of vector                        |


[LanguageTool] _{reported by reviewdog 🐶}
If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING

github-actions · 2023-11-30T02:53:21Z

docs/api/remove.md

-    | config | Config    |       |    \*    | The configuration of the insert request. |
+    | field  | type      | label | required | desc.                                   |
+    | :----: | :-------- | :---- | :------: | :-------------------------------------- |
+    |   id   | Object.ID |       |    \*    | the id of vector                        |


[LanguageTool] _{reported by reviewdog 🐶}
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING

github-actions · 2023-11-30T02:53:21Z

docs/api/remove.md

    | :---: | :----- | :---- | :------: | :------------------------------------------------------------- |
-    |  id   | string |       |    \*    | The ID of a vector. ID should consist of 1 or more characters. |
+    |  id   | string |       |    \*    | the ID of a vector. ID should consist of 1 or more characters. |


[LanguageTool] _{reported by reviewdog 🐶}
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING

github-actions · 2023-11-30T02:55:19Z

internal/slices/slices_test.go

+	}
+}
+
+func TestSortFunc(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
104-190 lines are duplicate of internal/slices/slices_test.go:192-278 (dupl)

github-actions · 2023-11-30T02:55:19Z

internal/slices/slices_test.go

+	}
+}
+
+func TestSortStableFunc(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
192-278 lines are duplicate of internal/slices/slices_test.go:104-190 (dupl)

github-actions · 2023-11-30T02:55:19Z

internal/slices/slices_test.go

+		return nil
+	}
+	tests := []test{
+		// TODO test cases


🚫 [golangci] _{reported by reviewdog 🐶}
internal/slices/slices_test.go:303: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)

github-actions · 2023-11-30T02:55:19Z

internal/slices/slices_test.go

+		   },
+		*/
+
+		// TODO test cases


🚫 [golangci] _{reported by reviewdog 🐶}
internal/slices/slices_test.go:322: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)

github-actions · 2023-11-30T02:55:19Z

pkg/agent/core/ngt/handler/grpc/object.go

@@ -16,6 +16,7 @@ package grpc
 import (
 	"context"
 	"fmt"
+	"sync"


🚫 [golangci] _{reported by reviewdog 🐶}
import 'sync' is not allowed from list 'main': sync is allowed only by internal/sync (depguard)

github-actions · 2023-11-30T02:55:20Z

pkg/gateway/lb/handler/grpc/aggregation.go

@@ -557,7 +559,7 @@ func newSlice(num, replica int) Aggregator {
 	}
 }

-func (*valdSliceAggr) Start(_ context.Context) {}
+func (_ *valdSliceAggr) Start(_ context.Context) {}


🚫 [golangci] _{reported by reviewdog 🐶}
ST1006: receiver name should not be an underscore, omit the name if it is unused (stylecheck)

codecov · 2023-11-30T03:04:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7821619) 30.50% compared to head (6ddf899) 31.44%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2248      +/-   ##
==========================================
+ Coverage   30.50%   31.44%   +0.93%     
==========================================
  Files         362      341      -21     
  Lines       35376    33056    -2320     
==========================================
- Hits        10792    10393     -399     
+ Misses      24073    22206    -1867     
+ Partials      511      457      -54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ykadowak added 30 commits November 30, 2023 02:49

Revert "Add read replica rotator (#2241)"

5523f15

This reverts commit 7821619.

Revert "Disable exhaustruct (#2240)"

afe497b

This reverts commit 623c302.

Revert "Add document for RemoveByTimestamp RPC (#2238)"

6da964e

This reverts commit dd952e6.

Revert "Improve index correction performance (#2234)"

b87c89f

This reverts commit dcf2064.

Revert "Implement manifests for Index Management Job (#2235)"

ff4761e

This reverts commit 3dc099a.

Revert "Refactor Index Management Job (#2232)"

79e5e58

This reverts commit 193178e.

Revert "Add job error to report index correction error status (#2231)"

ff24295

This reverts commit dfc9c2f.

Revert "Add implementation for save index job (#2227)"

e16b487

This reverts commit c5cbfc9.

Revert "fix: deleted contour ingress contoller apply (#2229)"

833fdab

This reverts commit cadd72e.

Revert "Fix invalid networkPolicy schema (#2230)"

f2827c4

This reverts commit 2d71cce.

Revert "Add minikube to create volume snapshot development environmen…

c2fb02c

…t locally (#2228)" This reverts commit 248a82a.

Revert "Add implementation for create index job (#2223)"

e69eccc

This reverts commit e59ded2.

Revert "fix: fails when there are format differences (#2226)"

41ea3e9

This reverts commit 41cc83b.

Revert ":robot: Update license headers / Format Go codes and YAML fil…

f368850

…es (#2221)" This reverts commit 22fe741.

Revert "Add index correction metrics (#2215)"

c4c5877

This reverts commit ca118d3.

Revert "Add index correction document (#2217)"

117e483

This reverts commit d26b317.

Revert "Add make command to update template (#2212)"

549c426

This reverts commit 8197ffe.

Revert "Add job to check format difference (#2214)"

fe0246d

This reverts commit 72a8582.

Revert "Enable ingress resource in the getStarted document (#2211)"

260a546

This reverts commit a7a746f.

Revert ":robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_…

faebeb5

…TEMPLATE (#2209)" This reverts commit 187edba.

Revert "update deps (#2208)"

9392285

This reverts commit ef0739c.

Revert "Add verification for index correction e2e and add clusterrole…

9b0a210

… cronjobs for operator to deploy index correction (#2205)" This reverts commit b4028e7.

Revert "Add step to get k3s latest version (#2206)"

6c7f2e7

This reverts commit 3af9773.

Revert "Add StreamListObject to LB (#2203)"

bcc256b

This reverts commit 9f27ff2.

Revert "Add index correction helm templates and E2E (#2200)"

1ace402

This reverts commit 366cd02.

Revert "Add index correction internal logic (#2194)"

da306ea

This reverts commit 001f741.

Revert "update telepresence and helm-docs installer and update deps (#…

0794174

…2195)" This reverts commit 644d1ad.

Revert "Replace x/slices with standard slices pkg (#2193)"

28b25f3

This reverts commit 594b23b.

Revert ":robot: Update license headers / Format Go codes and YAML fil…

2d8340e

…es (#2192)" This reverts commit 4ada1d4.

Revert "Add bbolt as internal/db/kvs (#2177)"

aa5d229

This reverts commit a95676a.

ykadowak added 8 commits November 30, 2023 02:49

Revert "update license text (#2169)"

045b2c6

This reverts commit 5b9dd88.

Revert "refactor search status (#2168)"

e62b152

This reverts commit 74be94c.

Revert "Add CopyBuffer to copy.go (#2167)"

8e6566c

This reverts commit ed6118a.

Revert "Fix duplicate make command (#2165)"

f5fd1e4

This reverts commit ac21880.

Revert ":robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_…

6001309

…TEMPLATE (#2164)" This reverts commit f38d948.

Revert "refactor internal/core/algorithm/ngt mutex lock timing (#2144)"

4d0e667

This reverts commit 3320464.

Revert "Add RemoveByTimestamp RPC (#2158)"

893abbc

This reverts commit 2573b91.

Revert ":robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_…

6ddf899

…TEMPLATE (#2162)" This reverts commit 3fd6552.

github-actions bot added team/set SET team team/sre SRE team area/discoverer area/manager/index area/internal type/ci area/helm area/makefile area/agent/core area/agent/sidecar area/tools/cli/loadtest area/gateway/lb area/gateway/filter size/XXXL labels Nov 30, 2023

github-actions bot reviewed Nov 30, 2023

View reviewed changes

github-actions bot added the priority/low label Nov 30, 2023

github-actions bot reviewed Nov 30, 2023

View reviewed changes

ykadowak closed this Dec 1, 2023

ykadowak deleted the binarysearch/52 branch December 1, 2023 06:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO-NOT-MERGE] Binarysearch/52 #2248

[DO-NOT-MERGE] Binarysearch/52 #2248

ykadowak commented Nov 30, 2023

cloudflare-workers-and-pages bot commented Nov 30, 2023

vdaas-ci commented Nov 30, 2023

github-actions bot left a comment

github-actions bot Nov 30, 2023

github-actions bot Nov 30, 2023

github-actions bot Nov 30, 2023

github-actions bot Nov 30, 2023

github-actions bot Nov 30, 2023

github-actions bot Nov 30, 2023

github-actions bot Nov 30, 2023

github-actions bot Nov 30, 2023

github-actions bot Nov 30, 2023

github-actions bot Nov 30, 2023

github-actions bot Nov 30, 2023

github-actions bot Nov 30, 2023

github-actions bot Nov 30, 2023

github-actions bot Nov 30, 2023

github-actions bot Nov 30, 2023

github-actions bot Nov 30, 2023

codecov bot commented Nov 30, 2023

[DO-NOT-MERGE] Binarysearch/52 #2248

[DO-NOT-MERGE] Binarysearch/52 #2248

Conversation

ykadowak commented Nov 30, 2023

Description:

Related Issue:

Versions:

Checklist:

Special notes for your reviewer:

cloudflare-workers-and-pages bot commented Nov 30, 2023

Deploying with Cloudflare Pages

vdaas-ci commented Nov 30, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

codecov bot commented Nov 30, 2023

Codecov Report