Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor internal/core/algorithm/ngt #2144

Merged
merged 1 commit into from
Aug 31, 2023
Merged

refactor internal/core/algorithm/ngt #2144

merged 1 commit into from
Aug 31, 2023

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Jul 31, 2023 •
edited
Loading

Description:

Please review internal/core/algorithm/ngt/ngt.go only
Others are only update.

Related Issue:

Versions:

  • Go Version: 1.20.6
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.27.3
  • NGT Version: 2.0.16

Checklist:

Special notes for your reviewer:

@kpango kpango force-pushed the refactor/agent-ngt/mutex-lock branch from 00634ab to 5358674 Compare July 31, 2023 06:25
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 31, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e027255
Status: ✅  Deploy successful!
Preview URL: https://cb4390d1.vald.pages.dev
Branch Preview URL: https://refactor-agent-ngt-mutex-loc.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Jul 31, 2023 •
edited
Loading

Codecov Report

Patch coverage is 81.39% of modified lines.

❗ Current head c31b7ae differs from pull request most recent head e027255. Consider uploading reports for the commit e027255 to get more accurate results

Files Changed Coverage
internal/core/algorithm/ngt/ngt.go 81.39%

📢 Thoughts on this report? Let us know!.

@kpango kpango force-pushed the refactor/agent-ngt/mutex-lock branch from 5358674 to db4c9b7 Compare July 31, 2023 06:41
@kpango kpango force-pushed the refactor/agent-ngt/mutex-lock branch 3 times, most recently from dd05900 to 93f1c4f Compare July 31, 2023 07:15
@github-actions github-actions bot added the team/set SET team label Jul 31, 2023
@github-actions
Copy link
Contributor

[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/refactor%2Fagent-ngt%2Fmutex-lock/6c6994b395db40c64a6194393c170c7a4ee3660f

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

@kpango kpango force-pushed the refactor/agent-ngt/mutex-lock branch from 93f1c4f to fc62267 Compare July 31, 2023 08:16
@kpango kpango requested review from a team and removed request for a team August 31, 2023 05:20
@kpango kpango force-pushed the refactor/agent-ngt/mutex-lock branch from 5ddade7 to e027255 Compare August 31, 2023 05:45
@github-actions github-actions bot added size/M and removed size/M labels Aug 31, 2023
@github-actions
Copy link
Contributor

[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/refactor%2Fagent-ngt%2Fmutex-lock/b0f377e0a124b756c02e900175f489ed82e2d637

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

@kpango kpango merged commit 3320464 into main Aug 31, 2023
@kpango kpango deleted the refactor/agent-ngt/mutex-lock branch August 31, 2023 06:47
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
Merged
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "refactor internal/core/algorithm/ngt mutex lock timing (#2144)"
ee0654a 
This reverts commit 3320464.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "refactor internal/core/algorithm/ngt mutex lock timing (#2144)"
1842122 
This reverts commit 3320464.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "refactor internal/core/algorithm/ngt mutex lock timing (#2144)"
8ee1316 
This reverts commit 3320464.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "refactor internal/core/algorithm/ngt mutex lock timing (#2144)"
4d0e667 
This reverts commit 3320464.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "refactor internal/core/algorithm/ngt mutex lock timing (#2144)"
b442a7c 
This reverts commit 3320464.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datelier datelier datelier approved these changes

@kmrmt kmrmt kmrmt approved these changes

Assignees
No one assigned
Labels
actions/e2e-chaos actions/e2e-deploy actions/e2e-max-dim actions/e2e-profiling actions/fossa area/agent/core area/agent/sidecar area/discoverer area/gateway/filter area/gateway/lb area/internal area/manager/index priority/low size/L team/set SET team type/refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpango @vdaas-ci @kmrmt @datelier