Top Open PRs

[MTRichards]

@AndyScherzinger @tobiasKaminsky opened this for input on your top PRs.

@LukeOwncloud FYI.

[tobiasKaminsky]

The biggest improvement for user would be #1044 (resized images), I think.
But this might not be the best to start with as it depends on gallery+ for < OC 8.2 and gallery for => 8.2

But any PR is fine for me. Looking forward to get it started 👍
If I can help you with updating (my) PRs, please let me know!

[AndyScherzinger]

I also don't have any preferences. A top PR imho would be #1191 (Cancel upload on wlan exit) since this prevents extra costs for users for example with their data plans especially when you are abroad and leave the hotel.

My PRs can be considered rather low prio since I usually implement ui stuff so that is rather polishing work. The FAB PR (#1100) would be nice though since I adds a primary action to the UI. On the other hand my PRs should be rather simple to merge and test in comparison to PRs that add new functionality.

[MTRichards]

Hello @tobiasKaminsky @AndyScherzinger we are looking at 1191 in the next sprint - which is the next 2 weeks starting today, now that the new version is out (yeah!). Further, looking at #1100 at the top of the backlog as well (which means if we get time in the next 2 weeks, and we will get it in the next release), and then finishing the uploads view #471 in the next 2 weeks as well.

And a bug or two on the side as well. Any new PRs that would be high priority? Let us know, we can prioritize them higher for the next sprint.

[AndyScherzinger]

@MTRichards Thanks for the update! Sounds fine to me. One UI PR I would suggest would be #1413 which implements @jancborchardt requirements regarding styling of the new share privilege dialogs. The FAB #1100 would be nice but as far as I understand depends on a decision if we add another library (part of the PR) to the app or not, since Android doesn't provide a out of the box implementation for the specified "speed dial".

[LukeOwlclaw]

I support @tobiasKaminsky's suggestions for next sprint:

• Resized images #1044 and
• Multi select #1176
  They would be a huge improvement.

Further, there are 18 very small PRs (max 3 touched files, but most only 1 file).
Reviewing them and if appropriate accepting them would be great, in order to reduce the number of open PRs. Currently we are at 49. This is a little discouraging for developers...

• add question to test with official server #1539
• Update strings.xml #1494
• Pinch zoom #1466
• Add open .url file and share from web browser #1450 closed by contributor
• Fix unknown error #1395
• Multiple files upload from Google Photos application not working #1373
• Media player: Movie stop when turning device #1370 NO
• sort by date without obeying folder/files #1369
• Internal music player does not stop playing when file is deleted #1292
• Add support for new security protocols on older android versions #1226
• check status of external storage before file write/update #1221
• show big thumbnails for videos #1187
• Disable file access from the web view #1142
• add support for showing animated gifs in imagePreview #1111
• Enable fast scroll for all lists. Fixes #565 #1036
• return false if remove failed #1028
• implemented soft reference in memory cache for thumbnails #944
• Disable auto folder refresh when offline #796
• #1193 - optimizing the uploader layout & taking user configured sorting into account #1277
• #1556 - Toolbar, new Drawer and new Account Manager #1559
• moved logs from drawer menu to the settings #1552

[tobiasKaminsky]

Yeah that would be great.
I can help with update the branches and testing them.

[davivel]

I took the liberty to edit @LukeOwncloud's comment so that checboxes are shown.

I'm having a first look to the PRs in the list.

[AndyScherzinger]

I added my latest ones to the list, all more or less UI related....

• #1193 - optimizing the uploader layout & taking user configured sorting into account #1277
• #1556 - Toolbar, new Drawer and new Account Manager #1559 (new drawer + account switcher + generic oC avatars + custom server-side avatars)
• moved logs from drawer menu to the settings #1552

[davivel]

I think we should move this issue to owncloud/core#24684 .

cc @owncloud/android-developers

[davivel]

Please, everybody take there your suggestions.

[tobiasKaminsky]

I thought that the linked issue is about enhancements that are platform wide and not individual per each subsystem (calendar, contacts, gallery,...).
Devs from iOS are not interested in specific PRs from us, or?

[MTRichards]

What I think would be helpful is to add an issue to the master list @davivel pointed to, but keep a link back to the specific Android or iOS issue that discusses the change in more detail. That way there is an overview of what is going on (and some voting and prioritization), but the details are still here.

And I do think iOS is interested in some of the changes, because we will want to make the user experience similar over time.

[tobiasKaminsky]

Ok, I see the point.
I have added a description for my very favourite PR (#1599) and hope that it gets upvoted :)

[MTRichards]

Thank you!

[rperezb]

@tobiasKaminsky certainly yes! from iOS team we are also interesting in what it's going on Android and back way, no doubt! the goal is to build a platform. I'd go one step away and add the desktop client too.
We try to propagate what it's being done on each client, for instance, when we implemented the internal sharing we took care of following similar approaches
btw, voted your suggestion 😄