sort by date without obeying folder/files #1369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@AndyScherzinger @davivel @przybylski please review |
| } else if (o2.isFolder()) { | ||
| return 1; | ||
| } else if (o1.getModificationTimestamp() == 0 || o2.getModificationTimestamp() == 0){ | ||
| if (o1.getModificationTimestamp() == 0 || o2.getModificationTimestamp() == 0){ |
There was a problem hiding this comment.
I don't really like that if there is no timestamp we artificially making it equal with everything. This leads to unexpected behavior when we do have multiple zeros in collection.
I would rather not take any special care of this and boil down compare method to something like this:
public int compare(OCFile o1, OCFile o2) {
return val * (o1.getModificationTimestamp() - o2.getModificationTimestamp());
}There was a problem hiding this comment.
Yeah, but this is already the current behaviour.
So, we should discuss this in another issue?
(Although I do not know how often this problem might occur as the modification timestamp should always be set, or?
There was a problem hiding this comment.
In that case its ok for me to be merged
Closed
|
To be done in #2710 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #1334