Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable file access from the web view #1142

Merged
merged 2 commits into from
Apr 25, 2016
Merged

Disable file access from the web view #1142

merged 2 commits into from
Apr 25, 2016

Conversation

LukasReschke
Copy link
Member

This is probably not required here and good practise as a further hardening.

Fixes #1143

@masensio
Copy link

masensio commented Sep 9, 2015

Thanks @LukasReschke for the fix.
Before merging this PR we need to ensure the app works properly if Saml is enabled as authentication method.

Ready to be tested.

@rperezb rperezb added this to the backlog milestone Oct 15, 2015
@LukeOwlclaw LukeOwlclaw mentioned this pull request Mar 18, 2016
@davivel
Copy link
Contributor

davivel commented Mar 30, 2016

@rperezb , probably we should push this up in priority with the other tiny PRs to merge next.

@LukasReschke
Copy link
Member Author

Yeah. Would be great to have. THX.

@rperezb
Copy link

rperezb commented Mar 30, 2016

👍

@rperezb rperezb modified the milestones: 1.9.3-next, backlog Mar 30, 2016
This is probably not required here and good practise as a further hardening.
@davivel davivel force-pushed the LukasReschke-patch-1 branch from aa46f97 to 5e65c15 Compare April 25, 2016 07:47
@davivel
Copy link
Contributor

davivel commented Apr 25, 2016

👍, waiting for Travis...

@davivel
Copy link
Contributor

davivel commented Apr 25, 2016

In! Thanks, @LukasReschke

@davivel davivel merged commit ca3b1e8 into master Apr 25, 2016
@davivel davivel deleted the LukasReschke-patch-1 branch April 25, 2016 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants