Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new security protocols on older android versions #1226

Conversation

SandroMachado
Copy link

With this pull request the application should update its own security provider enabling by default the latests security protocols and increase the overall app security.
The workaround introduced by owncloud/android-library#43 can also be removed. Updating the security provider also fix the android issues with TLS on API levels 16 to 20.

This PR should also close the issues related to problems with security protocols like #470

Travis integration is broken because it is necessary to add support for the google play services compile 'com.google.android.gms:play-services-base:8.1.0'.

@SandroMachado SandroMachado force-pushed the support/add-support-for-tls-older-android-versions branch 3 times, most recently from 3a76327 to 62ecb05 Compare October 30, 2015 00:43
@SandroMachado SandroMachado force-pushed the support/add-support-for-tls-older-android-versions branch from 62ecb05 to d6b2eb7 Compare October 30, 2015 00:44
@tobiasKaminsky
Copy link
Contributor

Requiring Google Play Services is, for me, a no go.
Why is this necessary? Can we omit this dependency?

@SandroMachado
Copy link
Author

We need the Google Play Services Base dependency because it is the only way to update the application context with the latest updates for the Security Provider. We only need the base dependency, so it is not the full google play services library.

Since the application is available through the Google Play Store, most part of the users will have the google play services and should be seamless to them the update. If the user does not have the google play services, the app will also work without breaking. This PR will increase the support and the security of the application.

@kha0S
Copy link

kha0S commented Oct 30, 2015

👍 for merging. This will disable insecure encryption methods.

@ghost
Copy link

ghost commented Feb 22, 2016

Thanks a lot for your contribution!
Contributions to the core repo require a signed contributors agreement http://owncloud.org/about/contributor-agreement/

Alternatively you can add a comment here where you state that this contribution is MIT licensed.

Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

@SandroMachado
Copy link
Author

This contribution is MIT licensed.

@AndyScherzinger
Copy link
Contributor

@SandroMachado the build is broken. Most likely due to the missing exploded jar/aar for the ant build and its corresponding build scripts. This would need to be fixed in order to be able to merge this in case @davivel and @masensio (core team) decide that this should be merged.

@SandroMachado
Copy link
Author

@AndyScherzinger thanks for the feedback.

@AndyScherzinger
Copy link
Contributor

@SandroMachado you are very welcome! Also I saw that the PR has merge conflicts which would need to be resolved. But as I said you probably should wait for the feedback from @davivel and @masensio before putting any more effort into it.

@LukeOwlclaw LukeOwlclaw mentioned this pull request Mar 18, 2016
@jesmrec
Copy link
Collaborator

jesmrec commented Jun 26, 2019

TLS 1.2 already supported

@jesmrec jesmrec closed this Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants