Pinch zoom #1466
Closed
Pinch zoom #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,6 +65,8 @@ | |||
| private static final String KEY_TOPS = "TOPS"; | |||
| private static final String KEY_HEIGHT_CELL = "HEIGHT_CELL"; | |||
| private static final String KEY_EMPTY_LIST_MESSAGE = "EMPTY_LIST_MESSAGE"; | |||
| private static final String GRID_COLUMNS = "gridColumns"; | |||
| private ScaleGestureDetector SGD = null; | |||
There was a problem hiding this comment.
since its is not a static it should be mSGD or even better mScaleGestureDetector, SGD is too enigmatic
|
mkay, review done |
Closed
| } | ||
|
|
||
| SharedPreferences appPreferences = PreferenceManager | ||
| .getDefaultSharedPreferences(MainApp.getAppContext()); |
There was a problem hiding this comment.
To minimize dependencies you could use getActivity() as a context. Or is there any specific reason to use application context here ?
There was a problem hiding this comment.
No, I do not think so -> changed.
|
Bump, one more issue in the code. |
| @@ -241,6 +290,10 @@ public void onSaveInstanceState(Bundle savedInstanceState) { | |||
| savedInstanceState.putIntegerArrayList(KEY_TOPS, mTops); | |||
| savedInstanceState.putInt(KEY_HEIGHT_CELL, mHeightCell); | |||
| savedInstanceState.putString(KEY_EMPTY_LIST_MESSAGE, getEmptyViewText()); | |||
|
|
|||
| SharedPreferences.Editor editor = PreferenceManager | |||
| .getDefaultSharedPreferences(MainApp.getAppContext()).edit(); | |||
|
@przybylski finally done ;) |
|
@tobiasKaminsky Can you rebase? |
|
needs to be done in a modern way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1402